mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 12:03:21 +01:00
Code Issues Releases Wiki Activity

Fix bugs #46615 & #46945 - Fail gracefully if store folder is not writable during update.

Browse Source 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9768 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Andreas Fischer 2009-07-17 11:32:27 +00:00
parent 6cacfce937
commit ab9715a9fe
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
phpBB/docs/CHANGELOG.html
View File

@ -157,6 +157,7 @@
<li>[Fix] Force full date for PMs print-view (Patch by nickvergessen)</li> <li>[Fix] Force full date for PMs print-view (Patch by nickvergessen)</li>
<li>[Fix] Fix &quot;Always show a scrollbar for short pages&quot; for IE8 and Firefox 3.5 (Bug #47865 - Patch by stokerpiller)</li> <li>[Fix] Fix &quot;Always show a scrollbar for short pages&quot; for IE8 and Firefox 3.5 (Bug #47865 - Patch by stokerpiller)</li>
<li>[Fix] Do not allow setting group as default group for pending user (Bug #45675 - Patch by nickvergessen)</li> <li>[Fix] Do not allow setting group as default group for pending user (Bug #45675 - Patch by nickvergessen)</li>
<li>[Fix] Fail gracefully if store folder is not writable during update. (Bugs #46615, #46945)</li>
<li>[Change] Change the data format of the default file ACM to be more secure from tampering and have better performance.</li> <li>[Change] Change the data format of the default file ACM to be more secure from tampering and have better performance.</li>
<li>[Change] Add index on log_time to the log table to prevent slowdown on boards with many log entries. (Bug #44665 - Patch by bantu)</li> <li>[Change] Add index on log_time to the log table to prevent slowdown on boards with many log entries. (Bug #44665 - Patch by bantu)</li>
<li>[Change] Template engine now permits to a limited extent variable includes.</li> <li>[Change] Template engine now permits to a limited extent variable includes.</li>

7
phpBB/includes/functions_compress.php
View File

@ -155,7 +155,12 @@ class compress_zip extends compress
*/ */
function compress_zip($mode, $file) function compress_zip($mode, $file)
{ {
return $this->fp = @fopen($file, $mode . 'b'); $this->fp = @fopen($file, $mode . 'b');
if (!$this->fp)
{
trigger_error('Unable to open file ' . $file . ' [' . $mode . 'b]');
}
} }
/** /**

5
phpBB/install/install_update.php
View File

@ -915,6 +915,11 @@ class install_update extends module
// Now init the connection // Now init the connection
if ($update_mode == 'download') if ($update_mode == 'download')
{ {
if (function_exists('phpbb_is_writable') && !phpbb_is_writable($phpbb_root_path . 'store/'))
{
trigger_error(sprintf($user->lang['DIRECTORY_NOT_WRITABLE'], $phpbb_root_path . 'store/'), E_USER_ERROR);
}
if ($use_method == '.zip') if ($use_method == '.zip')
{ {
$compress = new compress_zip('w', $phpbb_root_path . 'store/' . $archive_filename . $use_method); $compress = new compress_zip('w', $phpbb_root_path . 'store/' . $archive_filename . $use_method);