mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-08 17:56:52 +02:00
Code Issues Releases Wiki Activity

[ticket/17176] Resolve deprecation notices

Browse Source 
PHPBB3-17176
This commit is contained in:
Marc Alexander
2023-08-19 22:05:37 +02:00
parent daf30b89f1
commit abd29e96b5
22 changed files with 57 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/mock/lang.php
View File

@@ -17,25 +17,25 @@
*/
class phpbb_mock_lang implements ArrayAccess
{
public function offsetExists($offset)
public function offsetExists($offset): bool
{
return true;
}
public function offsetGet($offset)
public function offsetGet($offset): mixed
{
return $offset;
}
public function offsetSet($offset, $value)
public function offsetSet($offset, $value): void
{
}
public function offsetUnset($offset)
public function offsetUnset($offset): void
{
}
public function lang()
public function lang(): string
{
return implode(' ', func_get_args());
}

6
tests/mock/request.php
View File

@@ -41,13 +41,13 @@ class phpbb_mock_request extends \phpbb\request\request
public function variable($var_name, $default, $multibyte = false, $super_global = \phpbb\request\request_interface::REQUEST)
{
return isset($this->data[$super_global][$var_name]) ? $this->data[$super_global][$var_name] : $default;
return $this->data[$super_global][$var_name] ?? $default;
}
public function server($var_name, $default = '')
{
$super_global = \phpbb\request\request_interface::SERVER;
return isset($this->data[$super_global][$var_name]) ? $this->data[$super_global][$var_name] : $default;
return $this->data[$super_global][$var_name] ?? $default;
}
public function header($header_name, $default = '')
@@ -115,7 +115,7 @@ class phpbb_mock_request extends \phpbb\request\request
$this->data[\phpbb\request\request_interface::SERVER][$var_name] = $value;
}
public function merge($super_global = \phpbb\request\request_interface::REQUEST, $values)
public function merge($values, $super_global = \phpbb\request\request_interface::REQUEST): void
{
$this->data[$super_global] = array_merge($this->data[$super_global], $values);
}

4
tests/notification/submit_post_base.php
View File

@@ -80,6 +80,7 @@ abstract class phpbb_notification_submit_post_base extends phpbb_database_test_c
'num_posts' => 1,
'allow_board_notifications' => true,
'allow_mentions' => true,
'board_startdate' => 1692429414,
));
// Event dispatcher
@@ -113,8 +114,7 @@ abstract class phpbb_notification_submit_post_base extends phpbb_database_test_c
);
// Request
$type_cast_helper = $this->createMock('\phpbb\request\type_cast_helper_interface');
$request = $this->createMock('\phpbb\request\request');
$request = new phpbb_mock_request();
$avatar_helper = $this->getMockBuilder('\phpbb\avatar\helper')
->disableOriginalConstructor()