mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-16 04:19:41 +02:00
Code Issues Releases Wiki Activity

[ticket/12413] Fixing the failed test

Browse Source 
The test was failing because travis is too fast: 2 posts had the same
timestamp.

PHPBB3-12413
This commit is contained in:
Nicofuma 2014-04-24 00:52:04 +02:00
parent edf0fd0fbd
commit ac59b6a199
1 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tests/functional/feed_test.php
View File

@ -1,15 +1,15 @@
<?php <?php
/** /**
* *
* @package testing * @package testing
* @copyright (c) 2014 phpBB Group * @copyright (c) 2014 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
* *
*/ */
/** /**
* @group functional * @group functional
*/ */
class phpbb_functional_feed_test extends phpbb_functional_test_case class phpbb_functional_feed_test extends phpbb_functional_test_case
{ {
protected $data = array(); protected $data = array();
@ -320,9 +320,15 @@ class phpbb_functional_feed_test extends phpbb_functional_test_case
$post = $this->create_topic($this->data['forums']['Feeds #news'], 'Feeds #news - Topic #1', 'This is a test topic posted by the testing framework.'); $post = $this->create_topic($this->data['forums']['Feeds #news'], 'Feeds #news - Topic #1', 'This is a test topic posted by the testing framework.');
$this->data['topics']['Feeds #news - Topic #1'] = (int) $post['topic_id']; $this->data['topics']['Feeds #news - Topic #1'] = (int) $post['topic_id'];
// Travis is too fast, so we have to wait
sleep(1);
$post = $this->create_topic($this->data['forums']['Feeds #news'], 'Feeds #news - Topic #2', 'This is a test topic posted by the testing framework.'); $post = $this->create_topic($this->data['forums']['Feeds #news'], 'Feeds #news - Topic #2', 'This is a test topic posted by the testing framework.');
$crawler = self::request('GET', "viewtopic.php?t={$post['topic_id']}&sid={$this->sid}"); $crawler = self::request('GET', "viewtopic.php?t={$post['topic_id']}&sid={$this->sid}");
// Travis is too fast, so we have to wait
sleep(1);
$this->assertContains('Feeds #news - Topic #2', $crawler->filter('html')->text()); $this->assertContains('Feeds #news - Topic #2', $crawler->filter('html')->text());
$this->data['topics']['Feeds #news - Topic #2'] = (int) $post['topic_id']; $this->data['topics']['Feeds #news - Topic #2'] = (int) $post['topic_id'];
$this->data['posts']['Feeds #news - Topic #2'] = (int) $this->get_parameter_from_link($crawler->filter('.post')->selectLink($this->lang('POST', '', ''))->link()->getUri(), 'p'); $this->data['posts']['Feeds #news - Topic #2'] = (int) $this->get_parameter_from_link($crawler->filter('.post')->selectLink($this->lang('POST', '', ''))->link()->getUri(), 'p');
@ -448,6 +454,9 @@ class phpbb_functional_feed_test extends phpbb_functional_test_case
$post = $this->create_topic($this->data['forums']['Feeds #1'], 'Feeds #1 - Topic #1', 'This is a test topic posted by the testing framework.'); $post = $this->create_topic($this->data['forums']['Feeds #1'], 'Feeds #1 - Topic #1', 'This is a test topic posted by the testing framework.');
$this->data['topics']['Feeds #1 - Topic #1'] = (int) $post['topic_id']; $this->data['topics']['Feeds #1 - Topic #1'] = (int) $post['topic_id'];
// Travis is too fast, so we have to wait
sleep(1);
$post = $this->create_topic($this->data['forums']['Feeds #1.1'], 'Feeds #1.1 - Topic #1', 'This is a test topic posted by the testing framework.'); $post = $this->create_topic($this->data['forums']['Feeds #1.1'], 'Feeds #1.1 - Topic #1', 'This is a test topic posted by the testing framework.');
$this->data['topics']['Feeds #1.1 - Topic #1'] = (int) $post['topic_id']; $this->data['topics']['Feeds #1.1 - Topic #1'] = (int) $post['topic_id'];
} }
@ -483,6 +492,9 @@ class phpbb_functional_feed_test extends phpbb_functional_test_case
$post = $this->create_topic($this->data['forums']['Feeds #1'], 'Feeds #1 - Topic #2', 'This is a test topic posted by the testing framework.'); $post = $this->create_topic($this->data['forums']['Feeds #1'], 'Feeds #1 - Topic #2', 'This is a test topic posted by the testing framework.');
$this->data['topics']['Feeds #1 - Topic #2'] = (int) $post['topic_id']; $this->data['topics']['Feeds #1 - Topic #2'] = (int) $post['topic_id'];
// Travis is too fast, so we have to wait
sleep(1);
// Test creating a reply // Test creating a reply
$post2 = $this->create_post($this->data['forums']['Feeds #1'], $post['topic_id'], 'Re: Feeds #1 - Topic #2', 'This is a test post posted by the testing framework.'); $post2 = $this->create_post($this->data['forums']['Feeds #1'], $post['topic_id'], 'Re: Feeds #1 - Topic #2', 'This is a test post posted by the testing framework.');
$crawler = self::request('GET', "viewtopic.php?t={$post2['topic_id']}&sid={$this->sid}"); $crawler = self::request('GET', "viewtopic.php?t={$post2['topic_id']}&sid={$this->sid}");