From ae9c4068e7bdb61c7ec67dfc3fb98803d15759d1 Mon Sep 17 00:00:00 2001 From: Chris Smith Date: Mon, 24 Nov 2008 07:22:28 +0000 Subject: [PATCH] Deprecate S_ROW_COUNT, remove *really* old assignments from the code git-svn-id: file:///svn/phpbb/trunk@9107 89ea8834-ac86-4346-8a33-228a782c2dd0 --- phpBB/includes/ucp/ucp_groups.php | 10 +++------- phpBB/styles/prosilver/template/drafts.html | 2 +- phpBB/styles/prosilver/template/faq_body.html | 8 ++++---- phpBB/styles/prosilver/template/mcp_forum.html | 2 +- phpBB/styles/prosilver/template/mcp_front.html | 6 +++--- phpBB/styles/prosilver/template/mcp_logs.html | 2 +- phpBB/styles/prosilver/template/mcp_notes_user.html | 2 +- phpBB/styles/prosilver/template/mcp_post.html | 4 ++-- phpBB/styles/prosilver/template/mcp_queue.html | 2 +- phpBB/styles/prosilver/template/mcp_reports.html | 2 +- phpBB/styles/prosilver/template/mcp_topic.html | 2 +- phpBB/styles/prosilver/template/mcp_warn_front.html | 4 ++-- phpBB/styles/prosilver/template/mcp_warn_list.html | 2 +- phpBB/styles/prosilver/template/memberlist_body.html | 2 +- .../styles/prosilver/template/memberlist_leaders.html | 4 ++-- phpBB/styles/prosilver/template/posting_editor.html | 6 +++--- phpBB/styles/prosilver/template/posting_review.html | 2 +- .../prosilver/template/posting_topic_review.html | 2 +- phpBB/styles/prosilver/template/search_body.html | 2 +- phpBB/styles/prosilver/template/search_results.html | 4 ++-- phpBB/styles/prosilver/template/ucp_attachments.html | 2 +- .../styles/prosilver/template/ucp_avatar_options.html | 4 ++-- phpBB/styles/prosilver/template/ucp_groups_manage.html | 6 +++--- .../prosilver/template/ucp_groups_membership.html | 8 ++++---- .../styles/prosilver/template/ucp_main_bookmarks.html | 2 +- phpBB/styles/prosilver/template/ucp_main_drafts.html | 2 +- phpBB/styles/prosilver/template/ucp_main_front.html | 2 +- .../styles/prosilver/template/ucp_main_subscribed.html | 4 ++-- phpBB/styles/prosilver/template/ucp_pm_history.html | 2 +- phpBB/styles/prosilver/template/ucp_pm_viewfolder.html | 2 +- phpBB/styles/prosilver/template/viewforum_body.html | 2 +- phpBB/styles/prosilver/template/viewonline_body.html | 2 +- phpBB/styles/prosilver/template/viewtopic_body.html | 2 +- 33 files changed, 53 insertions(+), 57 deletions(-) diff --git a/phpBB/includes/ucp/ucp_groups.php b/phpBB/includes/ucp/ucp_groups.php index 0242df2fd3..3dd80fb813 100644 --- a/phpBB/includes/ucp/ucp_groups.php +++ b/phpBB/includes/ucp/ucp_groups.php @@ -297,7 +297,7 @@ class ucp_groups $result = $db->sql_query($sql); $group_id_ary = array(); - $leader_count = $member_count = $pending_count = 0; + while ($row = $db->sql_fetchrow($result)) { $block = ($row['group_leader']) ? 'leader' : (($row['user_pending']) ? 'pending' : 'member'); @@ -335,8 +335,7 @@ class ucp_groups 'U_VIEW_GROUP' => append_sid('memberlist', 'mode=group&g=' . $row['group_id']), - 'S_GROUP_DEFAULT' => ($row['group_id'] == $user->data['group_id']) ? true : false, - 'S_ROW_COUNT' => ${$block . '_count'}++) + 'S_GROUP_DEFAULT' => ($row['group_id'] == $user->data['group_id']) ? true : false) ); $group_id_ary[] = $row['group_id']; @@ -353,7 +352,6 @@ class ucp_groups ORDER BY group_type DESC, group_name"; $result = $db->sql_query($sql); - $nonmember_count = 0; while ($row = $db->sql_fetchrow($result)) { switch ($row['group_type']) @@ -389,9 +387,7 @@ class ucp_groups 'S_CAN_JOIN' => ($row['group_type'] == GROUP_OPEN || $row['group_type'] == GROUP_FREE) ? true : false, 'GROUP_COLOUR' => $row['group_colour'], - 'U_VIEW_GROUP' => append_sid('memberlist', 'mode=group&g=' . $row['group_id']), - - 'S_ROW_COUNT' => $nonmember_count++) + 'U_VIEW_GROUP' => append_sid('memberlist', 'mode=group&g=' . $row['group_id'])) ); } $db->sql_freeresult($result); diff --git a/phpBB/styles/prosilver/template/drafts.html b/phpBB/styles/prosilver/template/drafts.html index 838569ebf6..4be82f0697 100644 --- a/phpBB/styles/prosilver/template/drafts.html +++ b/phpBB/styles/prosilver/template/drafts.html @@ -24,7 +24,7 @@