mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-06 07:35:29 +02:00
Code Issues Releases Wiki Activity

[ticket/11520] Coding guideline compliance

Browse Source 
PHPBB3-11520
This commit is contained in:
Geolim4 2014-08-08 13:35:08 +02:00
parent fc1e420a7c
commit af67bd3ea5
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
phpBB/includes/mcp/mcp_main.php
View File

@ -1309,14 +1309,13 @@ function mcp_fork_topic($topic_ids)
'post_edit_locked' => (int) $row['post_edit_locked'], 'post_edit_locked' => (int) $row['post_edit_locked'],
'post_postcount' => $row['post_postcount'], 'post_postcount' => $row['post_postcount'],
); );
// Adjust post counts... only if the post can be incremented to the user counter (else, it was not added the users post count anyway) // Adjust post count only if the post can be incremented to the user counter else, it was not added the users post count anyway
//Fixed an error of phpBB: http://tracker.phpbb.com/browse/PHPBB3-11520 // Do not do the query here but later, we just increment the count of posts until the loop is finished, then do new posts counters.
//Do not do the query here but later, we just increment the count of posts until the loop is finished, then do new posts counters.
if ($row['post_postcount']) if ($row['post_postcount'])
{ {
if (isset($counter[$row['poster_id']])) if (isset($counter[$row['poster_id']]))
{ {
$counter[$row['poster_id']]++; ++$counter[$row['poster_id']];
} }
else else
{ {
@ -1442,14 +1441,14 @@ function mcp_fork_topic($topic_ids)
WHERE forum_id = ' . $to_forum_id; WHERE forum_id = ' . $to_forum_id;
$db->sql_query($sql); $db->sql_query($sql);
if (sizeof($counter)) if (!empty($counter))
{ {
//Do only one query per user and not a query PER post!! // Do only one query per user and not a query per post.
foreach ($counter AS $uid => $count) foreach ($counter as $user_id => $count)
{ {
$sql = 'UPDATE ' . USERS_TABLE . ' $sql = 'UPDATE ' . USERS_TABLE . '
SET user_posts = user_posts + ' . (int) $count . ' SET user_posts = user_posts + ' . (int) $count . '
WHERE user_id = ' . (int) $uid; WHERE user_id = ' . (int) $user_id;
$db->sql_query($sql); $db->sql_query($sql);
} }
} }