mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/17361] Use filesystem classes for tempnam and temp dir. Code reviews.

Browse Source 
PHPBB-17361
This commit is contained in:
Ruben Calvo
2024-12-24 19:30:05 +01:00
parent d6953a0422
commit b33f17e7ce
7 changed files with 86 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
phpBB/phpbb/storage/file_tracker.php
View File

@@ -19,7 +19,6 @@ use phpbb\storage\exception\storage_exception;
class file_tracker
{
/**
* @var db
*/
@@ -59,11 +58,11 @@ class file_tracker
*/
public function track_file(string $storage, string $path, int $size): void
{
$sql_ary = array(
$sql_ary = [
'file_path' => $path,
'storage' => $storage,
'filesize' => $size,
);
];
$sql = 'INSERT INTO ' . $this->storage_table . $this->db->sql_build_array('INSERT', $sql_ary);
$this->db->sql_query($sql);
@@ -80,10 +79,10 @@ class file_tracker
*/
public function untrack_file(string $storage, $path): void
{
$sql_ary = array(
$sql_ary = [
'file_path' => $path,
'storage' => $storage,
);
];
$sql = 'DELETE FROM ' . $this->storage_table . '
WHERE ' . $this->db->sql_build_array('DELETE', $sql_ary);
@@ -103,13 +102,14 @@ class file_tracker
*/
public function is_tracked(string $storage, string $path): bool
{
$sql_ary = array(
$sql_ary = [
'file_path' => $path,
'storage' => $storage,
);
];
$sql = 'SELECT file_id FROM ' . $this->storage_table . '
WHERE ' . $this->db->sql_build_array('SELECT', $sql_ary);
$sql = 'SELECT file_id
FROM ' . $this->storage_table . '
WHERE ' . $this->db->sql_build_array('SELECT', $sql_ary);
$result = $this->db->sql_query($sql);
$row = $this->db->sql_fetchrow($result);
$this->db->sql_freeresult($result);
@@ -128,13 +128,14 @@ class file_tracker
*/
public function file_size(string $storage, string $path): int
{
$sql_ary = array(
$sql_ary = [
'file_path' => $path,
'storage' => $storage,
);
];
$sql = 'SELECT filesize FROM ' . $this->storage_table . '
WHERE ' . $this->db->sql_build_array('SELECT', $sql_ary);
$sql = 'SELECT filesize
FROM ' . $this->storage_table . '
WHERE ' . $this->db->sql_build_array('SELECT', $sql_ary);
$result = $this->db->sql_query($sql);
$row = $this->db->sql_fetchrow($result);
$this->db->sql_freeresult($result);