From 1d4fbd240ef794d2a5124a0b856641ecd084fce3 Mon Sep 17 00:00:00 2001
From: Tristan Darricau <tristan.darricau@gmail.com>
Date: Thu, 21 Oct 2021 21:00:33 +0200
Subject: [PATCH] [ticket/16898] Do not restrict the debug error handler to the
 dev env

PHPBB3-16898
---
 phpBB/common.php                                     | 7 +++++++
 phpBB/config/development/config.yml                  | 1 +
 phpBB/phpbb/di/extension/container_configuration.php | 1 +
 3 files changed, 9 insertions(+)

diff --git a/phpBB/common.php b/phpBB/common.php
index e25274d3f4..3811cc9ef6 100644
--- a/phpBB/common.php
+++ b/phpBB/common.php
@@ -96,6 +96,8 @@ include($phpbb_root_path . 'includes/functions_compatibility.' . $phpEx);
 require($phpbb_root_path . 'includes/constants.' . $phpEx);
 require($phpbb_root_path . 'includes/utf/utf_tools.' . $phpEx);
 
+// Registered before building the container so the development environment stay capable of intercepting
+// the container builder exceptions.
 if (PHPBB_ENVIRONMENT === 'development')
 {
 	\phpbb\debug\debug::enable();
@@ -129,6 +131,11 @@ catch (InvalidArgumentException $e)
 	}
 }
 
+if ($phpbb_container->getParameter('debug.error_handler'))
+{
+	\phpbb\debug\debug::enable();
+}
+
 $phpbb_class_loader->set_cache($phpbb_container->get('cache.driver'));
 $phpbb_class_loader_ext->set_cache($phpbb_container->get('cache.driver'));
 
diff --git a/phpBB/config/development/config.yml b/phpBB/config/development/config.yml
index c782e7a45f..bfee9863e6 100644
--- a/phpBB/config/development/config.yml
+++ b/phpBB/config/development/config.yml
@@ -11,6 +11,7 @@ core:
         sql_explain: true
         memory: true
         show_errors: true
+        error_handler: true
 
     twig:
         debug: true
diff --git a/phpBB/phpbb/di/extension/container_configuration.php b/phpBB/phpbb/di/extension/container_configuration.php
index e1113182b5..53ae006120 100644
--- a/phpBB/phpbb/di/extension/container_configuration.php
+++ b/phpBB/phpbb/di/extension/container_configuration.php
@@ -40,6 +40,7 @@ class container_configuration implements ConfigurationInterface
 						->booleanNode('sql_explain')->defaultValue(false)->end()
 						->booleanNode('memory')->defaultValue(false)->end()
 						->booleanNode('show_errors')->defaultValue(false)->end()
+						->booleanNode('error_handler')->defaultValue(false)->end()
 					->end()
 				->end()
 				->arrayNode('twig')