mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-11 19:24:01 +02:00
Code Issues Releases Wiki Activity

Merge pull request #2566 from marc1706/ticket/11711

Browse Source 
[ticket/11711] Inform user of unsupported characters while posting

* marc1706/ticket/11711:
  [ticket/11711] Improve coding and comments of character check
  [ticket/11711] Reduce size of tests and also test topic titles
  [ticket/11711] Improve checks for unsupported characters and check subject
  [ticket/11711] Inform user of unsupported characters while posting
This commit is contained in:
Joas Schilling
2014-06-20 10:51:58 +02:00
parent ccb8fd18e2 5ee7f20f4e
commit b855f5fc6a
5 changed files with 51 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/functional/posting_test.php
View File

@@ -36,4 +36,27 @@ class phpbb_functional_posting_test extends phpbb_functional_test_case
$crawler = self::request('GET', "posting.php?mode=quote&f=2&t={$post2['topic_id']}&p={$post2['post_id']}&sid={$this->sid}");
$this->assertContains('This is a test post posted by the testing framework.', $crawler->filter('html')->text());
}
public function test_unsupported_characters()
{
$this->login();
$this->add_lang('posting');
self::create_post(2,
1,
'Unsupported characters',
"This is a test with these weird characters: \xF0\x9F\x88\xB3 \xF0\x9F\x9A\xB6",
array(),
'Your message contains the following unsupported characters'
);
self::create_post(2,
1,
"Unsupported: \xF0\x9F\x88\xB3 \xF0\x9F\x9A\xB6",
'This is a test with emoji characters in the topic title.',
array(),
'Your subject contains the following unsupported characters'
);
}
}

10
tests/test_framework/phpbb_functional_test_case.php
View File

@@ -1076,9 +1076,17 @@ class phpbb_functional_test_case extends phpbb_test_case
if ($expected !== '')
{
$this->assertContainsLang($expected, $crawler->filter('html')->text());
if (isset($this->lang[$expected]))
{
$this->assertContainsLang($expected, $crawler->filter('html')->text());
}
else
{
$this->assertContains($expected, $crawler->filter('html')->text());
}
return null;
}
$url = $crawler->selectLink($form_data['subject'])->link()->getUri();
return array(