diff --git a/phpBB/includes/mcp/mcp_post.php b/phpBB/includes/mcp/mcp_post.php index 8d278079fb..42985b3c79 100644 --- a/phpBB/includes/mcp/mcp_post.php +++ b/phpBB/includes/mcp/mcp_post.php @@ -363,14 +363,16 @@ function mcp_post_details($id, $mode, $action) /** @var \phpbb\pagination $pagination */ $pagination = $phpbb_container->get('pagination'); - $rdns_ip_num = $request->variable('rdns', ''); $start_users = $request->variable('start_users', 0); + $rdns_ip_num = $request->variable('rdns', ''); + $lookup_all = $rdns_ip_num === 'all'; - if ($rdns_ip_num != 'all') + $base_url = $url . '&i=main&mode=post_details'; + $base_url .= $lookup_all ? '&rdns=all' : ''; + + if (!$lookup_all) { - $template->assign_vars(array( - 'U_LOOKUP_ALL' => "$url&i=main&mode=post_details&rdns=all") - ); + $template->assign_var('U_LOOKUP_ALL', $base_url . '&rdns=all'); } $num_users = false; @@ -405,7 +407,7 @@ function mcp_post_details($id, $mode, $action) } $pagination->generate_template_pagination( - $url . '&i=main&mode=post_details', + $base_url, 'pagination', 'start_users', $num_users, @@ -475,7 +477,7 @@ function mcp_post_details($id, $mode, $action) 'NUM_POSTS' => $row['postings'], 'L_POST_S' => ($row['postings'] == 1) ? $user->lang['POST'] : $user->lang['POSTS'], - 'U_LOOKUP_IP' => ($rdns_ip_num == $row['poster_ip'] || $rdns_ip_num == 'all') ? '' : "$url&i=$id&mode=post_details&rdns={$row['poster_ip']}#ip", + 'U_LOOKUP_IP' => (!$lookup_all && $rdns_ip_num != $row['poster_ip']) ? "$base_url&start_ips={$start_ips}&rdns={$row['poster_ip']}#ip" : '', 'U_WHOIS' => append_sid("{$phpbb_root_path}mcp.$phpEx", "i=$id&mode=$mode&action=whois&p=$post_id&ip={$row['poster_ip']}")) ); } @@ -489,7 +491,7 @@ function mcp_post_details($id, $mode, $action) } $pagination->generate_template_pagination( - $url . '&i=main&mode=post_details', + $base_url, 'pagination_ips', 'start_ips', $num_ips, diff --git a/phpBB/styles/prosilver/template/mcp_post.html b/phpBB/styles/prosilver/template/mcp_post.html index cd6da1199d..0f231b1e74 100644 --- a/phpBB/styles/prosilver/template/mcp_post.html +++ b/phpBB/styles/prosilver/template/mcp_post.html @@ -329,9 +329,11 @@ </tbody> </table> - <div class="buttons"> - <p><a href="{U_LOOKUP_ALL}#ip">{L_LOOKUP_ALL}</a></p> - </div> + {% if U_LOOKUP_ALL %} + <div class="buttons"> + <p><a href="{U_LOOKUP_ALL}#ip">{L_LOOKUP_ALL}</a></p> + </div> + {% endif %} <div class="pagination"> <ul>