Merge pull request #2967 from nickvergessen/ticket/12963

[ticket/12963] Revert back to "migrations" folder name for extensions

* nickvergessen/ticket/12963:
  [ticket/12963] Always use core_path and core_directory()
  [ticket/12963] Remove old migration/ folder from tests
  [ticket/12963] Revert back to "migrations" folder name for extensions

phpBB/install/database_update.php

@@ -181,17 +181,9 @@ $phpbb_extension_manager = $phpbb_container->get('ext.manager');
 $migrations = $phpbb_extension_manager
 	->get_finder()
 	->core_path('phpbb/db/migration/data/')
-	->extension_directory('/migration')
-	->get_classes();
-
-// @deprecated 3.1.0-RC4 (To be removed: 3.2.0)
-$migrations_deprecated = $phpbb_extension_manager
-	->get_finder()
 	->extension_directory('/migrations')
 	->get_classes();
 
-$migrations = array_merge($migrations, $migrations_deprecated);
-
 $migrator->set_migrations($migrations);
 
 // What is a safe limit of execution time? Half the max execution time should be safe.

phpBB/phpbb/console/command/db/migrate.php

@@ -117,17 +117,9 @@ class migrate extends \phpbb\console\command\command
 		$migrations = $this->extension_manager
 			->get_finder()
 			->core_path('phpbb/db/migration/data/')
-			->extension_directory('/migration')
-			->get_classes();
-
-		// @deprecated 3.1.0-RC4 (To be removed: 3.2.0)
-		$migrations_deprecated = $this->extension_manager
-			->get_finder()
 			->extension_directory('/migrations')
 			->get_classes();
 
-		$migrations = array_merge($migrations, $migrations_deprecated);
-
 		$this->migrator->set_migrations($migrations);
 	}
 

phpBB/phpbb/extension/base.php

@@ -132,20 +132,11 @@ class base implements \phpbb\extension\extension_interface
 
 		// Only have the finder search in this extension path directory
 		$migrations = $this->extension_finder
-			->extension_directory('/migration')
+			->extension_directory('/migrations')
 			->find_from_extension($this->extension_name, $this->extension_path);
 
 		$migrations = $this->extension_finder->get_classes_from_files($migrations);
 
-		// @deprecated 3.1.0-RC4 (To be removed: 3.2.0)
-		$migrations_deprecated = $this->extension_finder
-			->extension_directory('/migrations')
-			->find_from_extension($this->extension_name, $this->extension_path);
-
-		$migrations_deprecated = $this->extension_finder->get_classes_from_files($migrations_deprecated);
-
-		$migrations = array_merge($migrations, $migrations_deprecated);
-
 		return $migrations;
 	}
 }

tests/extension/ext/vendor2/bar/migration/migration.php

@@ -1,18 +0,0 @@
-<?php
-/**
-*
-* This file is part of the phpBB Forum Software package.
-*
-* @copyright (c) phpBB Limited <https://www.phpbb.com>
-* @license GNU General Public License, version 2 (GPL-2.0)
-*
-* For full copyright and license information, please see
-* the docs/CREDITS.txt file.
-*
-*/
-
-namespace vendor2\bar\migration;
-
-class migration extends \phpbb\db\migration\migration
-{
-}

tests/extension/ext/vendor2/foo/migrations/migration.php

@@ -1,18 +0,0 @@
-<?php
-/**
-*
-* This file is part of the phpBB Forum Software package.
-*
-* @copyright (c) phpBB Limited <https://www.phpbb.com>
-* @license GNU General Public License, version 2 (GPL-2.0)
-*
-* For full copyright and license information, please see
-* the docs/CREDITS.txt file.
-*
-*/
-
-namespace vendor2\foo\migrations;
-
-class migration extends \phpbb\db\migration\migration
-{
-}

tests/extension/ext/vendor3/bar/migration/migration.php

@@ -1,18 +0,0 @@
-<?php
-/**
-*
-* This file is part of the phpBB Forum Software package.
-*
-* @copyright (c) phpBB Limited <https://www.phpbb.com>
-* @license GNU General Public License, version 2 (GPL-2.0)
-*
-* For full copyright and license information, please see
-* the docs/CREDITS.txt file.
-*
-*/
-
-namespace vendor3\bar\migration;
-
-class migration extends \phpbb\db\migration\migration
-{
-}

tests/extension/extension_base_test.php

@@ -16,6 +16,9 @@ class phpbb_extension_extension_base_test extends phpbb_test_case
 {
 	protected static $reflection_method_get_migration_file_list;
 
+	/** @var phpbb_mock_extension_manager */
+	protected $extension_manager;
+
 	public static function setUpBeforeClass()
 	{
 		parent::setUpBeforeClass();
@@ -56,18 +59,9 @@ class phpbb_extension_extension_base_test extends phpbb_test_case
 	public function data_test_suffix_get_classes()
 	{
 		return array(
-			array(
-				'vendor3/bar',
-				array('\vendor3\bar\migration\migration'),
-			),
-			array(
-				'vendor2/foo',
-				array('\vendor2\foo\migrations\migration'),
-			),
 			array(
 				'vendor2/bar',
 				array(
-					'\vendor2\bar\migration\migration',
 					'\vendor2\bar\migrations\migration',
 				),
 			),

tests/test_framework/phpbb_database_test_case.php

@@ -69,21 +69,11 @@ abstract class phpbb_database_test_case extends PHPUnit_Extensions_Database_Test
 				global $phpbb_root_path, $phpEx, $table_prefix;
 
 				$finder = new \phpbb\finder(new \phpbb\filesystem(), $phpbb_root_path, null, $phpEx);
-				$classes = $finder->core_path('phpbb/')
+				$classes = $finder->core_path('phpbb/db/migration/data/')
-					->core_directory('db/migration/data/')
-					->set_extensions($setup_extensions)
-					->extension_directory('/migration')
-					->get_classes();
-
-				// @deprecated 3.1.0-RC4 (To be removed: 3.2.0)
-				$finder = new \phpbb\finder(new \phpbb\filesystem(), $phpbb_root_path, null, $phpEx);
-				$classes_deprecated = $finder
 					->set_extensions($setup_extensions)
 					->extension_directory('/migrations')
 					->get_classes();
 
-				$classes = array_merge($classes, $classes_deprecated);
-
 				$db = new \phpbb\db\driver\sqlite();
 				$schema_generator = new \phpbb\db\migration\schema_generator($classes, new \phpbb\config\config(array()), $db, new \phpbb\db\tools($db, true), $phpbb_root_path, $phpEx, $table_prefix);
 				$schema_data = $schema_generator->get_schema();