mirror of
https://github.com/phpbb/phpbb.git
synced 2025-08-06 16:56:44 +02:00
[feature/attach-dl] phpbb_check_attach_extensions: Get rid of pass-by-reference
PHPBB3-11042
This commit is contained in:
@@ -618,21 +618,20 @@ function phpbb_increment_downloads($db, $ids)
|
||||
* Checks every attachment to see if it has an allowed extension
|
||||
*
|
||||
* @param array $extensions As generated by phpbb_cache_service::obtain_attach_extensions
|
||||
* @param array &$attachments An array of attachments to check
|
||||
* @param array $attachments An array of attachment row to check
|
||||
*
|
||||
* @return bool Whether any of the attachments had allowed extensions
|
||||
* @return array Array of attachment rows with allowed extension
|
||||
*/
|
||||
function phpbb_check_attach_extensions($extensions, &$attachments)
|
||||
function phpbb_filter_disallowed_extensions($extensions, $attachments)
|
||||
{
|
||||
$new_ary = array();
|
||||
foreach ($attachments as $attach)
|
||||
$result = array();
|
||||
foreach ($attachments as $row)
|
||||
{
|
||||
if (isset($extensions['_allowed_'][$attach['extension']]))
|
||||
if (isset($extensions['_allowed_'][$row['extension']]))
|
||||
{
|
||||
$new_ary[] = $attach;
|
||||
$result[] = $row;
|
||||
}
|
||||
}
|
||||
|
||||
$attachments = $new_ary;
|
||||
return !empty($attachments);
|
||||
return $result;
|
||||
}
|
||||
|
Reference in New Issue
Block a user