mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-22 19:07:27 +01:00
Code Issues Releases Wiki Activity

[ticket/13904] Fix fileupload functional tests

Browse Source 
PHPBB3-13904
This commit is contained in:
Marc Alexander 2015-06-02 12:22:14 +02:00
parent a53825ad76
commit c34fd1e7c0
1 changed files with 29 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
tests/functional/fileupload_remote_test.php
View File

@ -11,15 +11,17 @@
* *
*/ */
require_once __DIR__ . '/../../phpBB/includes/functions_upload.php';
/** /**
* @group functional * @group functional
*/ */
class phpbb_functional_fileupload_remote_test extends phpbb_functional_test_case class phpbb_functional_fileupload_remote_test extends phpbb_functional_test_case
{ {
/** @var \phpbb\filesystem\filesystem_interface */
protected $filesystem; protected $filesystem;
/** @var \phpbb\files\factory */
protected $factory;
public function setUp() public function setUp()
{ {
parent::setUp(); parent::setUp();
@ -41,6 +43,11 @@ class phpbb_functional_fileupload_remote_test extends phpbb_functional_test_case
$user = new phpbb_mock_user(); $user = new phpbb_mock_user();
$user->lang = new phpbb_mock_lang(); $user->lang = new phpbb_mock_lang();
$this->filesystem = new \phpbb\filesystem\filesystem(); $this->filesystem = new \phpbb\filesystem\filesystem();
$container = new phpbb_mock_container_builder();
$container->set('files.filespec', new \phpbb\files\filespec($this->filesystem));
$this->factory = new \phpbb\files\factory($container);
$container->set('files.factory', $this->factory);
} }
public function tearDown() public function tearDown()
@ -52,21 +59,33 @@ class phpbb_functional_fileupload_remote_test extends phpbb_functional_test_case
public function test_invalid_extension() public function test_invalid_extension()
{ {
$upload = new fileupload($this->filesystem, '', array('jpg'), 100); /** @var \phpbb\files\upload $upload */
$upload = new \phpbb\files\upload($this->filesystem, $this->factory);
$upload->set_error_prefix('')
->set_allowed_extensions(array('jpg'))
->set_max_filesize(100);
$file = $upload->remote_upload(self::$root_url . 'develop/blank.gif'); $file = $upload->remote_upload(self::$root_url . 'develop/blank.gif');
$this->assertEquals('URL_INVALID', $file->error[0]); $this->assertEquals('URL_INVALID', $file->error[0]);
} }
public function test_empty_file() public function test_empty_file()
{ {
$upload = new fileupload($this->filesystem, '', array('jpg'), 100); /** @var \phpbb\files\upload $upload */
$upload = new \phpbb\files\upload($this->filesystem, $this->factory);
$upload->set_error_prefix('')
->set_allowed_extensions(array('jpg'))
->set_max_filesize(100);
$file = $upload->remote_upload(self::$root_url . 'develop/blank.jpg'); $file = $upload->remote_upload(self::$root_url . 'develop/blank.jpg');
$this->assertEquals('EMPTY_REMOTE_DATA', $file->error[0]); $this->assertEquals('EMPTY_REMOTE_DATA', $file->error[0]);
} }
public function test_successful_upload() public function test_successful_upload()
{ {
$upload = new fileupload($this->filesystem, '', array('gif'), 1000); /** @var \phpbb\files\upload $upload */
$upload = new \phpbb\files\upload($this->filesystem, $this->factory);
$upload->set_error_prefix('')
->set_allowed_extensions(array('gif'))
->set_max_filesize(1000);
$file = $upload->remote_upload(self::$root_url . 'styles/prosilver/theme/images/forum_read.gif'); $file = $upload->remote_upload(self::$root_url . 'styles/prosilver/theme/images/forum_read.gif');
$this->assertEquals(0, sizeof($file->error)); $this->assertEquals(0, sizeof($file->error));
$this->assertTrue(file_exists($file->filename)); $this->assertTrue(file_exists($file->filename));
@ -74,7 +93,11 @@ class phpbb_functional_fileupload_remote_test extends phpbb_functional_test_case
public function test_too_large() public function test_too_large()
{ {
$upload = new fileupload($this->filesystem, '', array('gif'), 100); /** @var \phpbb\files\upload $upload */
$upload = new \phpbb\files\upload($this->filesystem, $this->factory);
$upload->set_error_prefix('')
->set_allowed_extensions(array('gif'))
->set_max_filesize(100);
$file = $upload->remote_upload(self::$root_url . 'styles/prosilver/theme/images/forum_read.gif'); $file = $upload->remote_upload(self::$root_url . 'styles/prosilver/theme/images/forum_read.gif');
$this->assertEquals(1, sizeof($file->error)); $this->assertEquals(1, sizeof($file->error));
$this->assertEquals('WRONG_FILESIZE', $file->error[0]); $this->assertEquals('WRONG_FILESIZE', $file->error[0]);