1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-08 10:53:13 +02:00

[ticket/217] Use positive assertions in tests.

PHPBB3-217
This commit is contained in:
Oleg Pudeyev
2011-06-05 13:48:37 -04:00
committed by rxu
parent 2d1e426ba7
commit c93164db58

View File

@ -18,18 +18,38 @@ class phpbb_url_bbcode_test extends phpbb_test_case
public function url_bbcode_test_data() public function url_bbcode_test_data()
{ {
return array( return array(
array('[url]http://www.phpbb.com/community/[/url]'), array(
array('[url=http://www.phpbb.com/community/]One line URL text[/url]'), 'url only',
array("[url=http://www.phpbb.com/community/]Multiline\x0AURL\x0Atext[/url]"), '[url]http://www.phpbb.com/community/[/url]',
array("test [url] test \x0A test [url=http://www.phpbb.com/]test[/url] test"), '[url:]http://www.phpbb.com/community/[/url:]'
array("test [url=http://www.phpbb.com/]test \x0A [url]http://phpbb.com[/url] test"), ),
array(
'url with title',
'[url=http://www.phpbb.com/community/]One line URL text[/url]',
'[url=http://www.phpbb.com/community/:]One line URL text[/url:]'
),
array(
'url with multiline title',
"[url=http://www.phpbb.com/community/]Multiline\x0AURL\x0Atext[/url]",
"[url=http://www.phpbb.com/community/:]Multiline\x0AURL\x0Atext[/url:]"
),
array(
'unclosed url with multiline',
"test [url] test \x0A test [url=http://www.phpbb.com/]test[/url] test",
"test [url] test \x0A test [url=http://www.phpbb.com/:]test[/url:] test"
),
array(
'unclosed url with multiline and title',
"test [url=http://www.phpbb.com/]test \x0A [url]http://phpbb.com[/url] test",
"test [url=http://www.phpbb.com/:]test \x0A [url]http://phpbb.com[/url:] test"
),
); );
} }
/** /**
* @dataProvider url_bbcode_test_data * @dataProvider url_bbcode_test_data
*/ */
public function test_url($message) public function test_url($description, $message, $expected)
{ {
global $user; global $user;
$user = new phpbb_mock_user; $user = new phpbb_mock_user;
@ -38,8 +58,6 @@ class phpbb_url_bbcode_test extends phpbb_test_case
$bbcode->message = $message; $bbcode->message = $message;
$bbcode->bbcode_init(false); $bbcode->bbcode_init(false);
$bbcode->parse_bbcode(); $bbcode->parse_bbcode();
$this->assertNotEquals($bbcode->message, '[url][/url]'); $this->assertEquals($expected, $bbcode->message);
$this->assertNotEquals($bbcode->message, $message);
$this->assertNotEquals($bbcode->message, NULL);
} }
} }