mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-21 10:40:58 +02:00
Code Issues Releases Wiki Activity

[ticket/11494] Use functions instead of repeating

Browse Source 
PHPBB3-11494
This commit is contained in:
Joas Schilling
2013-04-13 18:03:02 +02:00
parent 5c24474c2a
commit cbfe866eba
1 changed files with 29 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
tests/functional/memberlist_test.php
View File

@ -41,25 +41,37 @@ class phpbb_functional_memberlist_test extends phpbb_functional_test_case
$this->assertContains('admin', $crawler->filter('h2')->text()); $this->assertContains('admin', $crawler->filter('h2')->text());
} }
protected function get_memberlist_leaders_crawler()
{
$crawler = $this->request('GET', 'memberlist.php?mode=leaders&sid=' . $this->sid);
$this->assert_response_success();
return $crawler;
}
protected function get_crawler_table_text($crawler, $table)
{
return $crawler->filter('.forumbg-table')->eq($table)->text();
}
public function test_leaders() public function test_leaders()
{ {
$this->login(); $this->login();
$this->create_user('memberlist-test-moderator'); $this->create_user('memberlist-test-moderator');
$crawler = $this->request('GET', 'memberlist.php?mode=leaders&sid=' . $this->sid); $crawler = $this->get_memberlist_leaders_crawler();
$this->assert_response_success();
// Admin in admin group, but not in moderators // Admin in admin group, but not in moderators
$this->assertContains('admin', $crawler->filter('.forumbg-table')->eq(0)->text()); $this->assertContains('admin', $this->get_crawler_table_text($crawler, 0));
$this->assertNotContains('admin', $crawler->filter('.forumbg-table')->eq(1)->text()); $this->assertNotContains('admin', $this->get_crawler_table_text($crawler, 1));
// memberlist-test-user in neither group // memberlist-test-user in neither group
$this->assertNotContains('memberlist-test-user', $crawler->filter('.forumbg-table')->eq(0)->text()); $this->assertNotContains('memberlist-test-user', $this->get_crawler_table_text($crawler, 0));
$this->assertNotContains('memberlist-test-user', $crawler->filter('.forumbg-table')->eq(1)->text()); $this->assertNotContains('memberlist-test-user', $this->get_crawler_table_text($crawler, 1));
// memberlist-test-moderator in neither group // memberlist-test-moderator in neither group
$this->assertNotContains('memberlist-test-moderator', $crawler->filter('.forumbg-table')->eq(0)->text()); $this->assertNotContains('memberlist-test-moderator', $this->get_crawler_table_text($crawler, 0));
$this->assertNotContains('memberlist-test-moderator', $crawler->filter('.forumbg-table')->eq(1)->text()); $this->assertNotContains('memberlist-test-moderator', $this->get_crawler_table_text($crawler, 1));
} }
public function test_leaders_remove_users() public function test_leaders_remove_users()
@ -68,16 +80,15 @@ class phpbb_functional_memberlist_test extends phpbb_functional_test_case
// Remove admin from admins, but is now in moderators // Remove admin from admins, but is now in moderators
$this->remove_user_group('ADMINISTRATORS', array('admin')); $this->remove_user_group('ADMINISTRATORS', array('admin'));
$crawler = $this->request('GET', 'memberlist.php?mode=leaders&sid=' . $this->sid); $crawler = $this->get_memberlist_leaders_crawler();
$this->assert_response_success(); $this->assertNotContains('admin', $this->get_crawler_table_text($crawler, 0));
$this->assertNotContains('admin', $crawler->filter('.forumbg-table')->eq(0)->text()); $this->assertContains('admin', $this->get_crawler_table_text($crawler, 1));
$this->assertContains('admin', $crawler->filter('.forumbg-table')->eq(1)->text());
// Remove admin from moderators, should not be visible anymore // Remove admin from moderators, should not be visible anymore
$this->remove_user_group('GLOBAL_MODERATORS', array('admin')); $this->remove_user_group('GLOBAL_MODERATORS', array('admin'));
$crawler = $this->request('GET', 'memberlist.php?mode=leaders&sid=' . $this->sid); $crawler = $this->get_memberlist_leaders_crawler();
$this->assertNotContains('admin', $crawler->filter('.forumbg-table')->eq(0)->text()); $this->assertNotContains('admin', $this->get_crawler_table_text($crawler, 0));
$this->assertNotContains('admin', $crawler->filter('.forumbg-table')->eq(1)->text()); $this->assertNotContains('admin', $this->get_crawler_table_text($crawler, 1));
} }
public function test_leaders_add_users() public function test_leaders_add_users()
@ -86,9 +97,8 @@ class phpbb_functional_memberlist_test extends phpbb_functional_test_case
// Add memberlist-test-moderator to moderators // Add memberlist-test-moderator to moderators
$this->add_user_group('GLOBAL_MODERATORS', array('memberlist-test-moderator')); $this->add_user_group('GLOBAL_MODERATORS', array('memberlist-test-moderator'));
$crawler = $this->request('GET', 'memberlist.php?mode=leaders&sid=' . $this->sid); $crawler = $this->get_memberlist_leaders_crawler();
$this->assert_response_success(); $this->assertNotContains('memberlist-test-moderator', $this->get_crawler_table_text($crawler, 0));
$this->assertNotContains('memberlist-test-moderator', $crawler->filter('.forumbg-table')->eq(0)->text()); $this->assertContains('memberlist-test-moderator', $this->get_crawler_table_text($crawler, 1));
$this->assertContains('memberlist-test-moderator', $crawler->filter('.forumbg-table')->eq(1)->text());
} }
} }