[ticket/11150] Disable if directories not writable

PHPBB3-11150

phpBB/phpbb/composer/extension_manager.php

@@ -60,12 +60,14 @@ class extension_manager extends manager
 	 * @param filesystem		$filesystem			Filesystem object
 	 * @param string			$package_type		Composer type of managed packages
 	 * @param string			$exception_prefix	Exception prefix to use
+	 * @param string			$root_path			phpBB root path
 	 * @param config			$config				Config object
 	 */
-	public function __construct(installer $installer, driver_interface $cache, ext_manager $extension_manager, filesystem $filesystem, $package_type, $exception_prefix, config $config = null)
+	public function __construct(installer $installer, driver_interface $cache, ext_manager $extension_manager, filesystem $filesystem, $package_type, $exception_prefix, $root_path, config $config = null)
 	{
 		$this->extension_manager = $extension_manager;
 		$this->filesystem = $filesystem;
+		$this->root_path = $root_path;
 
 		if ($config)
 		{
@@ -282,6 +284,14 @@ class extension_manager extends manager
 		}
 	}
 
+	/**
+	 * {@inheritdoc}
+	 */
+	public function check_requirements()
+	{
+		return parent::check_requirements() && $this->filesystem->is_writable($this->root_path . 'ext/');
+	}
+
 	/**
 	 * Enable the extensions when installing
 	 *

phpBB/phpbb/composer/installer.php

@@ -77,7 +77,13 @@ class installer
 	{
 		if ($config)
 		{
-			$this->repositories        = (array) unserialize($config['exts_composer_repositories']);
+			$repositories        = unserialize($config['exts_composer_repositories']);
+
+			if (!is_array($repositories) && !empty($repositories))
+			{
+				$this->repositories = (array) $repositories;
+			}
+
 			$this->packagist           = (bool) $config['exts_composer_packagist'];
 			$this->composer_filename   = $config['exts_composer_json_file'];
 			$this->packages_vendor_dir = $config['exts_composer_vendor_dir'];
@@ -395,6 +401,22 @@ class installer
 		}
 	}
 
+	/**
+	 * Checks the requirements of the manager and returns true if it can be used.
+	 *
+	 * @return bool
+	 */
+	public function check_requirements()
+	{
+		$filesystem = new \phpbb\filesystem\filesystem();
+
+		return $filesystem->is_writable([
+			$this->root_path . $this->composer_filename,
+			$this->root_path . $this->packages_vendor_dir,
+			$this->root_path . substr($this->composer_filename, 0, -5) . '.lock',
+		]);
+	}
+
 	/**
 	 * Updates $compatible_packages with the versions of $versions compatibles with the $core_constraint
 	 *

phpBB/phpbb/composer/manager.php

@@ -276,7 +276,7 @@ class manager implements manager_interface
 	 */
 	public function check_requirements()
 	{
-		return true;
+		return $this->installer->check_requirements();
 	}
 
 	protected function normalize_version($packages)