mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 05:50:42 +02:00
Code Issues Releases Wiki Activity

[ticket/13987] Replaced optional parameter with explicit API

Browse Source 
Added disable_save() and enable_save() to toggle a dry run

PHPBB3-13987
This commit is contained in:
JoshyPHP
2015-07-06 01:57:54 +02:00
parent 7ccb638912
commit cf4cdcda58
6 changed files with 49 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
phpBB/phpbb/textreparser/base.php
View File

@@ -15,6 +15,11 @@ namespace phpbb\textreparser;
abstract class base implements reparser_interface
{
/**
* @var bool Whether to save changes to the database
*/
protected $save_changes = true;
/**
* {@inheritdoc}
*/
@@ -84,6 +89,22 @@ abstract class base implements reparser_interface
return $record;
}
/**
* Disable saving changes to the database
*/
public function disable_save()
{
$this->save_changes = false;
}
/**
* Enable saving changes to the database
*/
public function enable_save()
{
$this->save_changes = true;
}
/**
* Guess whether given BBCode is in use in given record
*
@@ -170,21 +191,20 @@ abstract class base implements reparser_interface
/**
* {@inheritdoc}
*/
public function reparse_range($min_id, $max_id, $dry_run = false)
public function reparse_range($min_id, $max_id)
{
foreach ($this->get_records_by_range($min_id, $max_id) as $record)
{
$this->reparse_record($record, $dry_run);
$this->reparse_record($record);
}
}
/**
* Reparse given record
*
* @param array $record Associative array containing the record's data
* @param integer $dry_run If TRUE, do not save the changes
* @param array $record Associative array containing the record's data
*/
protected function reparse_record(array $record, $dry_run)
protected function reparse_record(array $record)
{
$record = $this->add_missing_fields($record);
$flags = ($record['enable_bbcode']) ? OPTION_FLAG_BBCODE : 0;
@@ -214,7 +234,7 @@ abstract class base implements reparser_interface
);
// Save the new text if it has changed and it's not a dry run
if ($text !== $record['text'] && !$dry_run)
if ($text !== $record['text'] && $this->save_changes)
{
$record['text'] = $text;
$this->save_record($record);

7
phpBB/phpbb/textreparser/reparser_interface.php
View File

@@ -25,9 +25,8 @@ interface reparser_interface
/**
* Reparse all records in given range
*
* @param integer $min_id Lower bound
* @param integer $max_id Upper bound
* @param integer $dry_run If TRUE, do not save the changes
* @param integer $min_id Lower bound
* @param integer $max_id Upper bound
*/
public function reparse_range($min_id, $max_id, $dry_run = false);
public function reparse_range($min_id, $max_id);
}