mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 12:03:21 +01:00
Code Issues Releases Wiki Activity

[ticket/10972] Added explicit checks for creating duplicate users.

Browse Source 
PHPBB3-10972
This commit is contained in:
Fyorl 2012-08-10 12:31:53 +01:00 committed by Oleg Pudeyev
parent cafc7feca1
commit d33accb687
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/test_framework/phpbb_functional_test_case.php
View File

@ -30,6 +30,11 @@ class phpbb_functional_test_case extends phpbb_test_case
*/ */
protected $lang = array(); protected $lang = array();
/**
* @var array
*/
protected $created_users = array();
static protected $config = array(); static protected $config = array();
static protected $already_installed = false; static protected $already_installed = false;
@ -197,14 +202,18 @@ class phpbb_functional_test_case extends phpbb_test_case
/** /**
* Creates a new user with limited permissions * Creates a new user with limited permissions
* *
* Note that creating two users with the same name results in undefined * Always call delete_user after running a test that
* login behaviour. Always call delete_user after running a test that
* requires create_user. * requires create_user.
* *
* @param string $username Also doubles up as the user's password * @param string $username Also doubles up as the user's password
*/ */
protected function create_user($username) protected function create_user($username)
{ {
if (isset($this->created_users[$username]))
{
return;
}
// Required by unique_id // Required by unique_id
global $config; global $config;
@ -225,6 +234,7 @@ class phpbb_functional_test_case extends phpbb_test_case
"; ";
$db->sql_query($query); $db->sql_query($query);
$this->created_users[$username] = 1;
} }
/** /**
@ -234,6 +244,11 @@ class phpbb_functional_test_case extends phpbb_test_case
*/ */
protected function delete_user($username) protected function delete_user($username)
{ {
if (isset($this->created_users[$username]))
{
unset($this->created_users[$username]);
}
$db = $this->get_db(); $db = $this->get_db();
$query = "DELETE FROM " . self::$config['table_prefix'] . "users WHERE username = '" . $db->sql_escape($username) . "'"; $query = "DELETE FROM " . self::$config['table_prefix'] . "users WHERE username = '" . $db->sql_escape($username) . "'";
$db->sql_query($query); $db->sql_query($query);