mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-08 08:35:31 +02:00
Code Issues Releases Wiki Activity

[ticket/10941] Added some comments for clarification

Browse Source 
PHPBB3-10941
This commit is contained in:
Fyorl 2012-07-08 02:15:48 +01:00
parent af8020b388
commit d89af53f63
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/mock/fileupload.php
View File

@ -21,6 +21,13 @@ class phpbb_mock_fileupload
return true; return true;
} }
/**
* Copied verbatim from phpBB/includes/functions_upload.php's fileupload
* class to ensure the correct behaviour of filespec::move_file.
*
* Maps file extensions to the constant in second index of the array
* returned by getimagesize()
*/
public function image_types() public function image_types()
{ {
return array( return array(

8
tests/uploads/filespec_test.php
View File

@ -37,6 +37,9 @@ class phpbb_filespec_test extends phpbb_test_case
$config['rand_seed'] = ''; $config['rand_seed'] = '';
$config['rand_seed_last_update'] = time() + 600; $config['rand_seed_last_update'] = time() + 600;
// This config value is normally pulled from the database which is set
// to this value at install time.
// See: phpBB/install/schemas/schema_data.sql
$config['mime_triggers'] = 'body|head|html|img|plaintext|a href|pre|script|table|title'; $config['mime_triggers'] = 'body|head|html|img|plaintext|a href|pre|script|table|title';
$user = new phpbb_mock_user(); $user = new phpbb_mock_user();
@ -104,6 +107,9 @@ class phpbb_filespec_test extends phpbb_test_case
public function additional_checks_variables() public function additional_checks_variables()
{ {
// False here just indicates the file is too large and fails the
// filespec::additional_checks method because of it. All other code
// paths in that method are covered elsewhere.
return array( return array(
array('gif', true), array('gif', true),
array('jpg', false), array('jpg', false),
@ -129,6 +135,8 @@ class phpbb_filespec_test extends phpbb_test_case
public function check_content_variables() public function check_content_variables()
{ {
// False here indicates that a file is non-binary and contains
// disallowed content that makes IE report the mimetype incorrectly.
return array( return array(
array('gif', true), array('gif', true),
array('jpg', true), array('jpg', true),