1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 14:00:31 +02:00

[ticket/11314] Modify files to comply with coding standards

PHPBB3-11314
This commit is contained in:
Marc Alexander
2013-03-26 13:13:33 +01:00
parent 4870387f3a
commit f0b0978538
8 changed files with 352 additions and 734 deletions

View File

@@ -19,8 +19,7 @@ var baseHeight;
/**
* Shows the help messages in the helpline window
*/
function helpline(help)
{
function helpline(help) {
document.forms[form_name].helpbox.value = help_line[help];
}
@@ -28,28 +27,22 @@ function helpline(help)
* Fix a bug involving the TextRange object. From
* http://www.frostjedi.com/terra/scripts/demo/caretBug.html
*/
function initInsertions()
{
function initInsertions() {
var doc;
if (document.forms[form_name])
{
if (document.forms[form_name]) {
doc = document;
}
else
{
} else {
doc = opener.document;
}
var textarea = doc.forms[form_name].elements[text_name];
if (is_ie && typeof(baseHeight) !== 'number')
{
if (is_ie && typeof(baseHeight) !== 'number') {
textarea.focus();
baseHeight = doc.selection.createRange().duplicate().boundingHeight;
if (!document.forms[form_name])
{
if (!document.forms[form_name]) {
document.body.focus();
}
}
@@ -58,14 +51,10 @@ function initInsertions()
/**
* bbstyle
*/
function bbstyle(bbnumber)
{
if (bbnumber !== -1)
{
function bbstyle(bbnumber) {
if (bbnumber !== -1) {
bbfontstyle(bbtags[bbnumber], bbtags[bbnumber+1]);
}
else
{
} else {
insert_text('[*]');
document.forms[form_name].elements[text_name].focus();
}
@@ -74,30 +63,26 @@ function bbstyle(bbnumber)
/**
* Apply bbcodes
*/
function bbfontstyle(bbopen, bbclose)
{
function bbfontstyle(bbopen, bbclose) {
theSelection = false;
var textarea = document.forms[form_name].elements[text_name];
textarea.focus();
if ((clientVer >= 4) && is_ie && is_win)
{
if ((clientVer >= 4) && is_ie && is_win) {
// Get text selection
theSelection = document.selection.createRange().text;
if (theSelection)
{
if (theSelection) {
// Add tags around selection
document.selection.createRange().text = bbopen + theSelection + bbclose;
document.forms[form_name].elements[text_name].focus();
theSelection = '';
return;
}
}
else if (document.forms[form_name].elements[text_name].selectionEnd && (document.forms[form_name].elements[text_name].selectionEnd - document.forms[form_name].elements[text_name].selectionStart > 0))
{
} else if (document.forms[form_name].elements[text_name].selectionEnd
&& (document.forms[form_name].elements[text_name].selectionEnd - document.forms[form_name].elements[text_name].selectionStart > 0)) {
mozWrap(document.forms[form_name].elements[text_name], bbopen, bbclose);
document.forms[form_name].elements[text_name].focus();
theSelection = '';
@@ -113,14 +98,12 @@ function bbfontstyle(bbopen, bbclose)
// Center the cursor when we don't have a selection
// Gecko and proper browsers
if (!isNaN(textarea.selectionStart))
{
if (!isNaN(textarea.selectionStart)) {
textarea.selectionStart = new_pos;
textarea.selectionEnd = new_pos;
}
// IE
else if (document.selection)
{
else if (document.selection) {
var range = textarea.createTextRange();
range.move("character", new_pos);
range.select();
@@ -134,51 +117,39 @@ function bbfontstyle(bbopen, bbclose)
/**
* Insert text at position
*/
function insert_text(text, spaces, popup)
{
function insert_text(text, spaces, popup) {
var textarea;
if (!popup)
{
if (!popup) {
textarea = document.forms[form_name].elements[text_name];
}
else
{
} else {
textarea = opener.document.forms[form_name].elements[text_name];
}
if (spaces)
{
if (spaces) {
text = ' ' + text + ' ';
}
if (!isNaN(textarea.selectionStart))
{
if (!isNaN(textarea.selectionStart)) {
var sel_start = textarea.selectionStart;
var sel_end = textarea.selectionEnd;
mozWrap(textarea, text, '');
textarea.selectionStart = sel_start + text.length;
textarea.selectionEnd = sel_end + text.length;
}
else if (textarea.createTextRange && textarea.caretPos)
{
if (baseHeight !== textarea.caretPos.boundingHeight)
{
} else if (textarea.createTextRange && textarea.caretPos) {
if (baseHeight !== textarea.caretPos.boundingHeight) {
textarea.focus();
storeCaret(textarea);
}
var caret_pos = textarea.caretPos;
caret_pos.text = caret_pos.text.charAt(caret_pos.text.length - 1) === ' ' ? caret_pos.text + text + ' ' : caret_pos.text + text;
}
else
{
} else {
textarea.value = textarea.value + text;
}
if (!popup)
{
if (!popup) {
textarea.focus();
}
}
@@ -186,8 +157,7 @@ function insert_text(text, spaces, popup)
/**
* Add inline attachment at position
*/
function attach_inline(index, filename)
{
function attach_inline(index, filename) {
insert_text('[attachment=' + index + ']' + filename + '[/attachment]');
document.forms[form_name].elements[text_name].focus();
}
@@ -201,56 +171,39 @@ function addquote(post_id, username)
var theSelection = '';
var divarea = false;
if (document.all)
{
if (document.all) {
divarea = document.all[message_name];
}
else
{
} else {
divarea = document.getElementById(message_name);
}
// Get text selection - not only the post content :(
if (window.getSelection)
{
if (window.getSelection) {
theSelection = window.getSelection().toString();
}
else if (document.getSelection)
{
} else if (document.getSelection) {
theSelection = document.getSelection();
}
else if (document.selection)
{
} else if (document.selection) {
theSelection = document.selection.createRange().text;
}
if (theSelection === '' || typeof theSelection === 'undefined' || theSelection === null)
{
if (divarea.innerHTML)
{
if (theSelection === '' || typeof theSelection === 'undefined' || theSelection === null) {
if (divarea.innerHTML) {
theSelection = divarea.innerHTML.replace(/<br>/ig, '\n');
theSelection = theSelection.replace(/<br\/>/ig, '\n');
theSelection = theSelection.replace(/&lt\;/ig, '<');
theSelection = theSelection.replace(/&gt\;/ig, '>');
theSelection = theSelection.replace(/&amp\;/ig, '&');
theSelection = theSelection.replace(/&nbsp\;/ig, ' ');
}
else if (document.all)
{
} else if (document.all) {
theSelection = divarea.innerText;
}
else if (divarea.textContent)
{
} else if (divarea.textContent) {
theSelection = divarea.textContent;
}
else if (divarea.firstChild.nodeValue)
{
} else if (divarea.firstChild.nodeValue) {
theSelection = divarea.firstChild.nodeValue;
}
}
if (theSelection)
{
if (theSelection) {
insert_text('[quote="' + username + '"]' + theSelection + '[/quote]');
}
@@ -260,15 +213,13 @@ function addquote(post_id, username)
/**
* From http://www.massless.org/mozedit/
*/
function mozWrap(txtarea, open, close)
{
function mozWrap(txtarea, open, close) {
var selLength = (typeof(txtarea.textLength) === 'undefined') ? txtarea.value.length : txtarea.textLength;
var selStart = txtarea.selectionStart;
var selEnd = txtarea.selectionEnd;
var scrollTop = txtarea.scrollTop;
if (selEnd === 1 || selEnd === 2)
{
if (selEnd === 1 || selEnd === 2) {
selEnd = selLength;
}
@@ -289,10 +240,8 @@ function mozWrap(txtarea, open, close)
* Insert at Caret position. Code from
* http://www.faqts.com/knowledge_base/view.phtml/aid/1052/fid/130
*/
function storeCaret(textEl)
{
if (textEl.createTextRange)
{
function storeCaret(textEl) {
if (textEl.createTextRange) {
textEl.caretPos = document.selection.createRange().duplicate();
}
}
@@ -300,8 +249,7 @@ function storeCaret(textEl)
/**
* Color pallette
*/
function colorPalette(dir, width, height)
{
function colorPalette(dir, width, height) {
var r = 0, g = 0, b = 0;
var numberList = new Array(6);
var color = '';
@@ -314,36 +262,29 @@ function colorPalette(dir, width, height)
document.writeln('<table class="type2">');
for (r = 0; r < 5; r++)
{
if (dir === 'h')
{
for (r = 0; r < 5; r++) {
if (dir === 'h') {
document.writeln('<tr>');
}
for (g = 0; g < 5; g++)
{
if (dir === 'v')
{
for (g = 0; g < 5; g++) {
if (dir === 'v') {
document.writeln('<tr>');
}
for (b = 0; b < 5; b++)
{
for (b = 0; b < 5; b++) {
color = String(numberList[r]) + String(numberList[g]) + String(numberList[b]);
document.write('<td bgcolor="#' + color + '" style="width: ' + width + 'px; height: ' + height + 'px;">');
document.write('<a href="#" onclick="bbfontstyle(\'[color=#' + color + ']\', \'[/color]\'); return false;"><img src="images/spacer.gif" width="' + width + '" height="' + height + '" alt="#' + color + '" title="#' + color + '" /></a>');
document.writeln('</td>');
}
if (dir === 'v')
{
if (dir === 'v') {
document.writeln('</tr>');
}
}
if (dir === 'h')
{
if (dir === 'h') {
document.writeln('</tr>');
}
}
@@ -353,8 +294,7 @@ function colorPalette(dir, width, height)
/**
* Caret Position object
*/
function caretPosition()
{
function caretPosition() {
var start = null;
var end = null;
}
@@ -362,19 +302,16 @@ function caretPosition()
/**
* Get the caret position in an textarea
*/
function getCaretPosition(txtarea)
{
function getCaretPosition(txtarea) {
var caretPos = new caretPosition();
// simple Gecko/Opera way
if (txtarea.selectionStart || txtarea.selectionStart === 0)
{
if (txtarea.selectionStart || txtarea.selectionStart === 0) {
caretPos.start = txtarea.selectionStart;
caretPos.end = txtarea.selectionEnd;
}
// dirty and slow IE way
else if (document.selection)
{
else if (document.selection) {
// get current selection
var range = document.selection.createRange();
@@ -384,8 +321,7 @@ function getCaretPosition(txtarea)
// calculate selection start point by moving beginning of range_all to beginning of range
var sel_start;
for (sel_start = 0; range_all.compareEndPoints('StartToStart', range) < 0; sel_start++)
{
for (sel_start = 0; range_all.compareEndPoints('StartToStart', range) < 0; sel_start++) {
range_all.moveStart('character', 1);
}