mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-21 16:01:40 +02:00
Code Issues Releases Wiki Activity

[ticket/10714] Fix dependency injections in unit tests with mocks

Browse Source 
PHPBB3-10714
This commit is contained in:
Joas Schilling
2012-12-11 10:24:49 +01:00
parent 83b8b65016
commit f4bc9c1673
3 changed files with 24 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/log/add_test.php
View File

@@ -18,7 +18,16 @@ class phpbb_log_add_test extends phpbb_database_test_case
public function test_log_enabled()
{
$log = new phpbb_log(LOG_TABLE);
global $phpbb_root_path, $phpEx, $db, $phpbb_dispatcher;
$db = $this->new_dbal();
$cache = new phpbb_mock_cache;
$phpbb_dispatcher = new phpbb_mock_event_dispatcher();
$user = $this->getMock('phpbb_user');
$auth = $this->getMock('phpbb_auth');
$log = new phpbb_log($db, $user, $auth, $phpbb_dispatcher, $phpbb_root_path, $phpEx, LOG_TABLE);
$this->assertTrue($log->is_enabled(), 'Initialise failed');
$log->disable();
@@ -38,10 +47,15 @@ class phpbb_log_add_test extends phpbb_database_test_case
public function test_log_add()
{
global $db, $phpbb_dispatcher;
global $phpbb_root_path, $phpEx, $db, $phpbb_dispatcher;
$db = $this->new_dbal();
$cache = new phpbb_mock_cache;
$phpbb_dispatcher = new phpbb_mock_event_dispatcher();
$user = $this->getMock('phpbb_user');
$auth = $this->getMock('phpbb_auth');
$log = new phpbb_log($db, $user, $auth, $phpbb_dispatcher, $phpbb_root_path, $phpEx, LOG_TABLE);
$mode = 'critical';
$user_id = ANONYMOUS;
@@ -51,7 +65,6 @@ class phpbb_log_add_test extends phpbb_database_test_case
$additional_data = array();
// Add an entry successful
$log = new phpbb_log(LOG_TABLE);
$this->assertEquals(1, $log->add($mode, $user_id, $log_ip, $log_operation, $log_time));
// Disable logging for all types