From f5415619ebc49e370a4ec06cd6b664fb2456ccfe Mon Sep 17 00:00:00 2001
From: Dhruv <dhruv.goel92@gmail.com>
Date: Sat, 7 Jun 2014 01:34:20 +0530
Subject: [PATCH] [ticket/11445] Move get user's notification code into its own
 method

PHPBB3-11445
---
 phpBB/phpbb/notification/manager.php | 51 ++++++++++++++++++----------
 1 file changed, 33 insertions(+), 18 deletions(-)

diff --git a/phpBB/phpbb/notification/manager.php b/phpBB/phpbb/notification/manager.php
index ad9cd9a3ff..b787b624f6 100644
--- a/phpBB/phpbb/notification/manager.php
+++ b/phpBB/phpbb/notification/manager.php
@@ -574,6 +574,34 @@ class manager
 		return $subscription_methods;
 	}
 
+
+	/**
+	* Get user's notification data
+	*
+	* @param int $user_id The user_id of the user to get the notifications for
+	*
+	* @return array User's notification
+	*/
+	protected function get_user_notifications($user_id)
+	{
+		$sql = 'SELECT method, notify, item_type
+				FROM ' . $this->user_notifications_table . '
+				WHERE user_id = ' . (int) $user_id . '
+					AND item_id = 0';
+
+		$result = $this->db->sql_query($sql);
+		$user_notifications = array();
+
+		while ($row = $this->db->sql_fetchrow($result))
+		{
+			$user_notifications[$row['item_type']][] = $row;
+		}
+
+		$this->db->sql_freeresult($result);
+
+		return $user_notifications;
+	}
+
 	/**
 	* Get global subscriptions (item_id = 0)
 	*
@@ -587,36 +615,23 @@ class manager
 
 		$subscriptions = array();
 
-		$sql = 'SELECT method, notify, item_type
-				FROM ' . $this->user_notifications_table . '
-				WHERE user_id = ' . (int) $user_id . '
-					AND item_id = 0';
-
-		$result = $this->db->sql_query($sql);
-		$rows = array();
-
-		while ($row = $this->db->sql_fetchrow($result))
-		{
-			$rows[$row['item_type']][] = $row;
-		}
-
-		$this->db->sql_freeresult($result);
+		$user_notifications = $this->get_user_notifications($user_id);
 
 		foreach ($this->get_subscription_types() as $types)
 		{
 			foreach ($types as $id => $type)
 			{
 
-				if (empty($rows[$id]))
+				if (empty($user_notifications[$id]))
 				{
 					// No rows at all, default to ''
 					$subscriptions[$id] = array('');
 				}
 				else
 				{
-					foreach ($rows[$id] as $row)
+					foreach ($user_notifications[$id] as $user_notification)
 					{
-						if (!$row['notify'])
+						if (!$user_notification['notify'])
 						{
 							continue;
 						}
@@ -626,7 +641,7 @@ class manager
 							$subscriptions[$id] = array();
 						}
 
-						$subscriptions[$id][] = $row['method'];
+						$subscriptions[$id][] = $user_notification['method'];
 					}
 				}
 			}