mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-06 16:56:44 +02:00
Code Issues Releases Wiki Activity

[feature/controller] Check for proper status codes from controllers

Browse Source 
PHPBB3-10864
This commit is contained in:
David King
2012-11-19 12:37:20 -05:00
parent 3004350281
commit f8614bfc84
5 changed files with 29 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/functional/extension_controller_test.php
View File

@@ -116,11 +116,20 @@ class phpbb_functional_extension_controller_test extends phpbb_functional_test_c
{
$this->phpbb_extension_manager->enable('foo/bar');
$crawler = $this->request('GET', 'app.php?controller=foo/baz');
$this->assertEquals(404, $this->client->getResponse()->getStatus());
$this->assertEquals(500, $this->client->getResponse()->getStatus());
$this->assertContains('Missing value for argument #1: test in class phpbb_ext_foo_bar_controller:baz', $crawler->filter('body')->text());
$this->phpbb_extension_manager->purge('foo/bar');
}
public function test_exception_thrown_status_code()
{
$this->phpbb_extension_manager->enable('foo/bar');
$crawler = $this->request('GET', 'app.php?controller=foo/exception');
$this->assertEquals(500, $this->client->getResponse()->getStatus());
$this->assertContains('Exception thrown from foo/exception route', $crawler->filter('body')->text());
$this->phpbb_extension_manager->purge('foo/bar');
}
/**
* Check the error produced by extension at ./ext/does/not/exist.
*
@@ -133,6 +142,8 @@ class phpbb_functional_extension_controller_test extends phpbb_functional_test_c
public function test_error_ext_disabled_or_404()
{
$crawler = $this->request('GET', 'app.php?controller=does/not/exist');
// This is 500 response because the exception is thrown from within Symfony
// and does not provide a exception code, so we assign it 500 by default
$this->assertEquals(404, $this->client->getResponse()->getStatus());
$this->assertContains('No route found for "GET /does/not/exist"', $crawler->filter('body')->text());
}

4
tests/functional/fixtures/ext/foo/bar/config/routing.yml
View File

@@ -9,3 +9,7 @@ foo_baz_controller:
foo_template_controller:
pattern: /foo/template
defaults: { _controller: foo_bar.controller:template }
foo_exception_controller:
pattern: /foo/foo_exception
defaults: { _controller: foo_bar.controller:exception }

5
tests/functional/fixtures/ext/foo/bar/controller/controller.php
View File

@@ -27,4 +27,9 @@ class phpbb_ext_foo_bar_controller
return $this->helper->render('foo_bar_body.html');
}
public function exception()
{
throw new phpbb_controller_exception('Exception thrown from foo/exception route');
}
}