mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/16955] Add missing docblocks and fix unclear ones

Browse Source 
PHPBB3-16955
This commit is contained in:
Marc Alexander
2022-12-30 17:27:31 +01:00
parent 4284512594
commit fab81eca2b
7 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
phpBB/phpbb/auth/provider/oauth/oauth.php
View File

@@ -827,8 +827,7 @@ class oauth extends base
* Sets a redirect to the authorization uri.
*
* @param OAuth1Service|OAuth2Service $service The external OAuth service
* @return array Array if an error occurred,
* won't return on success
* @return array|never Array if an error occurred, won't return on success
*/
protected function set_redirect($service)
{

4
phpBB/phpbb/db/migration/tool/permission.php
View File

@@ -266,13 +266,13 @@ class permission implements \phpbb\db\migration\tool\tool_interface
* @param string $role_type The type (u_, m_, a_)
* @param string $role_description Description of the new role
*
* @return int|null Inserted SQL id or false if role already exists
* @return int|null Inserted SQL id or null if role already exists
*/
public function role_add($role_name, $role_type, $role_description = '')
{
if ($this->role_exists($role_name))
{
return;
return null;
}
$sql = 'SELECT MAX(role_order) AS max_role_order

2
phpBB/phpbb/files/factory.php
View File

@@ -35,7 +35,7 @@ class factory
*
* @param string $name Service name
*
* @return object|bool Requested service or false if service could not be
* @return object|false Requested service or false if service could not be
* found by the container
*/
public function get($name)

4
phpBB/phpbb/files/filespec.php
View File

@@ -329,7 +329,7 @@ class filespec
* Get mime type
*
* @param string $filename Filename that needs to be checked
* @return string|false Mime type of supplied filename or false if mimetype could not be guessed
* @return string Mime type of supplied filename or empty string if mimetype could not be guessed
*/
public function get_mimetype($filename)
{
@@ -343,7 +343,7 @@ class filespec
}
}
return $this->mimetype;
return $this->mimetype ?: '';
}
/**

4
phpBB/phpbb/files/filespec_storage.php
View File

@@ -313,7 +313,7 @@ class filespec_storage
* Get mime type
*
* @param string $filename Filename that needs to be checked
* @return string|false Mime type of supplied filename or false if mimetype could not be guessed
* @return string Mime type of supplied filename or empty string if mimetype could not be guessed
*/
public function get_mimetype($filename)
{
@@ -327,7 +327,7 @@ class filespec_storage
}
}
return $this->mimetype;
return $this->mimetype ?: '';
}
/**