mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-12 03:34:04 +02:00
Code Issues Releases Wiki Activity

[ticket/11444] Update tests and cleanup types/methods

Browse Source 
PHPBB3-11444
This commit is contained in:
Tristan Darricau
2015-07-09 17:04:40 +02:00
parent f29b12e353
commit fc34057f28
18 changed files with 309 additions and 356 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
phpBB/phpbb/notification/manager.php
View File

@@ -26,7 +26,7 @@ class manager
/** @var array */
protected $subscription_types;
/** @var array */
/** @var method\method_interface[] */
protected $notification_methods;
/** @var ContainerInterface */
@@ -805,8 +805,10 @@ class manager
}
/**
* Helper to get the list of methods enabled by default
*/
* Helper to get the list of methods enabled by default
*
* @return method\method_interface[]
*/
public function get_default_methods()
{
$default_methods = array();
@@ -823,8 +825,10 @@ class manager
}
/**
* Helper to get the notifications item type class and set it up
*/
* Helper to get the notifications item type class and set it up
*
* @return type\type_interface
*/
public function get_item_type_class($notification_type_name, $data = array())
{
$item = $this->load_object($notification_type_name);
@@ -835,16 +839,20 @@ class manager
}
/**
* Helper to get the notifications method class and set it up
*/
* Helper to get the notifications method class and set it up
*
* @return method\method_interface
*/
public function get_method_class($method_name)
{
return $this->load_object($method_name);
}
/**
* Helper to load objects (notification types/methods)
*/
* Helper to load objects (notification types/methods)
*
* @return method\method_interface|type\type_interface
*/
protected function load_object($object_name)
{
$object = $this->phpbb_container->get($object_name);