mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-18 23:51:49 +02:00
Code Issues Releases Wiki Activity

[feature/request-class] Remove $html_encode arg, force manual decoding

Browse Source 
PHPBB3-9716
This commit is contained in:
Igor Wiedler
2011-08-18 23:19:48 +02:00
parent b4ae124084
commit fd08cd8dd0
6 changed files with 21 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/mock/request.php
View File

@@ -25,21 +25,21 @@ class phpbb_mock_request implements phpbb_request_interface
$this->data[$super_global][$var_name] = $value;
}
public function variable($var_name, $default, $multibyte = false, $super_global = phpbb_request_interface::REQUEST, $html_encode = true)
public function variable($var_name, $default, $multibyte = false, $super_global = phpbb_request_interface::REQUEST)
{
return isset($this->data[$super_global][$var_name]) ? $this->data[$super_global][$var_name] : $default;
}
public function server($var_name, $default = '', $html_encode = false)
public function server($var_name, $default = '')
{
$super_global = phpbb_request_interface::SERVER;
return isset($this->data[$super_global][$var_name]) ? $this->data[$super_global][$var_name] : $default;
}
public function header($header_name, $default = '', $html_encode = false)
public function header($header_name, $default = '')
{
$var_name = 'HTTP_' . str_replace('-', '_', strtoupper($header_name));
return $this->server($var_name, $default, $html_encode);
return $this->server($var_name, $default);
}
public function is_set_post($name)

4
tests/request/request_test.php
View File

@@ -60,8 +60,7 @@ class phpbb_request_test extends phpbb_test_case
->with(
$this->anything(),
'',
true,
false
true
);
$this->request->server('HTTP_SOMEVAR');
@@ -80,7 +79,6 @@ class phpbb_request_test extends phpbb_test_case
->with(
$this->anything(),
'',
true,
true
);

10
tests/request/type_cast_helper_test.php
View File

@@ -48,14 +48,4 @@ class phpbb_type_cast_helper_test extends phpbb_test_case
$this->assertEquals($expected, $data);
}
public function test_simple_set_var_without_html_encoding()
{
$data = 'eviL<3';
$expected = 'eviL<3';
$this->type_cast_helper->recursive_set_var($data, '', true, false);
$this->assertEquals($expected, $data);
}
}