mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/11162] Extract existing behavior into a function and add a test.

Browse Source 
PHPBB3-11162
This commit is contained in:
Oleg Pudeyev
2012-11-02 16:05:53 -04:00
parent 88b100d818
commit fd6ee50e06
3 changed files with 150 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
phpBB/includes/functions.php
View File

@@ -1297,6 +1297,28 @@ function tz_select($default = '', $truncate = false)
return $tz_select;
}
/**
* Updates rows in given table from a set of values to a new value.
* If this results in rows violating uniqueness constraints, the duplicate
* rows are eliminated.
*
* @param dbal $db Database object
* @param string $table Table on which to perform the update
* @param string $column Column whose values to change
* @param array $from_values An array of values that should be changed
* @param int $to_value The new value
* @return null
*/
function phpbb_update_rows_avoiding_duplicates($db, $table, $column, $from_values, $to_value)
{
$db->sql_return_on_error(true);
$condition = $db->sql_in_set($column, $from_values);
$db->sql_query('UPDATE ' . $table . ' SET ' . $column . ' = ' . (int) $to_value. ' WHERE ' . $condition);
$db->sql_return_on_error(false);
$db->sql_query('DELETE FROM ' . $table . ' WHERE ' . $condition);
}
// Functions handling topic/post tracking/marking
/**
@@ -3355,7 +3377,7 @@ function parse_cfg_file($filename, $lines = false)
$parsed_items[$key] = $value;
}
if (isset($parsed_items['inherit_from']) && isset($parsed_items['name']) && $parsed_items['inherit_from'] == $parsed_items['name'])
{
unset($parsed_items['inherit_from']);