From ff56f0dcfe6355a9bd24c1e33dee15c60d01526b Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Mon, 2 Jun 2014 11:57:37 +0200 Subject: [PATCH] [ticket/11148] Remove unneeded variable mimetype and use type octet-stream The variable $mimetype is not used in the method local_upload() afterwards so it shouldn't be assigned. The correct default mimetype should be application/octet-stream and not application/octetstream according to RFC 2046. PHPBB3-11148 --- phpBB/includes/functions_upload.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/phpBB/includes/functions_upload.php b/phpBB/includes/functions_upload.php index f50ce9432f..0d33d32a1f 100644 --- a/phpBB/includes/functions_upload.php +++ b/phpBB/includes/functions_upload.php @@ -82,7 +82,7 @@ class filespec if (!$this->mimetype) { - $this->mimetype = 'application/octetstream'; + $this->mimetype = 'application/octet-stream'; } $this->extension = strtolower(self::get_extension($this->realname)); @@ -673,7 +673,6 @@ class fileupload { $upload['name'] = utf8_basename($source_file); $upload['size'] = 0; - $mimetype = 'application/octet-stream'; } else {