[ticket/16549] Rename class phpbb_lint_test rather than the test file

PHPBB3-16549
2025-07-23 10:01:55 +02:00 · 2020-09-10 20:19:21 +07:00
parent cc753db132
commit fff200b1d8
4 changed files with 5 additions and 5 deletions
--- a/tests/lint_test.php
+++ b/tests/lint_test.php
@@ -0,0 +1,105 @@
+<?php
+/**
+*
+* This file is part of the phpBB Forum Software package.
+*
+* @copyright (c) phpBB Limited <https://www.phpbb.com>
+* @license GNU General Public License, version 2 (GPL-2.0)
+*
+* For full copyright and license information, please see
+* the docs/CREDITS.txt file.
+*
+*/
+
+class lint_test extends phpbb_test_case
+{
+	static protected $php_binary;
+	static protected $exclude;
+
+	static public function setUpBeforeClass(): void
+	{
+		// Try to use PHP_BINARY constant if available so lint tests are run
+		// using the same php binary as phpunit. If not available (pre PHP
+		// 5.4), assume binary is called 'php' and is in PATH.
+		self::$php_binary = defined('PHP_BINARY') ? escapeshellcmd(PHP_BINARY) : 'php';
+
+		$output = array();
+		$status = 1;
+		exec(sprintf('(%s --version) 2>&1', self::$php_binary), $output, $status);
+		if ($status)
+		{
+			$output = implode("\n", $output);
+			if (self::$php_binary === 'php')
+			{
+				self::markTestSkipped(sprintf('php is not in PATH or broken. Output: %s', $output));
+			}
+			else
+			{
+				self::markTestSkipped(sprintf('Could not run PHP_BINARY %s. Output: %s', self::$php_binary, $output));
+			}
+		}
+	}
+
+	/**
+	 * @dataProvider lint_data
+	 */
+	public function test_lint($path)
+	{
+		$cmd = sprintf('(%s -l %s) 2>&1', self::$php_binary, escapeshellarg($path));
+		$output = array();
+		$status = 1;
+		exec($cmd, $output, $status);
+		$output = implode("\n", $output);
+		$this->assertEquals(0, $status, "PHP lint failed for $path:\n$output");
+	}
+
+	public function lint_data()
+	{
+		return $this->check(dirname(__FILE__) . '/..');
+	}
+
+	protected function check($root)
+	{
+		$files = array();
+		$dh = opendir($root);
+
+		if ($dh === false)
+		{
+			return $files;
+		}
+
+		while (($filename = readdir($dh)) !== false)
+		{
+			if ($filename == '.' || $filename == '..')
+			{
+				continue;
+			}
+			$path = $root . '/' . $filename;
+			// skip symlinks to avoid infinite loops
+			if (is_link($path))
+			{
+				continue;
+			}
+			if (is_dir($path) && !in_array($path, array(
+					dirname(__FILE__) . '/../.git',
+					dirname(__FILE__) . '/../build/new_version',
+					dirname(__FILE__) . '/../build/old_versions',
+					dirname(__FILE__) . '/../phpBB/cache',
+					dirname(__FILE__) . '/../phpBB/ext',
+					dirname(__FILE__) . '/../phpBB/store',
+					// PHP Fatal error:  Cannot declare class Container because the name is already in use in /var/www/projects/phpbb3/tests/../phpBB/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services1-1.php on line 20
+					// https://gist.github.com/e003913ffd493da63cbc
+					dirname(__FILE__) . '/../phpBB/vendor',
+					dirname(__FILE__) . '/../node_modules',
+				)))
+			{
+				$files = array_merge($files, $this->check($path));
+			}
+			else if (substr($filename, strlen($filename)-4) == '.php')
+			{
+				$files[] = array($path);
+			}
+		}
+		return $files;
+	}
+}