a643d04b05
[ticket/14572] Fix quote notification deletion
...
Some array_key calls were incorrect in the
notification checks for quotes. Two calls were
being made in a row, resulting in incorrect arrays.
PHPBB3-14572
2016-03-30 12:53:44 -04:00
186c5f4f83
Merge branch '3.1.x' into 3.2.x
2016-03-13 20:24:41 +01:00
3e278bcf0a
[ticket/14533] U_NOTIFICATION_SETTINGS doesn't return the correct URL
...
PHPBB3-14533
2016-03-12 20:53:42 +01:00
a01e3a0ffa
Merge branch '3.1.x' into 3.2.x
...
* 3.1.x:
[ticket/14132] Use transaction for adding notifications to type table
[ticket/14519] Skip query if all unread notifications are retrieved
[ticket/14483] Do not send headers by default on access via controller
Conflicts:
phpBB/phpbb/notification/manager.php
2016-03-08 22:18:42 +01:00
7c45ed0733
Merge pull request #4206 from marc1706/ticket/14519
...
[ticket/14519] Skip query if all unread notifications are retrieved
2016-03-08 22:09:02 +01:00
10004c4032
[ticket/14132] Use transaction for adding notifications to type table
...
This will prevent a race condition that might occur by two posts being
submitted at the same time with the notification type IDs not being
cached.
PHPBB3-14132
2016-03-08 12:36:29 +01:00
9fcd0b116b
[ticket/14519] Skip query if all unread notifications are retrieved
...
PHPBB3-14519
2016-03-08 12:15:21 +01:00
b490be1f81
Merge branch '3.1.x' into 3.2.x
2016-02-28 10:15:47 +01:00
fdd5a18763
[ticket/14443] Introduce additional parameter to messenger
...
PHPBB3-14443
2016-02-01 23:11:39 +01:00
257f5f8b24
Merge pull request #3971 from VSEphpbb/ticket/14237
...
[ticket/14237] Use $language class for notifications
2015-10-29 14:46:02 +01:00
7d4bbeef3f
Merge branch '3.1.x'
...
Conflicts:
phpBB/phpbb/notification/type/bookmark.php
phpBB/phpbb/notification/type/post.php
phpBB/phpbb/notification/type/quote.php
2015-10-17 12:13:32 +02:00
aaca64e13e
[ticket/13892] Replace other uses of self with static.
...
PHPBB3-13892
2015-10-15 02:39:55 -07:00
9de5668b80
[ticket/13892] Respect "Someone reports a post" notification setting.
...
report_post inherits from post_in_queue, therefore using self:: instead of
static:: results in the incorrect notification type being used to determine
which users to exclude from the notification.
PHPBB3-13892
2015-10-15 02:28:55 -07:00
28cc98a7ac
[ticket/14237] Consistent references to classes in docblocks
...
PHPBB3-14237
2015-10-14 01:05:34 -07:00
b64a37d451
[ticket/14237] Use $language class for notifications
...
PHPBB3-14237
2015-10-13 23:40:52 -07:00
e9013db9b9
[ticket/14078] Fix SQL error when editing a post with a quote
...
PHPBB3-14078
2015-09-13 22:13:02 +02:00
05d583bba7
[ticket/14079] Correctly mark notifications as read
...
PHPBB3-14079
2015-08-08 19:18:18 +02:00
7e62b3a4b0
[ticket/14076] Fix notification settings
...
PHPBB3-14076
2015-08-07 16:38:53 +02:00
452c8bef28
Merge branch '3.1.x'
...
* 3.1.x:
[ticket/13711] Notifications are sent to inactive users
2015-08-05 13:45:02 +02:00
771090f13e
[ticket/13711] Notifications are sent to inactive users
...
PHPBB3-13711
2015-07-27 06:27:25 -04:00
c1deeab318
[ticket/11444] Fix services definition
...
PHPBB3-11444
2015-07-13 22:41:14 +02:00
fc34057f28
[ticket/11444] Update tests and cleanup types/methods
...
PHPBB3-11444
2015-07-13 22:41:14 +02:00
f29b12e353
[ticket/11444] Cleanup method constructors
...
PHPBB3-11444
2015-07-13 22:41:14 +02:00
06077d9970
[ticket/11444] BC layer
...
PHPBB3-11444
2015-07-13 22:41:14 +02:00
be0d4e20d4
[ticket/11444] Moving the in-board notifications to a method class
...
Currently the in-board method for the notifications is hardcoded and
cannot be disabled. This method should be in his own class extending
`phpbb\notification\method\method_interface`.
It also add the possibility, for each method, to be enabled by default (ie:
no entry in the DB => notification enabled).
https://tracker.phpbb.com/browse/PHPBB3-11444
https://tracker.phpbb.com/browse/PHPBB3-11967
PHPBB3-11444
2015-07-13 22:41:13 +02:00
80768b526b
Merge branch '3.1.x'
...
Conflicts:
phpBB/phpbb/user_loader.php
2015-06-16 12:35:51 +02:00
dc9245dd7a
Merge pull request #3653 from callumacrae/ticket/13882
...
[ticket/13882] Lazy load the notification avatars.
2015-06-16 12:33:17 +02:00
f958d05aed
Merge branch '3.1.x'
...
* 3.1.x:
[ticket/13790] Update phpcs
Conflicts:
phpBB/composer.json
phpBB/composer.lock
2015-05-30 10:58:40 +02:00
be1d1c7d05
[ticket/13882] Lazy load the notification avatars.
...
This moves them further down the waterfall, making the page load
quicker.
PHPBB3-13882
2015-05-28 18:05:07 +02:00
a462f14aa3
[ticket/13790] Update phpcs
...
PHPBB3-13790
2015-05-19 22:19:18 +02:00
f7ad2c2b32
[ticket/13680] Renamed get_quote_authors to get_outermost_quote_authors
...
PHPBB3-13680
2015-05-15 02:12:52 +02:00
f5ce9f2738
[ticket/13680] Updated quote notifications
...
Added get_quote_authors() to text_formatter.utils service to retrieve
the names used in first-level quotes
PHPBB3-13680
2015-05-15 02:10:46 +02:00
57072a1e28
[ticket/13793] Remove translation on throwing exceptions
...
PHPBB3-13793
2015-05-01 12:40:53 +02:00
dbb538afbd
[ticket/13725] Coding guidelines: static public
...
PHPBB3-13725
2015-03-27 00:02:20 -07:00
9b5493372d
[ticket/13644] Always type hint dispatch_interface
...
PHPBB3-13644
2015-02-22 17:01:37 +01:00
a166f6f42c
[ticket/13569] Add missing sql_freeresults and remove unneeded results
...
PHPBB3-13569
2015-02-02 17:36:39 +01:00
0929267e72
[ticket/13154] Wrong variable name in the comment block
...
PHPBB3-13154
2014-12-19 11:23:23 +00:00
dd9c415020
[ticket/13154] space before @var
...
Not a tab.
PHPBB3-13154
2014-12-19 10:03:57 +00:00
13320a08ef
[ticket/13154] Forgot the $this->
...
PHPBB3-13154
2014-12-17 23:17:12 +00:00
458f9cade6
[ticket/13154] Adding phpBB dispatcher to notifications manager
...
PHPBB3-13154
2014-12-17 23:10:54 +00:00
7512efed9e
[ticket/13154] Allow filtering the list of users to be notified
...
PHPBB3-13154
2014-12-17 15:17:44 +00:00
556565d072
[ticket/13337] Allow empty array passed to sql_in_set()
...
is_array() will evaluate to true even if the array is just an empty array.
Make sure we also expect an empty array passed to sql_in_set().
PHPBB3-13337
2014-11-14 11:08:35 +01:00
cb65cd363a
[ticket/12703] Only query database for subscription types once
...
PHPBB3-12703
2014-10-26 13:56:34 -07:00
5431aa6391
[ticket/13223] Fix USERNAME email template variable in notification
...
admin_activate_user.php notification type is assigning usernames to email
template variables using user_loader->get_username() in 'no_profile' mode,
which in its turn calls get_username_string() function in 'no_profile' mode.
This causes HTML markup in emails for username colour.
PHPBB3-13223
2014-10-26 12:47:57 -07:00
fe80967535
[ticket/12990] Use the full services name for the notification's types
...
PHPBB3-12990
2014-08-16 21:46:03 +02:00
496b804a0f
[ticket/12742] Add sorting back to bookmark notification list of users
...
PHPBB3-12742
2014-08-09 17:48:59 +02:00
57d94b7bb4
[ticket/12742] Add sort options for notification types requiring sorting
...
PHPBB3-12742
2014-08-09 17:43:28 +02:00
0de1d65804
[ticket/12742] Remove unneeded sort of users
...
It doesn't matter which user will get the notification first so we shouldn't
sort the users array.
PHPBB3-12742
2014-08-09 12:49:32 +02:00
6a13f983a4
[ticket/12742] Replace authenticated with authorised
...
PHPBB3-12742
2014-08-09 12:42:14 +02:00
cccd54dde8
[ticket/12742] Add check for empty $users and add method to fitting methods
...
The method might now return an empty array in case of an empty users array,
too. The notification types then check if the returned array is empty and
return this if it is empty and if the notification types would otherwise
carry out other operations afterwards.
PHPBB3-12742
2014-08-08 16:54:23 +02:00
