# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/12349:
[ticket/12349] Fix Sniffer for @license tag
[ticket/12349] Update license header in several new files
* Marc/ticket/12362:
[ticket/12362] Do not use database test case as it's not needed
[ticket/12362] Add tests for schema generator
[ticket/12362] Throw exception in schema generator on unresolvable dependency
Currently, a link to Google and its logo are displayed in the
language/en/help_bbcode.php file to explain how to correctly format tags
and to add an image to a post. However, the Google logo is outdated and
Google does not allow the use of its logo on third-party websites. Plus,
that overload their servers. I used the blue phpBB logo to replace it
because the grey one with transparent background is hardly visible.
Originally, I just refreshed the old Google logo with the new one
(https://www.google.com/images/srpr/logo5w.png) but Joas proposed to use
the phpBB logo, and I agree with him.
PHPBB3-12361
We should only delete the topic notifications, when the topic is not approved
anymore. This happens, when the post was the last approved but is now
unapproved because the user is on queue, or when it has been softdeleted while
editing.
PHPBB3-12370
The user should be redirected back to:
- the topic, if he came from viewtopic and the topic still exists
- the forum, if he came from viewtopic, but the topic does not exist anymore
PHPBB3-11352
In 7d8b578 this line was introduced to fix a bug with style.php.
Later since 1d42d1b a new session is always created after
killing the old one.
This causes a duplicated creation of the session everytime
the user logs itself out.
PHPBB3-12360
* Marc/ticket/12150:
[ticket/12150] Use correct license URL in prune shadow migrations file
[ticket/12150] Remove 'after' for columns from migrations file
[ticket/12150] Update schema files for prune shadow topics
[ticket/12150] Use log service instead of add_log() function
[ticket/12150] Use shorter column names for prune settings
[ticket/12150] Add functional tests for pruning shadow topics
[ticket/12150] Add missing space to query for shadow topics
[ticket/12150] Add missing prune settings variables in acp_forums
[ticket/12150] Add file and caller for pruning shadow topics
[ticket/12150] Add prune columns to schema files and migration file
[ticket/12150] Add options to acp
Make sure we throw an exception in the schema generator if we come across an
unresolvable dependency. Otherwise we'll get stuck in a infinite loop that
needs to be cancelled by the user or the maximum execution time.
PHPBB3-12362
In some tests we try to make sure that we do not get the same output in a
limited timeframe. These tests should use assertSame/NotSame instead of
assertEqual/NotEqual.
PHPBB3-12354
* Marc/ticket/10851-ascraeus:
[ticket/10851] Request index instead of logging in and out in tests
[ticket/10851] Add unit and functional tests for checking attachments
[ticket/10851] Set disallowed content to empty array if checking is disabled
* Elsensee/ticket/7707:
[ticket/7707] Fix undefined variable: perm_from
[ticket/7707] Add comma to last entry of arrays
[ticket/7707] Remove unnecessary variables
[ticket/7707] Add get_username_string() once more
[ticket/7707] Remove unnecessary variables
[ticket/7707] Add get_username_string() where possible
* paybas/ticket/12339:
[ticket/12339] removed return var
[ticket/12339] more complete params and updated _since version
[ticket/12339] Add Event core.page_header_after
