[ticket/12790] Use \phpbb\db\driver\driver_interface in prune_shadow_topics
* Nicofuma/ticket/12790:
[ticket/12790] Use \phpbb\db\driver\driver_interface in prune_shadow_topics
If the current request is a AJAX we need to fix the paths.
We need to get the root path based on the Referer, so we can use
the generated URLs in the template of the Referer. If we do not
generate the relative path based on the Referer, but based on the
currently requested URL, the generated URLs will not point to the
intended locations:
Referer desired URL desired relative root path
memberlist.php faq.php ./
memberlist.php app.php/foo/bar ./
app.php/foo memberlist.php ../
app.php/foo app.php/fox ../
app.php/foo/bar memberlist.php ../../
../page.php memberlist.php ./phpBB/
../sub/page.php memberlist.php ./../phpBB/
PHPBB3-12099
If extensions authors will use profilefield_base_migration.php
class as base class for creation of CPFs, the class need to be
extended a bit.
At the moment there are two issues with it:
It does not create entries for PROFILE_FIELDS_LANG_TABLE
(as it can't know what fields to create).
The migration is not "cleaning" the DBMS after purging
the extension and leaves everything except the CPF column.
Adding profilefield_language_data
PHPBB3-12786
[ticket/12716] Add the missing parameters in the call of clearToken
* Nicofuma/ticket/12716:
[ticket/12716] Use a string as session_id
[ticket/12716] Add regression test
[ticket/12716] Add the missing parameters in the call of clearToken
[ticket/12764] Properly handle errors upon connecting to MySQLi database
* marc1706/ticket/12764:
[ticket/12764] Properly handle errors upon connecting to MySQLi database
[ticket/12771] Bug in profilefield_base_migration when used in ext
* lucifer4o/ticket/12771:
[ticket/12771] Shanging substr to strpos
[ticket/12771] Change var name
[ticket/12771] Bug in profilefield_base_migration when used in ext
Previously these would be fetched one field at one time, causing a large
number of queries in case there were large number of custom profile fields
and/or unique number of users in areas such as viewing topics. Resolve this
by caching them at once when generating data for displaying them in templates.
PHPBB3-12759
* nickvergessen/ticket/12099:
[ticket/12099] Fix correction in path_helper test
[ticket/12099] Prepend ./ to path to fix assets
[ticket/12099] Deduplicate path generation
[ticket/12099] Fix clean_path() ".." stripping when previous directory was "."
[ticket/12099] Break clean_path tests with a simple test
[ticket/12099] Clean paths in tests
[ticket/12099] Correctly fix go back to root before prepending the root path
[ticket/12099] Clean some paths before using them
[ticket/12099] Fix several issues in path_helper test
As the db_connect_id gets set up by mysql_init(), the db_connect_id will be an
object with empty settings instead of just empty. Even if mysql_real_connect()
encounters an error upon connecting, the db_connect_id is still set. This
will result in trying to just access the database which obviously does
nothing.
By setting db_connect_id to an empty string, the script will not try to query
th database and properly handle any errors that occur upon connecting.
PHPBB3-12764
The base migration class should create lang entry for the new CPF
but it is supposed to strip it of phpbb_ prefix. As extensions
CPFs do not use phpbb_ prefix it will not create a lang entry.
This is as simple solution as it can be done.
PHPBB3-12771
