31370 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
EA117	636fc7fad7	[ticket/16066] Fix FORM_INVALID always returned for banned user. ... After the introduction of add_form_key() and check_form_key() calls to login_box() in phpBB 3.2.6 and later, if a banned user attempts to login, they receive a "The submitted form was invalid. Try submitting again." Instead of the message indicating that they are banned, and why. This is happening because check_ban() actually calls into login_box() recursively, but after the $user->session_id has been switched to a new session ID for the logging-on user. Therefore, now that check_form_key() has been introduced to login_box(), it is impossible for check_form_key() to succeed during this recursive call. Fix is to make login_box()'s use of check_form_key() conditional on whether IN_CHECK_BAN is defined, so that the recursive call does not attempt to re-validate the form_key again. Note the form_key has already been successfully verified by the original call into login_box(), prior to calling into check_ban() and attempting to recursively call login_box(). So the protection of why check_form_key() was added is still intact with this change. PHPBB3-16066	2019-07-28 12:25:54 -05:00
Marc Alexander	710a0b3ea3	Merge branch '3.2.x' into 3.3.x	2019-07-28 17:55:30 +02:00
Marc Alexander	b53f95e577	Merge pull request #5494 from mrgoldy/ticket/15885 ... [ticket/15885] Display group rank on memberlist_body	2019-07-28 17:55:25 +02:00
Nekstati	6b04fda0f3	[ticket/15467] Fix JS for permissions setting ... PHPBB3-15467	2019-07-28 22:47:01 +07:00
Marc Alexander	2df9230902	Merge branch '3.2.x' into 3.3.x	2019-07-28 17:18:40 +02:00
Marc Alexander	f567b2bb69	Merge pull request #5459 from mrgoldy/ticket/15886 ... [ticket/15886] Group helper functions	2019-07-28 15:31:09 +02:00
Dark❶	8ac4f955ca	[ticket/16111] Add core.message_history_modify_sql_ary ... PHPBB3-16111	2019-07-28 18:36:37 +05:30
Dark❶	01d0457f67	[ticket/16111] Add core.message_history_modify_sql_ary ... PHPBB3-16111	2019-07-28 18:06:16 +05:30
Dark❶	5cd0aad3c6	[ticket/16111] Add core.message_history_modify_sql_ary ... PHPBB3-16111	2019-07-28 17:51:17 +05:30
rxu	4d640555ef	[ticket/15467] Fix JS for permissions setting ... PHPBB3-15467	2019-07-28 18:34:35 +07:00
Marc Alexander	cf96967677	[ticket/15886] Fix minor code style issues ... PHPBB3-15886	2019-07-28 12:21:46 +02:00
Marc Alexander	423345d517	Merge pull request #5557 from senky/ticket/15088 ... [ticket/15088] Avoid code repetitions in extension manager	2019-07-28 10:40:58 +02:00
Marc Alexander	5a76d541a2	Merge branch '3.2.x' into 3.3.x	2019-07-28 10:38:38 +02:00
Marc Alexander	ae62bc4642	Merge pull request #5575 from rubencm/ticket/14459 ... [ticket/14459] Check language input for group and fix template logic	2019-07-28 10:38:33 +02:00
rubencm	c281604d0b	[ticket/14459] Use language property ... PHPBB3-14459	2019-07-27 23:52:01 +00:00
Marc Alexander	065feb3ff9	[ticket/15088] Ensure phpBB version is set in tests ... PHPBB3-15088	2019-07-27 21:32:54 +02:00
rubencm	acb5794d50	[ticket/14459] Rename variable ... PHPBB3-14459	2019-07-27 15:15:58 +00:00
Jakub Senko	b0334d6b4f	[ticket/15088] Avoid code repetitions in extension manager ... PHPBB3-15088	2019-07-27 16:51:56 +02:00
Marc Alexander	ee51bf26fa	Merge pull request #5566 from JoshyPHP/ticket/16017 ... [ticket/16017] Add support for Argon2id as default password hashing	2019-07-27 16:30:25 +02:00
Marc Alexander	812edebfb7	Merge branch '3.2.x' into 3.3.x	2019-07-27 16:20:58 +02:00
Marc Alexander	65ff149fc9	Merge pull request #5601 from senky/ticket/16013 ... [ticket/16013] Allow admins to use disallowed username	2019-07-27 16:20:53 +02:00
Marc Alexander	31192fc08e	Merge branch '3.2.x' into 3.3.x	2019-07-27 16:18:41 +02:00
Marc Alexander	79bcb20ac5	Merge pull request #5626 from cpeel/ticket/16096 ... [ticket/16096] Use InnoDB fulltext limits for InnoDB tables	2019-07-27 16:18:37 +02:00
Marc Alexander	179f5c75ed	[ticket/16108] Use twig syntax in template event ... PHPBB3-16108	2019-07-27 16:04:48 +02:00
Marc Alexander	1a00b4a565	[ticket/16107] Use twig syntax for event ... PHPBB3-16107	2019-07-27 16:02:01 +02:00
Marc Alexander	3433f61ccb	Merge branch '3.2.x' into 3.3.x	2019-07-27 14:57:34 +02:00
Marc Alexander	d06e9745c2	Merge pull request #5631 from kasimi/ticket/16106 ... [ticket/16106] Add core.mcp_main_before	2019-07-27 14:57:30 +02:00
Marc Alexander	84fdba604d	Merge branch '3.2.x' into 3.3.x	2019-07-27 14:38:02 +02:00
Marc Alexander	1b4f82cd1d	Merge pull request #5630 from 3D-I/ticket/16103 ... [ticket/16103] Add core.pm_modify_message_subject	2019-07-27 14:37:58 +02:00
Marc Alexander	b12405dbc7	Merge branch '3.2.x' into 3.3.x	2019-07-27 14:30:35 +02:00
Marc Alexander	978d1976b0	Merge pull request #5629 from 3D-I/ticket/16102 ... [ticket/16102] Add core.posting_modify_post_subject	2019-07-27 14:30:30 +02:00
Marc Alexander	3e9682fe49	[ticket/16017] Add missing passwords.driver tag to argon2id ... PHPBB3-16017	2019-07-26 22:46:22 +02:00
Marc Alexander	33be961aa0	Merge pull request #5565 from JoshyPHP/ticket/16016 ... [ticket/16016] Add a base class for native password hashing	2019-07-26 18:20:32 +02:00
JoshyPHP	860a370e8f	[ticket/16017] Add support for Argon2id as default password hashing ... PHPBB3-16017	2019-07-23 21:30:28 +02:00
JoshyPHP	a4a5b069ec	[ticket/16016] Add a base class for native password hashing ... PHPBB3-16016	2019-07-23 21:28:05 +02:00
kasimi	7a54701612	[ticket/16108] Add topiclist_row_topic_by_author_before|after ... PHPBB3-16108	2019-07-23 21:21:54 +02:00
kasimi	2bb08f853e	[ticket/16107] Add mcp_move_destination_forum_before|after ... PHPBB3-16107	2019-07-23 21:19:05 +02:00
Marc Alexander	c382536f47	Merge branch '3.2.x' into 3.3.x	2019-07-23 21:18:27 +02:00
Marc Alexander	b59e101d8d	Merge pull request #5610 from espipj/ticket/16070 ... [ticket/16070] Remove support for WebSTAR and Xitami	2019-07-23 21:18:22 +02:00
kasimi	a12d93b8b8	[ticket/16106] Add core.mcp_main_before ... PHPBB3-16106	2019-07-23 21:13:08 +02:00
Marc Alexander	b5e6f34cd9	Merge branch '3.2.x' into 3.3.x	2019-07-23 21:08:54 +02:00
Marc Alexander	a4ad94ef5c	Merge pull request #5624 from senky/ticket/16089 ... [ticket/16089] Add core.confirm_box_ajax_before	2019-07-23 21:08:50 +02:00
Marc Alexander	ce518043e9	Merge branch '3.2.x' into 3.3.x	2019-07-22 22:17:14 +02:00
Nuno Lopes	d3c3dc24fe	[ticket/15982] fix warning with PHP >= 7.2 with Q&A captcha plugin ... PHPBB3-15982	2019-07-22 22:16:21 +02:00
Marc Alexander	58fa8eabb7	Merge branch '3.2.x' into 3.3.x	2019-07-22 21:40:12 +02:00
Marc Alexander	7c559b2912	Merge pull request #5609 from senky/ticket/15946 ... [ticket/15946] Add core.posting_modify_row_data	2019-07-22 21:40:02 +02:00
Marc Alexander	b2c5f8fb48	Merge branch '3.2.x' into 3.3.x	2019-07-22 21:31:57 +02:00
Marc Alexander	d738397e6f	Merge pull request #5606 from senky/ticket/15976 ... [ticket/15976] Reset user_passchg only if user changed password	2019-07-22 21:31:53 +02:00
Marc Alexander	01018630c9	Merge pull request #5619 from marc1706/ticket/16082 ... [ticket/16082] Remove XCache as it does not support PHP 7	2019-07-22 21:24:46 +02:00
Marc Alexander	f5d28a95b0	Merge pull request #5618 from marc1706/ticket/16081 ... [ticket/16081] Remove eAccelerator cache driver	2019-07-22 21:23:17 +02:00