mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-17 07:01:22 +02:00
Code Issues Releases Wiki Activity
37,314 Commits 18 Branches 192 Tags
21ccb804d3765d1fe2afbe9d06ee6bd875d35c44
Commit Graph

124 Commits

Author SHA1 Message Date
Marc Alexander
99884d8bbb Merge pull request #6579 from marc1706/ticket/17281 
[ticket/17281] Update to psalm 5.x
 2024-01-31 21:14:15 +01:00
Marc Alexander
661a8a6117 [ticket/17281] Update psalm config and fix issues 
PHPBB3-17281
 2023-12-30 17:41:12 +01:00
rxu
83f9838217 Merge branch 'ticket/17232' into ticket/17232-master 2023-12-20 15:58:15 +07:00
rxu
6a8140e82b [ticket/17232] Improve SQL error messages handling 
PHP 7 changes how most errors are reported by PHP. Instead of reporting errors
through the traditional error reporting mechanism used by PHP 5, most errors
are now reported by throwing Error exceptions.
Use it to display meaningful SQL error messages instead of PHP fatal errors
for SQL errors.

PHPBB3-17232
 2023-12-20 15:07:14 +07:00
Marc Alexander
295fcc771b [ticket/17176] Pass query_id by ref in sql_fetchfield() 
PHPBB3-17176
 2023-09-18 19:28:21 +02:00
Marc Alexander
eed92e766f [ticket/17176] Do not always create a new connection in database tests 
PHPBB3-17176
 2023-09-18 19:28:20 +02:00
Marc Alexander
8a2199ed6c [ticket/17176] Clean up database code to prevent test issues 
PHPBB3-17176
 2023-09-18 19:28:20 +02:00
Marc Alexander
ac9659c38f [ticket/17176] Resolve psalm issues after PHP version update 
PHPBB3-17176
 2023-09-18 19:28:20 +02:00
Marc Alexander
1a6de696b1 [ticket/12439] Unify behavior and deduplicate sql_multi_insert 
PHPBB3-12439
 2023-07-02 10:48:46 +02:00
rxu
3e37770b61 Merge branch 'ticket/17142' into ticket/17142-master 2023-06-08 10:20:24 +07:00
rxu
1eb81e9b2a [ticket/17142] Fix class inheritance issues 
PHPBB3-17142
 2023-06-08 10:11:54 +07:00
rxu
7adee3c50d [ticket/17142] Fix DBMS+cache related PHP warnings while installing 
PHPBB3-17142
 2023-06-08 00:59:32 +07:00
Marc Alexander
80e55b2ec8 Merge branch '3.3.x' 2023-04-11 22:22:26 +02:00
Marc Alexander
b5c316c9c3 [ticket/8071] Make nextid alias of sql_last_inserted_id and add deprecation 
PHPBB3-8071
 2023-01-31 17:17:42 +01:00
Ruben Calvo
3e8fced5c8 [ticket/16955] Fix phpdoc annotations and return types 
PHPBB3-16955
 2022-12-31 16:18:06 +01:00
Marc Alexander
cedd447659 [ticket/16955] Resolve incompatibilities with doctum 
PHPBB3-16955
 2022-12-28 08:37:25 +01:00
Marc Alexander
eeeb69b4ae [ticket/16955] Clean up auth classes 
PHPBB3-16955
 2022-12-28 08:37:24 +01:00
Marc Alexander
948023078b [ticket/16955] Clean up code in db classes 
PHPBB3-16955
 2022-12-28 08:37:20 +01:00
Marc Alexander
cd026245fe [ticket/16955] Improve minor docblock quirks 
PHPBB3-16955
 2022-12-28 08:37:09 +01:00
lionel-rowe
9fb98201f2 [ticket/8071] Add sql_last_inserted_id alias for sql_nextid 
Fixes [DBAL function sql_nextid - name is
misleading](https://tracker.phpbb.com/browse/PHPBB3-8071).

Per the tracker issue:
> This function gets the ID of the last inserted row, not the ID of the next row
to be inserted (which is difficult due to different autoincrement steps and also
lends itself nicely to race conditions).

@iwisdom replied that the naming is consistent with how PHP itself names this
functionality, but the link they posted doesn't support that (I guess this is
referring to a much older version of PHP? The comment is from 2009).

PHPBB3-8071
 2022-04-26 15:03:42 +01:00
Tristan Darricau
b8d555f56a [ticket/16741] Specific DBs fixes 
MSSQL:
- Fix bool type
- Fix comparator
- Drop Default constraint before deleting column
- Rename Default constraint to use phpBB's names
- Re-create the indices when changing the type of one column
- Uses varchar instead of varbinary

PostgreSQL:
- Creates auto increment sequences by hand instead of using serial
  in order to use phpBB's names
- Drop constraint on unique / primary indices

Oracle:
- Rename indices to use phpBB's names
- Fix string not null behaviour
- Fix broken regex in Oracle driver
- Handle to long indices on Oracle
- Rename auto_increment trigger and sequence
- Automatically lowercase keys in assoc results

PHPBB3-16741
 2021-11-11 04:55:28 +01:00
Tristan Darricau
ede9a6815a [ticket/16897] Ignores sqlite3 warnings when an explain query plan query fails 
PHPBB3-16897
 2021-10-28 21:52:03 +02:00
rxu
721a39502a [ticket/16840] Add PHP 8.0 / 8.1 builds for Windows tests 
Also fix Postrges PHP 8.1 related issue.

PHPBB3-16840
 2021-08-07 16:50:45 +07:00
Marc Alexander
ecc79ea2ec Merge branch 'prep-release-3.3.4' into 3.3.x 2021-05-01 21:51:16 +02:00
rxu
3d5639a844 [ticket/16749] Explicitly set default MySQLi error mode 
PHPBB3-16749
 2021-04-04 17:11:59 +07:00
Marc Alexander
4ce8224c2c [ticket/16740] Use is_resource() to check whether connect id is still valid 
PHPBB3-16740
 2021-03-31 21:22:14 +02:00
Marc Alexander
c99bfe116f [ticket/16740] Improve open queries handling & do not close freed connection 
PHPBB3-16740
 2021-03-28 09:52:55 +02:00
Marc Alexander
645e662b11 [ticket/16740] Add method for ensuring resource is not passed to cache 
PHPBB3-16740
 2021-03-26 22:54:19 +01:00
rxu
2fd4dbb685 [ticket/16690] Fix htmlspecialchars and htmlspecialchars_decode default flag 
PHPBB3-16690
 2021-01-20 00:21:24 +07:00
Máté Bartus
b3e7c01ab6 [ticket/16671] Fix coding style 
PHPBB3-166671
 2020-12-31 14:50:28 +01:00
Marc Alexander
e769ac7941 Merge pull request #6052 from rxu/ticket/16607 
[ticket/16607] Update Oracle DBAL driver OCI8 aliases and functions
 2020-12-22 21:25:47 +01:00
rxu
46d0cf7bb4 [ticket/16607] Update Oracle DBAL driver OCI8 aliases and functions 
PHPBB3-16607
 2020-09-29 22:13:19 +07:00
rxu
0bc9d87891 [ticket/16538] Add identifiers quoting 
If reserved word is used as identifier, it must be quoted.
If alias is used elsewhere in SQL statement, it must be quoted.

PHPBB3-16535
PHPBB3-16538
 2020-08-14 04:51:11 +07:00
Marc Alexander
af97a8312c Merge branch '3.2.x' into 3.3.x 2020-05-04 20:37:38 +02:00
mrgoldy
ed974c2c84 [ticket/16467] Fix PostgreSQL connection password 
PHPBB3-16467
 2020-05-04 11:49:45 +02:00
rxu
75c03dd81e [ticket/16307] Fix SQL time reporting when debug.sql_explain parameter is set 
PHPBB3-16307
 2020-01-08 22:05:55 +07:00
Marc Alexander
bd02c5bd08 [ticket/16051] Remove mysql driver as it's no longer supported in PHP >= 7.0 
PHPBB3-16051
 2019-10-06 12:07:35 +02:00
Marc Alexander
a7c02304a5 Merge branch '3.2.x' into 3.3.x 2019-09-20 22:23:06 +02:00
Marc Alexander
4555817a8b [ticket/security/247] Disable loading of local files on client side 
SECURITY-247
 2019-08-11 21:31:59 +02:00
Jakub Senko
139eb17bb7 [ticket/12624] Add debug.load_time parameter 
PHPBB3-12624
 2019-05-09 18:40:15 +02:00
Jakub Senko
b4d4336ef4 [ticket/12627] Add debug.sql_explain parameter 
PHPBB3-12627
 2019-05-09 18:29:22 +02:00
luzpaz
a9a28859d4 [ticket/15424] Multiple typo fixes in docs & comments 
Fixed typos in some docs, guidelines, some non-user-facing files.

PHPBB3-15424
 2019-05-08 22:20:56 +02:00
hubaishan
dc96e70d1b [ticket/15665] fix double semicolon 
PHPBB3-15665
 2018-11-20 15:56:02 +03:00
hubaishan
717d4840e2 [ticket/15665] Fix MSSQL crashes if upload dir>2GB 
Add cast_expr_to_bigint() to mssql_base

PHPBB3-15665
 2018-11-20 13:38:15 +03:00
hubaishan
b0b70589a2 [ticket/15612] Fix PHP7.2 count() bug in MSSQL driver 
sqlsrv_fetch_array() function returns an array when data found,
null when no data or false on error. So we need to change null to false only.

PHPBB3-15612
 2018-08-25 16:17:55 +03:00
FH
4577404fc2 [ticket/15520] sql_build_query build subquery 
Fix for the building of subqueries
in sql_build_query

PHPBB3-15520
 2018-02-03 21:06:12 +01:00
Derky
182a96f273 Merge pull request #4680 from marc1706/ticket/15055 
[ticket/15055] Add appveyor file to allow running tests on appveyor as well
 2018-01-05 22:44:34 +01:00
Marc Alexander
6f6750b629 [ticket/15055] Specify utf8 as character set in sqlsrv_connect 
This is needed to be able to correctly retrieve unicode data from the db.

PHPBB3-15055
 2018-01-01 18:55:25 +01:00
rxu
f8fbe37936 [ticket/14972] replace all occurrences of sizeof() with the count() 
PHPBB3-14972
 2018-01-01 13:56:04 +01:00
rxu
8c3808e9e7 [ticket/14972] Fix sizeof calls 
As of PHP 7.2, only arrays and objects implementing the Countable interface
should be passed as a count() or sizeof() parameter.
See https://github.com/php/php-src/blob/php-7.2.0alpha2/UPGRADING#L197-L198
Also, sizeof() seems to be sheduled for deprecation, see
https://wiki.php.net/rfc/deprecations_php_7_2#suggested_deprecations

PHPBB3-14972
 2018-01-01 13:08:12 +01:00