1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-25 20:44:01 +01:00

62 Commits

Author SHA1 Message Date
Nils Adermann
0ad9833668 Merge remote-tracking branch 'github-nickvergessen/ticket/12331' into develop-ascraeus
* github-nickvergessen/ticket/12331:
  [ticket/12331] Add functional test for saving custom profile fields
  [ticket/12331] Fix SQL error when inserting a new entry to profile field data
2014-04-10 14:14:30 -07:00
Joas Schilling
11a9104b8a [ticket/12282] Use interface for type hinting
PHPBB3-12282
2014-04-01 19:17:41 +02:00
Joas Schilling
86c4d24a8a [ticket/12331] Fix SQL error when inserting a new entry to profile field data
There was a "Field 'pf_phpbb_interests' doesn't have a default value" error,
because we didn't specify values for the disabled fields.
We can not disable the sql_return_on_error() thou, because it otherwise we run
into "Duplicate entry '2' for key 'PRIMARY'" errors when the user submits the
form again but didn't change any values.

PHPBB3-12331
2014-03-30 15:59:51 +02:00
Shitiz Garg
403ab49716 [ticket/9040] Count HTML entities as single in custom profile fields
Currently when an user adds a HTML entity to a custom profile field, the length
gets incremented by 4 since the code reads &gt; instead of <. However, the
length is presentational and not DB storage so it should be treated as a
single character even if it takes four lengths in the DB by being stored as
a HTML entity.

Work around this by decoding html entities before counting. Also, added unit
tests for string field type

PHPBB3-9040
2014-03-17 17:35:30 +05:30
Joas Schilling
600e5f6c11 [ticket/12251] Add string validation for a-zA-Z0-9 and underscore
PHPBB3-12251
2014-03-06 12:28:36 +01:00
Nathan Guse
4b6f3f8b0f Merge pull request #2088 from nickvergessen/ticket/12236
Ticket/12236 Convert AOL and Yahoo to custom profile fields
2014-03-05 18:44:39 -06:00
Nathan Guse
c1ca74ee6d Merge pull request #2058 from nickvergessen/ticket/12216
[ticket/12216] Undefined index: lang_options when creating date profile field
2014-03-05 18:36:15 -06:00
Joas Schilling
e88c61f85e [ticket/12249] Fix "Undefined variable: row" when editing profile
PHPBB3-12249
2014-03-05 22:32:03 +01:00
Joas Schilling
03ef39c1f1 [ticket/12187] Do not make clickable when using as contact field
PHPBB3-12187
2014-03-04 09:10:57 +01:00
Joas Schilling
c650078904 [ticket/12187] Split generate_profile_fields_template() into 2 methods
Removing the mode switch that wraps the content of the method

PHPBB3-12187
2014-03-04 08:47:47 +01:00
Joas Schilling
a2f2629e2a [ticket/12187] Add URL type for profile fields
PHPBB3-12187
2014-03-03 12:30:07 +01:00
Joas Schilling
a823205403 [ticket/12233] Allow profile fields to be contact fields
Contact fields are displayed with in the contact section of the user profile
and are displayed differently in the mini profile next to posts and private
messages

PHPBB3-12233
2014-02-28 14:38:03 +01:00
Joas Schilling
ae98810ddc Merge remote-tracking branch 'nickvergessen/ticket/12205' into ticket/12205-develop
* nickvergessen/ticket/12205:
  [ticket/12205] Do not display 0 for empty integers when show_novalue is off

Conflicts:
	phpBB/includes/functions_profile_fields.php
2014-02-25 18:35:03 +01:00
Joas Schilling
3930978e64 [ticket/12216] Undefined index: lang_options when creating date profile field
PHPBB3-12216
2014-02-24 10:00:45 +01:00
Joas Schilling
30fbaab8de [ticket/12184] Fix undefined variable tpl_fields in profile field manager
PHPBB3-12184
2014-02-11 19:17:24 +01:00
Joas Schilling
5550f0fa87 [ticket/12169] Split mode==headline into it's own function
PHPBB3-12169
2014-02-10 19:04:10 +01:00
Joas Schilling
3c46aeb005 [ticket/12169] Allow displaying profile fields on memberlist
We can not sort by profile field values atm. And also I'm not sure
whether this is possible at all.

PHPBB3-12169
2014-02-10 15:58:55 +01:00
Joas Schilling
6bee91c429 [ticket/12169] Convert user_from to profile field location
Missing changes on memberlist view due to missing functionality

PHPBB3-12169
2014-02-10 14:38:43 +01:00
Joas Schilling
8dab016a7b [ticket/12115] Add methods to interface
PHPBB3-12115
2014-02-06 11:32:09 +01:00
Joas Schilling
f97d268a79 [ticket/12115] Translate profile field name before displaying it in errors
PHPBB3-12115
2014-02-06 11:32:08 +01:00
Marc Alexander
6f92996d98 [ticket/12159] Fix codesniffer complaints due to profilefields and passwords
The two PRs regarding profilefields and passwords manager that were recently
merged caused a few codesniffer complaints that are fixed by these changes.

PHPBB3-12159
2014-02-03 22:25:43 +01:00
Joas Schilling
cbad102f88 [ticket/11201] Split template file into multiple files
PHPBB3-11201
2014-02-02 16:20:02 +01:00
Joas Schilling
cacd43bfbd [ticket/11201] Remove dependency from types on the manager
PHPBB3-11201
2014-02-02 16:13:04 +01:00
Joas Schilling
7bcbdfc1b1 [ticket/11201] Rename profilefields class to manager
PHPBB3-11201
2014-02-02 12:53:29 +01:00
Joas Schilling
430a0c1c21 [ticket/11201] Also translate profile fields in UCP and ACP
PHPBB3-11201
2014-01-19 17:58:12 +01:00
Joas Schilling
4213b93cde [ticket/11201] Add parameters and variables to profile field class
PHPBB3-11201
2014-01-19 15:00:26 +01:00
Joas Schilling
ec8fd57f28 [ticket/11201] Add commas on last array entry
PHPBB3-11201
2014-01-19 14:55:47 +01:00
Joas Schilling
0ce98d7eac [ticket/11201] Allow translation of profile field name and explanation
PHPBB3-11201
2014-01-19 14:52:51 +01:00
Joas Schilling
f40f774b2e [ticket/11201] Fix some variable names
PHPBB3-11201
2014-01-18 13:28:17 +01:00
Joas Schilling
197e026699 [ticket/11201] Add a method to return the translated full name of the type
PHPBB3-11201
2014-01-18 13:16:18 +01:00
Joas Schilling
df85364baa [ticket/11201] Remove db depending code from field class
sql_build_array() should already take care of that

PHPBB3-11201
2014-01-18 13:01:29 +01:00
Joas Schilling
b1bed49eae [ticket/11201] Add variables to classes and add constructor doc blocks
PHPBB3-11201
2014-01-18 12:53:41 +01:00
Joas Schilling
7fac238398 [ticket/11201] Update copyright in class file
PHPBB3-11201
2014-01-18 12:47:19 +01:00
Joas Schilling
7a8818fbc6 [ticket/11201] Add visibility and remove unused variable
PHPBB3-11201
2014-01-18 12:46:48 +01:00
Joas Schilling
1c884d07eb [ticket/11201] Add some commas at the last array entry
PHPBB3-11201
2014-01-18 12:44:24 +01:00
Joas Schilling
876e5e5fbb [ticket/11201] Cast some variables to integer
PHPBB3-11201
2014-01-18 12:40:12 +01:00
Joas Schilling
431fa7b593 [ticket/11201] Inject table names rather then using constants
PHPBB3-11201
2014-01-18 12:36:18 +01:00
Joas Schilling
aa2f0a652f [ticket/11201] Change type from integer to service name
PHPBB3-11201
2014-01-17 21:13:59 +01:00
Joas Schilling
74d36591e1 [ticket/11201] Move custom template variable assignment to type class
PHPBB3-11201
2014-01-17 21:13:56 +01:00
Joas Schilling
af5c747f6f [ticket/11201] Move preparation of hidden fields to type class
PHPBB3-11201
2014-01-17 21:13:46 +01:00
Joas Schilling
67f477fc8f [ticket/11201] Allow manipulating the intended variables with the type class
PHPBB3-11201
2014-01-17 13:59:07 +01:00
Joas Schilling
ae38cfaa70 [ticket/11201] Move type specific error messages to type class
PHPBB3-11201
2014-01-17 10:20:00 +01:00
Joas Schilling
5e2ffe0d5c [ticket/11201] Add abstract base class with shared methods
PHPBB3-11201
2014-01-17 10:12:30 +01:00
Joas Schilling
9653764fb1 [ticket/11201] Move field type depending preparation of the options to class
PHPBB3-11201
2014-01-17 09:55:52 +01:00
Joas Schilling
0bdec35cd4 [ticket/11201] Move grabbing the input of the language options to type class
PHPBB3-11201
2014-01-16 16:00:52 +01:00
Joas Schilling
78603bb96d [ticket/11201] Move language option determination into type class
PHPBB3-11201
2014-01-15 18:25:28 +01:00
Joas Schilling
8e86e56120 [ticket/11201] Add database column type to type class
PHPBB3-11201
2014-01-15 16:36:50 +01:00
Joas Schilling
1dbc2d6218 [ticket/11201] Fix dropdown tests
The error message is now already the language string including the fieldname
and not the language key anymore.

PHPBB3-11201
2014-01-15 12:36:54 +01:00
Joas Schilling
7fd5f16fa2 [ticket/11201] Use a service collection for the types instead of the container
PHPBB3-11201
2014-01-15 12:16:04 +01:00
Joas Schilling
5df7f76e6b [ticket/11201] Split language options into a new class
Otherwise we run into a circular dependency

PHPBB3-11201
2014-01-15 12:15:41 +01:00