1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-06 23:55:26 +02:00

260 Commits

Author SHA1 Message Date
Meik Sievertsen
2f4a618900 ok... i hope i haven't messed too much with the code and everything is still working.
Changes:
- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.
- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid('memberlist')) - in this case the root path and extension get added automatically. The hook is called after these are added.

git-svn-id: file:///svn/phpbb/trunk@8572 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-05-29 12:25:56 +00:00
Meik Sievertsen
eb664ddafb some missing merges...
git-svn-id: file:///svn/phpbb/trunk@8545 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-05-04 14:47:49 +00:00
Meik Sievertsen
2cedbbac09 merge revisions #r8384, #r8387, #r8388, #r8389 and #r8390
git-svn-id: file:///svn/phpbb/trunk@8391 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-02-23 14:23:34 +00:00
David M
7b262babcd Alright, this should give some improved performance :)
This is the end of random seek access to rows. If you have a compelling reason as to why they should stay, contact me. Else, they are gone forevermore...

The following API calls are deprecated:
acm::sql_rowseek() -> no replacement
$db->sql_fetchfield($field, $rownum = false, $query_id = false) -> $db->sql_fetchfield($field, $query_id = false)

Initial tests show that phpBB3 over four percent of memory against phpBB3.1 on an empty board. So far so good :)

Other cool things: 
db2, MS SQL ODBC and MS SQL 2005 all use less memory because they do not need to reference the last executed query to handle random access seeks :)

P.S.
The crazy people using SVN: please report any issues with the new way we itterate through caches, I do not want to miss anything :)

git-svn-id: file:///svn/phpbb/trunk@8372 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-02-03 10:19:04 +00:00
David M
2928574ed4 - a few tiny clean ups
- a new MS SQL DBAL, it does not work so hot because of issues with the extension it depends on


git-svn-id: file:///svn/phpbb/trunk@8313 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-07 15:19:38 +00:00
David M
57645ad5bc the end of an era...
- MySQL < 4.1.3 support is removed
- renamed mysql4 to mysql, no need to cause confusion
- changed the cfg cacher, reduces file system lookups and include count by two on every page load


git-svn-id: file:///svn/phpbb/trunk@8307 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-06 02:21:44 +00:00
David M
3b29db4545 oops
git-svn-id: file:///svn/phpbb/trunk@8303 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-04 19:54:24 +00:00
David M
af738dbc2a Ch-ch-ch-changes
- Made us more DB independent by making many queries capability based instead of DB specific
- Finished PHP5ifying of the acm_file class, now with some (hopefully) enhancements to its performance
- Sped up viewforum considerably (also goes towards mcp_forum)

I really hope I didn't explode CVS...


git-svn-id: file:///svn/phpbb/trunk@8301 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-04 18:35:49 +00:00
Meik Sievertsen
9b751a330d - Re-populate arrays on cache purge/save to allow re-using some functions without warnings
- fix the annoying "last page empty" bug on inactive users page.


git-svn-id: file:///svn/phpbb/trunk@8239 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-11-17 12:14:27 +00:00
Meik Sievertsen
8c26e780e3 - fix pm not_moved/removed retrieval (it was switched)
- cache db-size retrieval (saves a lot of seconds for very large boards)


git-svn-id: file:///svn/phpbb/trunk@8231 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-11-07 10:45:38 +00:00
Meik Sievertsen
e6c79242e6 dumdidum... sorry. ;)
git-svn-id: file:///svn/phpbb/trunk@8146 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-05 14:30:11 +00:00
Meik Sievertsen
b2afdc0704 #i53
git-svn-id: file:///svn/phpbb/trunk@8113 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-09-26 16:53:40 +00:00
Meik Sievertsen
685282c2cb - some language tweaks suggested by John
- some bug fixes
- finally adding db_tools...


git-svn-id: file:///svn/phpbb/trunk@8088 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-09-13 15:01:15 +00:00
David M
3af602fca4 I take it back!
git-svn-id: file:///svn/phpbb/trunk@8081 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-09-06 03:15:06 +00:00
David M
d65ee9f71a #14370
git-svn-id: file:///svn/phpbb/trunk@8080 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-09-06 03:09:56 +00:00
Nils Adermann
d104d3d969 - BBCode parsing order should ALWAYS be censor_text(), bbcode_secon_pass(), bbcode_nl2br(), smiley_text(), parse_attachments()
- using \r on custom bbcodes to allow line breaks [Bug #10758]


git-svn-id: file:///svn/phpbb/trunk@8050 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-08-19 13:40:53 +00:00
David M
a935f6e5f9 - add database size for Firebird
git-svn-id: file:///svn/phpbb/trunk@7965 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-28 04:05:43 +00:00
Meik Sievertsen
75dc0e8637 do not output notices on viewing the log if log language variables changed their information between versions...
git-svn-id: file:///svn/phpbb/trunk@7962 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-27 18:03:55 +00:00
Meik Sievertsen
acf0c0ddeb err, forgot to commit
git-svn-id: file:///svn/phpbb/trunk@7961 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-27 17:33:27 +00:00
Meik Sievertsen
3585dbd42c a bunch of fixes
git-svn-id: file:///svn/phpbb/trunk@7884 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-14 15:44:10 +00:00
Meik Sievertsen
5aa220bcd2 tweak the sql_like_expression feature a little bit to allow correct escaping
git-svn-id: file:///svn/phpbb/trunk@7789 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-24 12:49:13 +00:00
Meik Sievertsen
318418b0f2 new wrapper for LIKE expressions to streamline the fixes. We actually need to adjust them for different DBMS as well as SQLite2 not supporting escaping characters in LIKE statements (which is a reason why we think about dropping sqlite support completely).
git-svn-id: file:///svn/phpbb/trunk@7788 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-23 12:16:20 +00:00
Henry Sudhof
1e2db705ca Fixing a few things for postgres. Thanks to wagnerch for researching the issue and providing a patch.
#12587


git-svn-id: file:///svn/phpbb/trunk@7787 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-22 16:47:23 +00:00
David M
5f62e8feda #11313
git-svn-id: file:///svn/phpbb/trunk@7775 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-18 13:08:48 +00:00
Meik Sievertsen
455536773f ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)
git-svn-id: file:///svn/phpbb/trunk@7736 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-09 11:11:20 +00:00
David M
dd9c236e6a - Oracle, woe is you... I will say this much, this fixes Oracle's handling of empty strings... We also fix custom profiles and now provide database size for Oracle...
git-svn-id: file:///svn/phpbb/trunk@7721 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-07 05:58:45 +00:00
David M
a1ae65368e we forgot to sync the forums that shadow topics reside in when the topic that they point to is deleted
git-svn-id: file:///svn/phpbb/trunk@7679 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-25 17:42:32 +00:00
Henry Sudhof
20993d5cf1 Introduced checks to stop negative postcounts (Bug #11561, #11421)
Allow IP v4/v6 urls for remote avatars (Bug #11633)
 Delete avatar files automatically (Bug #11631)
 Automatically add selected columsn to group by statements in the converter (Bug #11465)


git-svn-id: file:///svn/phpbb/trunk@7677 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-25 16:03:40 +00:00
Henry Sudhof
6b6be273c1 quieter - shouldn't make a difference, but well...
git-svn-id: file:///svn/phpbb/trunk@7648 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-19 17:45:12 +00:00
Meik Sievertsen
aa4ad4b62e Allow pre-setting language dependant data in schema_data.sql... specified with {L_*}, also create the search index on installation
git-svn-id: file:///svn/phpbb/trunk@7644 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-19 15:44:23 +00:00
David M
a1613d56c8 make the comment true
git-svn-id: file:///svn/phpbb/trunk@7599 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-16 02:30:37 +00:00
Meik Sievertsen
7e05a3024b #10942 + cron image into <p></p> tags
git-svn-id: file:///svn/phpbb/trunk@7589 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-15 15:52:37 +00:00
David M
17a6733755 #10637
git-svn-id: file:///svn/phpbb/trunk@7504 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-08 00:12:07 +00:00
Meik Sievertsen
383e27dba8 #10627 - revert previous permission inclusion change, forgot that that permissions_phpbb indeed need to be added as the first file.
git-svn-id: file:///svn/phpbb/trunk@7502 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-07 21:13:18 +00:00
Meik Sievertsen
4de7171836 Ok, try to fix the "re-approval on edit" bugs. Also added make_clickable to log entries as well as logging moderator edits.
git-svn-id: file:///svn/phpbb/trunk@7491 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-06 21:02:23 +00:00
Meik Sievertsen
6205be1e74 #9828, #10545, #10541, #10533, #10529, #10527, #10521, #10503, #10481
- more label fixes
- simpler approach to get input cursor text


git-svn-id: file:///svn/phpbb/trunk@7485 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-06 15:31:39 +00:00
David M
eee1dedc13 "These aren't the droids you're looking for."
git-svn-id: file:///svn/phpbb/trunk@7468 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-05 05:15:36 +00:00
David M
dfe674ffa1 - changed the way we do forum accounting in phpBB, far less intensive and much faster. sync() recalculates the number of topics and posts using just the topics table instead of having to join topics and posts together. However, even this can be avoided if we know what operation is happening and an auto sync is not in action. Since MCP operations are "known", we can provide very fast MCP operations.
- changed the way we decide if a DB gets multi value support. Old method uses switch/case, new method assumes a DB can't unless the DB says it can via a property

I hope nothing is broken :P


git-svn-id: file:///svn/phpbb/trunk@7466 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-05 04:53:43 +00:00
Meik Sievertsen
a465b06923 added class for disabled options in ACP
E_USER_ERROR now using language keys if available [related to #10445]
UCP/MCP title tags [#10441]
Check $start parameter in viewforum [#10435]
Check for postable forum for moving user posts within users ACP [#10433]
Show error if admin tries to put forums beneath linked forums [related to #10433]
Correctly catch attachments while moving posts [#10431]
language change in install.html [#10425]
Updated AUTHORS file


git-svn-id: file:///svn/phpbb/trunk@7456 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-04 12:30:21 +00:00
Meik Sievertsen
816bc5da61 "Ghost" topics in active topics list when shadow topics and corresponding topic in same resultset [#10313]
Find a member supporting hidden groups for those able to see them [#10305]
Display hidden groups for all those able to see them across the board (composing messages, viewonline)
Fix space for sending PM's to groups
Let the permissions_phpbb file be included the same way as all other permission files [#10301]
Add request_a-z+ handling within modules_auth suggested by Pyramide. This will allow modders to directly show/hide their module in addition to !empty() $_REQUEST variables. [#10297]


git-svn-id: file:///svn/phpbb/trunk@7433 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-04-30 13:32:18 +00:00
David M
c8f138d4bd *** empty log message ***
git-svn-id: file:///svn/phpbb/trunk@7369 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-04-17 03:22:15 +00:00
Meik Sievertsen
b63745fdb3 my take on getting the bugs down... thanks to those also providing (usable) solutions to the problem. ;) Of course also to those reporting generally...
git-svn-id: file:///svn/phpbb/trunk@7330 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-04-12 16:20:39 +00:00
David M
13e563fb44 add caching to one attachment ACP query, affix the proper TTL for a query in functions_admin
git-svn-id: file:///svn/phpbb/trunk@7327 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-04-11 20:35:11 +00:00
David M
7cbf74bfca *** empty log message ***
git-svn-id: file:///svn/phpbb/trunk@7309 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-04-09 12:57:15 +00:00
David M
4f5cf86db9 I should have sent this in a while ago O_O
git-svn-id: file:///svn/phpbb/trunk@7300 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-04-08 09:32:26 +00:00
Meik Sievertsen
1d1b5e6446 some fixes...
git-svn-id: file:///svn/phpbb/trunk@7266 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-04-02 15:47:23 +00:00
Meik Sievertsen
2e244a1eeb #5181
git-svn-id: file:///svn/phpbb/trunk@7221 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-03-23 17:59:26 +00:00
David M
0ae0d2f19c *** empty log message ***
git-svn-id: file:///svn/phpbb/trunk@7200 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-03-16 00:50:34 +00:00
Nils Adermann
73ae601158 - sync now correctly handles approved posts in unapproved topics (last_post info)
git-svn-id: file:///svn/phpbb/trunk@7191 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-03-14 21:40:52 +00:00
Meik Sievertsen
067bf38515 - fixed a bug in syncing forums/topics in ACP
- now also syncing moved topics having no information at all (this may only be triggered while converting)


git-svn-id: file:///svn/phpbb/trunk@7188 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-03-14 18:52:18 +00:00