For forums that have no approved posts but also have
topics awaiting approval, to avoid the inconsistency
of saying 'no posts' alongside a positive post count.
PHPBB3-15917
[ticket/13904] Refactor attachments functions into service
* marc1706/ticket/13904: (66 commits)
[ticket/13904] Use filespec's get_filesize instead of calling filesize()
[ticket/13904] Set properties to protected where possible in filespec
[ticket/13904] Fix tests after changes to factory
[ticket/13904] Minor coding style fixes
[ticket/13904] Add language entries for error messages in upload class
[ticket/13904] Modify files for updated fast-image-size library
[ticket/13904] Update composer.lock
[ticket/13904] Improve code coverage
[ticket/13904] Add unit tests for local upload type
[ticket/13904] Minor coding style fixes
[ticket/13904] Improve test coverage of base upload type class
[ticket/13904] Improve test coverage of remote upload type
[ticket/13904] Improve test coverage of form upload type
[ticket/13904] Improve test coverage of filespec class
[ticket/13904] Add back tests for retrieving floats
[ticket/13904] Use ini_get() wrapper in file upload types
[ticket/13904] Modify files for changes in ini wrapper
[ticket/13904] Add bantu/ini-get-wrapper to composer.json
[ticket/13904] Switch around constructor arguments
[ticket/13904] Use \phpbb\php\ini class for ini_get()
...
Currently the in-board method for the notifications is hardcoded and
cannot be disabled. This method should be in his own class extending
`phpbb\notification\method\method_interface`.
It also add the possibility, for each method, to be enabled by default (ie:
no entry in the DB => notification enabled).
https://tracker.phpbb.com/browse/PHPBB3-11444https://tracker.phpbb.com/browse/PHPBB3-11967
PHPBB3-11444
* github-marc1706/ticket/12822:
[ticket/12822] Fix test runs of avatar manager_test
[ticket/12822] Add method for deleting avatars and use confirm_box
[ticket/12822] Remove "None" option from avatar select boxes
The method will take care of the actual deletion process in the avatar manager.
Additionally, we'll be using a confirm box while deleting the avatar to prevent
users from accidentally deleting their avatars.
PHPBB3-12822
* PayBas/ticket/12662: (29 commits)
[ticket/12662] Hide quick-links when empty
[ticket/12662] Fix white-space issue to make dropdowns uniform
[ticket/12662] Remove last remaining linklist outside navbars
[ticket/12662] Use data-last-responsive attr instead of hardcoded list
[ticket/12662] Remove <li> container from logged_out_content event
[ticket/12662] Username <span> fix for list columns
[ticket/12662] Fix notifications dropdown positioning for RTL
[ticket/12662] Update tests that utilize get_username_string
[ticket/12662] Update subsilver2 index template event names
[ticket/12662] Update events docs from b5 to rc1/rc2
[ticket/12662] Move dropdown container from <li> to new inner div
[ticket/12662] Remove linklist container and update template events
[ticket/12662] Add span containers to all usernames for consistency
[ticket/12662] IE8 fixes
[ticket/12662] Fix responsive positioning of notifications dropdown
[ticket/12662] Remove inherited props from ddown-extendended
[ticket/12662] Change CSS selectors to direct descendants for linklist
[ticket/12662] Reorder icon CSS rules alphabetically
[ticket/12662] Use slack variable to determine line-break sensitivity
[ticket/12662] Change new event names and fix events.md
...