mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-01-19 15:17:16 +01:00
Code Issues Releases Wiki Activity
16,420 Commits 17 Branches 190 Tags
Commit Graph

16420 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andreas Fischer
6f946e2188 [ticket/11469] Refactor get_three_rows() into get_rows($n). 
PHPBB3-11469
 2013-03-28 00:28:51 +01:00
Andreas Fischer
eacd0f3e7d [ticket/11469] Fix spacing in getDataSet(). 
PHPBB3-11469
 2013-03-28 00:28:51 +01:00
Andreas Fischer
c909d9602b [ticket/11469] Do not repeat assert_config_count(2). Also move to setUp(). 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
b48c4d9549 [ticket/11469] Use setUp() to setup DB and a buffer with size 2. 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
1bd13acb75 [ticket/11469] Use multi insert property from DB. Do not copy value to buffer. 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
4132573088 [ticket/11469] Use buffer with a single element instead of extra code path. 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
b88eb3c8e0 [ticket/11469] Do not repeat row generation. 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
873f098b6c [ticket/11469] Do not repeat array with three rows. 
PHPBB3-11469
 2013-03-28 00:28:46 +01:00
Andreas Fischer
a534497d82 [ticket/11469] Move protected method to end of test file. 
PHPBB3-11469
 2013-03-28 00:22:07 +01:00
Andreas Fischer
edd4987030 Merge remote-tracking branch 'nickvergessen/ticket/bantu/11469-2' into ticket/11469 
* nickvergessen/ticket/bantu/11469-2:
  [ticket/11469] Cast $result to boolean in insert_all()
  [ticket/11469] Check return values of the functions
  [ticket/11469] Split tests and skip multi_insert if unavailable
 2013-03-27 23:14:38 +01:00
Joas Schilling
c9f059c4f2 [ticket/11469] Cast $result to boolean in insert_all() 
|= returns integer values

PHPBB3-11469
 2013-03-27 20:55:48 +01:00
Joas Schilling
69ad4aab78 [ticket/11469] Check return values of the functions 
PHPBB3-11469
 2013-03-27 20:55:08 +01:00
Joas Schilling
9606ccc202 [ticket/11469] Split tests and skip multi_insert if unavailable 
PHPBB3-11469
 2013-03-27 20:54:20 +01:00
Andreas Fischer
53f9e2131c [ticket/11469] Add note about calling flush() after batch insert is done. 
PHPBB3-11469
 2013-03-27 19:27:27 +01:00
Andreas Fischer
dc766f29b4 [ticket/11469] Have all methods of phpbb_db_sql_insert_buffer provide feedback. 
PHPBB3-11469
 2013-03-27 19:19:26 +01:00
Andreas Fischer
8c5fcac232 [ticket/11469] Add benefits over collecting huge insert arrays to class doc. 
PHPBB3-11469
 2013-03-27 18:22:59 +01:00
Andreas Fischer
55fb87ff18 Merge remote-tracking branch 'nickvergessen/ticket/bantu/11469' into ticket/11469 
* nickvergessen/ticket/bantu/11469:
  [ticket/11469] Use method to check config count, instead of repeating it
  [ticket/11469] Return after sql_multi_insert when multi_insert is false
  [ticket/11469] Add some basic unit tests for phpbb_db_sql_insert_buffer
 2013-03-27 18:11:49 +01:00
Andreas Fischer
43b6ae3fee Merge remote-tracking branch 'phpbb/develop' into ticket/11469 
* phpbb/develop:
  [ticket/11476] Remove pass-by-reference from sql_mutli_insert
  [ticket/11466] Remove old database driver files from PHPUnit exclude
  [ticket/11448] Use of $user_id parameter to mark a user's notifications read
  [ticket/11460] Add default behaviour tests for notification and email types.
  [ticket/11460] Configure functional test board email using dummy SMTP data.
  [ticket/11460] Add test for whether post_email and topic_email are checked.
  [ticket/11460] Add methods for checkbox handling to phpbb_functional_test_case.
  [ticket/11460] Drop incorrect phpbb_notification_{type,method}_ prefix.
 2013-03-27 18:11:38 +01:00
Andreas Fischer
94a15f85a6 [ticket/11469] Add example code to class documentation. 
PHPBB3-11469
 2013-03-27 18:11:31 +01:00
Andreas Fischer
b583f6d8d9 Merge remote-tracking branch 'nickvergessen/ticket/11476' into develop 
* nickvergessen/ticket/11476:
  [ticket/11476] Remove pass-by-reference from sql_mutli_insert
 2013-03-27 17:55:42 +01:00
Joas Schilling
c629b2c7b3 [ticket/11476] Remove pass-by-reference from sql_mutli_insert 
The method never writes to the array passed by reference. So it can be
passed by value instead to avoid certain problems.

PHPBB3-11476
 2013-03-27 15:01:36 +01:00
Joas Schilling
af9f30cd52 [ticket/11469] Use method to check config count, instead of repeating it 
PHPBB3-11469
 2013-03-27 14:09:04 +01:00
Joas Schilling
bf6f2c5875 [ticket/11469] Return after sql_multi_insert when multi_insert is false 
PHPBB3-11469
 2013-03-27 14:00:47 +01:00
Joas Schilling
8dd26dee83 [ticket/11469] Add some basic unit tests for phpbb_db_sql_insert_buffer 
PHPBB3-11469
 2013-03-27 14:00:46 +01:00
Joas Schilling
bdd2062a66 [ticket/11474] Add test user with only global m_approve permissions 
PHPBB3-11405
PHPBB3-11474
 2013-03-27 11:12:33 +01:00
Nils Adermann
b7778f7fde Merge remote-tracking branch 'github-bantu/ticket/11460' into develop 
* github-bantu/ticket/11460:
  [ticket/11460] Add default behaviour tests for notification and email types.
  [ticket/11460] Configure functional test board email using dummy SMTP data.
  [ticket/11460] Add test for whether post_email and topic_email are checked.
  [ticket/11460] Add methods for checkbox handling to phpbb_functional_test_case.
  [ticket/11460] Drop incorrect phpbb_notification_{type,method}_ prefix.
 2013-03-27 06:31:53 +01:00
Nils Adermann
c9aa39be5d Merge pull request #1318 from imkingdavid/ticket/11448 
[ticket/11448] Use of $user_id parameter to mark a user's notifications read
 2013-03-26 15:19:28 -07:00
Nils Adermann
59e0196846 Merge pull request #1319 from imkingdavid/ticket/11466 
[ticket/11466] Remove old database driver files from PHPUnit exclude
 2013-03-26 15:16:43 -07:00
David King
6ab9ef54a2 [ticket/11466] Remove old database driver files from PHPUnit exclude 
As per the ticket comments, these can simply be removed, rather than having to
be renamed to the new file locations.

PHPBB3-11466
 2013-03-26 17:21:35 -04:00
David King
6dddc22ec7 [ticket/11448] Use of $user_id parameter to mark a user's notifications read 
Currently, the $user_id is a parameter but is not used. This patch fixes that.

PHPBB3-11448
 2013-03-26 17:07:20 -04:00
Joas Schilling
d8a63047aa [ticket/11474] Clarify comment with "global" and forum_id = 0 
Forum ID 0 in permission checks, checks the global moderator permission.

PHPBB3-11405
PHPBB3-11474
 2013-03-26 20:20:51 +01:00
Joas Schilling
1af89968dd [ticket/11474] Check read permission before sending *_in_queue notifications 
PHPBB3-11405
PHPBB3-11474
 2013-03-26 20:20:26 +01:00
Joas Schilling
8a94e08e30 [ticket/11405] Add unit tests for post_in_queue 
PHPBB3-11405
 2013-03-26 20:17:26 +01:00
Joas Schilling
0f204595d9 [ticket/11405] Fix "only variables should be passed by reference" 
PHPBB3-11405
 2013-03-26 20:17:24 +01:00
Joas Schilling
81cf02e057 [ticket/11405] Order users in bookmark, in order to pass postgres tests 
PHPBB3-11405
 2013-03-26 13:54:33 +01:00
Marc Alexander
34cdbd0360 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11314 
Conflicts:
	phpBB/styles/prosilver/template/timezone.js
 2013-03-26 13:18:54 +01:00
Marc Alexander
f0b0978538 [ticket/11314] Modify files to comply with coding standards 
PHPBB3-11314
 2013-03-26 13:13:33 +01:00
Joas Schilling
e20b0a4234 [ticket/11405] Use different fixtures so it's not a total mess 
PHPBB3-11405
 2013-03-26 13:06:04 +01:00
Joas Schilling
7e2f80ec0a [ticket/11405] Add unit tests for bookmarking 
PHPBB3-11405
 2013-03-26 12:59:35 +01:00
Joas Schilling
cdd45cb8ba [ticket/11405] Move test to submit_post_base.php and use data sets for testing 
PHPBB3-11405
 2013-03-26 12:58:14 +01:00
Marc Alexander
4870387f3a [ticket/11314] Fix JSHint issues in adm editor.js 
This time without changing the behavior.

PHPBB3-11314
 2013-03-26 11:19:03 +01:00
Marc Alexander
36168b311e [ticket/11314] Fix issues mentioned in jshint report 
Additionally, the editor.js files are now the same file in both
subsilver2, prosilver, and the acp.

PHPBB3-11314
 2013-03-26 10:31:28 +01:00
Andreas Fischer
fc8bf3f3c7 [ticket/11469] Add comment about using sql_multi_insert when not buffering. 
PHPBB3-11469
 2013-03-25 17:01:44 +01:00
Joas Schilling
053c75543d [ticket/11405] Correctly prefill the tables (missed the posts and not-types) 
PHPBB3-11405
 2013-03-25 15:34:18 +01:00
Joas Schilling
060876e627 [ticket/11405] Add a base class to avoid duplicated setUp() code 
PHPBB3-11405
 2013-03-25 15:16:29 +01:00
Joas Schilling
1259117d21 [ticket/11405] Sort $users array in order to prevent issues on postgres 
PHPBB3-11405
 2013-03-25 15:07:06 +01:00
Joas Schilling
499eded880 [ticket/11405] Add unit tests for quoted users notifications 
PHPBB3-11405
 2013-03-25 15:07:05 +01:00
Joas Schilling
7d5949ae3d [ticket/11405] Fix some coding style issues 
PHPBB3-11405
 2013-03-25 14:37:22 +01:00
Joas Schilling
a91ffe06c7 [ticket/11405] Send post notifications to forum subscribers 
Like in 3.0 we should also send notifications about new posts to users
that subscribed to the forum. (Subscriptions are verbose)

PHPBB3-11405
 2013-03-25 09:28:53 +01:00
Andreas Fischer
d3decaeedf [ticket/11460] Add default behaviour tests for notification and email types. 
PHPBB3-11460
 2013-03-24 23:42:13 +01:00