1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-25 12:33:29 +01:00

5870 Commits

Author SHA1 Message Date
Drae
cf4d6e926d [feature/pagination-as-list] Rename and deprecate functions
Returned and marked deprecated topic_generate_pagination. Rename
new function in line with coding guidelines.

PHPBB3-10968
2012-07-18 14:31:50 +01:00
Drae
dc71c0629e [feature/pagination-as-list] Various fixes and improvements
Extracted common template code for prosilver as per subsilver2.
Various other fixups and oversight corrections, changed name
of the "new" template function and re-introduced existing
version. Altered on_page to compensate for removal of some
templating vars from pagination routine.

PHPBB3-10968
2012-07-18 14:31:21 +01:00
Drae
922147f05a [ticket/10968] Render pagination within the template
Since phpBB 2 pagination has been rendered mostly within the source. This
limits just what designers can do with pagination. The current form is also
questionable in terms of "best practice". The aim is to move rendering
completely to the template via the use of a block element. Enabling S_
template vars also allows for control over specific aspects of the
pagination output such as next, previous, active and ellipsis.

Related to this - merging the capabilities of the topic_generate_pagination
with generate_pagination removes an element of duplication.

PHPBB3-10968
2012-07-18 14:30:20 +01:00
Joas Schilling
515e1662a9 [feature/new-tz-handling] Remove "timezone might be numeric"
As we updated all of the used values, there really shouldn't be one anymore.

PHPBB3-9558
2012-07-18 15:01:29 +02:00
Joas Schilling
f4136eacdc Merge branch 'develop' of git://github.com/phpbb/phpbb3 into feature/new-tz-handling 2012-07-18 11:07:32 +02:00
Nils Adermann
2090ecfb8f Merge remote-tracking branch 'github-bantu/ticket/10969' into develop
* github-bantu/ticket/10969:
  [ticket/10969] Also remove COMMENTS key from data array in get_available_dbms()
  [ticket/10969] Remove remove_remarks(&$sql) and remove_comments(&$output).
2012-07-17 20:58:50 +02:00
Andreas Fischer
a4e699db49 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10995] Return false in mssqlnative sql_fetchrow on empty result
2012-07-17 20:56:48 +02:00
Patrick Webster
ae07e80a65 [ticket/10995] Return false in mssqlnative sql_fetchrow on empty result
PHPBB3-10995
2012-07-17 20:53:29 +02:00
Nils Adermann
fb34a7aa64 Merge remote-tracking branch 'github-exreaction/ticket/7598' into develop
* github-exreaction/ticket/7598:
  [ticket/7598] Use $user->lang['COMMA_SEPARATOR']
  [ticket/7598] Inactive users action notification (ACP)
2012-07-17 20:32:07 +02:00
Fyorl
e71474abb5 [ticket/10944] strpos now stricter and removed superfluous ternary
PHPBB3-10944
2012-07-17 17:39:19 +01:00
Fyorl
6aea4db6c7 [ticket/10944] Reverted changes in PHPBB3-10963
is_image now just checks the mimetype reported by the browser
and get_mimetype goes back to being unused.

PHPBB3-10944
2012-07-17 17:39:00 +01:00
Andreas Fischer
6980b3dcfd Merge remote-tracking branch 'nickvergessen/ticket/10942' into develop
* nickvergessen/ticket/10942:
  [ticket/10942] Avoid possible conflicts with magic words in unit tests
  [ticket/10942] Add access modifiers
  [ticket/10942] Use ANSI SQL standard || in dbal.php
  [ticket/10942] Fix up unit tests for sql_case()
  [ticket/10942] Require same data type and do not cast expressions automatically
  [ticket/10942] Make unit tests for sql_case simpler
  [ticket/10942] Add a comment why we cast to sql_case()
  [ticket/10942] Rename method sql_conditional() to sql_case()
  [ticket/10942] Change term string to expression to avoid confusion
  [ticket/10942] Fix sql_conditional for mssql, postgre and oracle
  [ticket/10942] Fix function name on order_lower_test.php
  [ticket/10942] Add unit tests for sql_concatenate
  [ticket/10942] Add sql_concatenate to dbal
  [ticket/10942] Add unit tests for sql_conditional
  [ticket/10942] Add sql_conditional to dbal
2012-07-17 17:59:56 +02:00
Joas Schilling
3637cd395e [feature/new-tz-handling] Properly name new timezone selection function
Marked the old one as deprecated and made it using the new function.

PHPBB3-9558
2012-07-17 16:09:05 +02:00
Joas Schilling
48d3c68290 [feature/new-tz-handling] Use tmp variable for user timezone
PHPBB3-9558
2012-07-16 18:44:13 +02:00
Joas Schilling
b61ac43abe [feature/new-tz-handling] Allow phpbb prefix for user data validation functions
PHPBB3-9558
2012-07-16 18:41:30 +02:00
Joas Schilling
f5bb145040 [feature/new-tz-handling] Require user argument on phpbb_datetime
PHPBB3-9558
2012-07-16 18:29:31 +02:00
Nathan
97350944e3 [ticket/7598] Use $user->lang['COMMA_SEPARATOR']
PHPBB3-7598
2012-07-14 17:40:37 -05:00
Nathan
f3e6547acf [ticket/7598] Inactive users action notification (ACP)
When performing an action on users in the ACP Inactive Users, such as activating, deleting, or reminding, trigger_error is now called to give a notification that the action was performed

PHPBB3-7598
2012-07-13 22:18:28 -05:00
Andreas Fischer
8c733b3cd2 [ticket/10969] Also remove COMMENTS key from data array in get_available_dbms()
PHPBB3-10969
2012-07-08 21:42:30 +02:00
Andreas Fischer
cb245b1faf [ticket/10969] Remove remove_remarks(&$sql) and remove_comments(&$output).
Merge their bodies into phpbb_remove_comments($input).

PHPBB3-10969
2012-07-08 21:38:53 +02:00
Oleg Pudeyev
b6a364b706 Merge PR #856 branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10937] Update documentation to say which comment styles are removed.
  [ticket/10937] Comment removal functions: Restore backward compatibility
2012-07-07 16:43:30 -04:00
Oleg Pudeyev
a7da376004 Merge PR #856 branch 'prep-release-3.0.11' into develop-olympus
* prep-release-3.0.11:
  [ticket/10937] Update documentation to say which comment styles are removed.
  [ticket/10937] Comment removal functions: Restore backward compatibility
2012-07-07 16:43:28 -04:00
Oleg Pudeyev
36a568fd56 Merge PR #856 branch 'bantu/ticket/10937' into prep-release-3.0.11
* bantu/ticket/10937:
  [ticket/10937] Update documentation to say which comment styles are removed.
  [ticket/10937] Comment removal functions: Restore backward compatibility
2012-07-07 16:43:24 -04:00
Oleg Pudeyev
1526886e3e Merge PR #832 branch 'dhruvgoel92/feature/postgresql-fulltext-search' into develop
* dhruvgoel92/feature/postgresql-fulltext-search: (28 commits)
  [feature/postgresql-fulltext-search] supports_phrase_search function
  [feature/postgresql-fulltext-search] use proper variable name
  [feature/postgresql-fulltext-search] each config is checked if it is set
  [feature/postgresql-fulltext-search] fix formatting
  [feature/postgresql-fulltext-search] add docblocks to functions
  [feature/postgresql-fulltext-search] remove phrase search code
  [feature/postgresql-fulltext-search] define access control specifiers
  [feature/postgresql-fulltext-search] use version_compare
  [feature/postgresql-fulltext-search] fix language key
  [feature/postgresql-fulltext-search] remove Readme
  [feature/postgresql-fulltext-search] removes pcre check
  [feature/postgresql-fulltext-search] fix language tsearch2 to text search
  [feature/postgresql-fulltext-search] remove mbstring support
  [feature/postgresql-fulltext-search] change language for pgsql < 8.3
  [feature/postgresql-fulltext-search] use phpbb_pcre_utf8_support()
  [feature/postgresql-fulltext-search] fix variable name
  [feature/postgresql-fulltext-search] Fix version comparison for 9.0+.
  [feature/postgresql-fulltext-search] fixing license
  [feature/postgresql-fulltext-search] assign empty stats
  [feature/postgresql-fulltext-search] remove backward compatibility
  ...
2012-07-07 16:19:53 -04:00
Dhruv Goel
70a0caee28 [feature/postgresql-fulltext-search] supports_phrase_search function
function to return the value of the the private property phrase_search

PHPBB3-9730
2012-07-08 01:38:53 +05:30
Dhruv Goel
bc699f66cf [feature/postgresql-fulltext-search] fix formatting
adds proper spaces after control keywords and comment symbol

PHPBB3-9730
2012-07-05 21:17:26 +05:30
Dhruv Goel
dfbd32ce24 [feature/postgresql-fulltext-search] add docblocks to functions
Docblocks are added to the functions of this search backend.

PHPBB3-9730
2012-07-05 21:17:25 +05:30
Dhruv Goel
19d76f76dc [feature/postgresql-fulltext-search] remove phrase search code
Unused Code for phrase search removed as pgsql doesnt support it. An added
message is displayed if user tries to perform exact phrase search.

PHPBB3-9730
2012-07-05 21:17:23 +05:30
Dhruv Goel
f2dfaa73ff [feature/postgresql-fulltext-search] define access control specifiers
PHPBB3-9730
2012-07-05 21:17:22 +05:30
Dhruv Goel
ebc4c20199 [feature/postgresql-fulltext-search] use version_compare
version_compare is used for version comparision and pgsql version is now
a global variable that is displayed in the acp too.

PHPBB3-9730
2012-07-05 21:17:20 +05:30
Dhruv Goel
8ba510a99d [feature/postgresql-fulltext-search] fix language key
Language key name not incompatible_database instead of version which
was misleading

PHPBB3-9730
2012-07-05 21:17:19 +05:30
Dhruv Goel
8e035f9141 [feature/postgresql-fulltext-search] removes pcre check
PCRE UTF8 support is already checked globally. adds an option of
pgsql version to acp.

PHPBB3-9730
2012-07-05 21:17:16 +05:30
Dhruv Goel
84054afc9d [feature/postgresql-fulltext-search] remove mbstring support
Remove the usage of mbstring regex engine when PCRE does not support UTF8
since its a requirement for phpbb 3.1

PHPBB3-9730
2012-07-05 21:13:40 +05:30
Dhruv Goel
8981399ae1 [feature/postgresql-fulltext-search] change language for pgsql < 8.3
PHPBB3-9730
2012-07-05 21:13:38 +05:30
Dhruv Goel
8c170eb6a0 [feature/postgresql-fulltext-search] use phpbb_pcre_utf8_support()
Use phpBB's built in function for checking PCRE lib support.

PHPBB3-9730
2012-07-05 21:13:36 +05:30
Dhruv Goel
6958e8b6d9 [feature/postgresql-fulltext-search] fix variable name
Variable name used is now tsearch_usable instead of tsearch_builtin
to reflect its actual purpose.

PHPBB3-9730
2012-07-05 21:13:35 +05:30
Oleg Pudeyev
d9fd8da37e [feature/postgresql-fulltext-search] Fix version comparison for 9.0+.
PHPBB3-9730
2012-07-05 21:13:33 +05:30
Dhruv Goel
26bfeb0016 [feature/postgresql-fulltext-search] fixing license
PHPBB3-9730
2012-07-05 21:13:32 +05:30
Dhruv Goel
30508b406b [feature/postgresql-fulltext-search] assign empty stats
Blank array is assigned to stats incase pgsql fulltext
search backend is not compatible

PHPBB3-9730
2012-07-05 21:11:28 +05:30
Dhruv Goel
d1a49e01ce [feature/postgresql-fulltext-search] remove backward compatibility
removes backward compatibility before PostgreSQL ver 8.3
if version is before 8.3 displays error.

PHPBB3-9730
2012-07-05 21:11:26 +05:30
Dhruv Goel
f83da6c0ef [feature/postgresql-fulltext-search] minor changes
Changes to comply with other backend conventions. include $user as global
variable to access it inside init();

PHPBB3-9730
2012-07-05 21:11:23 +05:30
Dhruv Goel
9f4219b1c7 [feature/postgresql-fulltext-search] minor changes
Some changes in code to get it work against current develop.
PosgreSQL Fulltext search works for new install now.

PHPBB3-9730
2012-07-05 21:11:20 +05:30
Oleg Pudeyev
98bc7fa6ce [feature/postgresql-fulltext-search] Fixed braces
Fixes braces in fulltext_postgres.php to comply with phpbb conventions.

PHPBB3-9730
2012-07-05 21:10:50 +05:30
Oleg Pudeyev
b1378f20af [feature/postgresql-fulltext-search] Remove closing php tag
PHPBB3-9730
2012-07-05 21:09:54 +05:30
Oleg Pudeyev
d9fd0cce0a Merge PR #759 branch 'nickvergessen/ticket/10811' into develop
* nickvergessen/ticket/10811:
  [ticket/10811] Make toogle_subscribe more generic so it can toogle all links
  [ticket/10811] Make it easier for MODs/Extensions to define the alt-text
  [ticket/10811] Make subscribe/unsubscribe repeatable with AJAX
  [ticket/10811] Fix AJAX callback alt_text so it can be repeated.
2012-07-05 10:44:48 -04:00
Andreas Fischer
c54d74ec0e Merge remote-tracking branch 'Fyorl/ticket/10963' into develop
* Fyorl/ticket/10963:
  [ticket/10963] filespec::get_mimetype now used
  [ticket/10963] Removed superfluous ternary statement and strpos now stricter
  [ticket/10963] Modified filespec::is_image() to check actual mimetype
2012-07-05 02:00:31 +02:00
Joas Schilling
f1056a9b2f [ticket/10811] Make toogle_subscribe more generic so it can toogle all links
PHPBB3-10811
2012-07-05 01:03:19 +02:00
Fyorl
4fbcf4eaad [ticket/10963] filespec::get_mimetype now used
filespec::get_mimetype now uses the finfo class in order to detect the
mimetype of a given filename. filespec::is_image() now uses this method.

PHPBB3-10963
2012-07-04 13:27:55 +01:00
Joas Schilling
6776feb0de [ticket/10942] Add access modifiers
PHPBB3-10942
2012-07-04 14:05:03 +02:00
Andreas Fischer
2c12f31cdf [ticket/10937] Update documentation to say which comment styles are removed.
PHPBB3-10937
2012-07-03 01:02:42 +02:00