mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-25 20:44:01 +01:00
Code Issues Releases Wiki Activity
14,615 Commits 17 Branches 190 Tags
Commit Graph

115 Commits

Author SHA1 Message Date
Nathan Guse
4ed9e4124e [feature/template-events] Wording: wrongly -> improperly. 
PHPBB3-9550
 2012-11-17 16:40:00 -05:00
Nathan Guse
2fb4006056 [feature/template-events] Indentation fix. 
PHPBB3-9550
 2012-11-17 16:40:00 -05:00
Oleg Pudeyev
9c31a0ffc7 [feature/template-events] Rename template_name to style_name. 
"Style name" makes a lot more sense and should be in line with
recent style/template changes.

PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
09b4cf2f4c [feature/template-events] Report when templates cannot be compiled. 
PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
4b28b413f2 [feature/template-events] Update EVENT tag documentation. 
It should now fairly closely reflect what actually happens.

PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
faf96a1b40 [feature/template-events] Delete old comments/test code. 
PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
bd63b17d00 [feature/template-events] Move comment to the function docblock. 
PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
1b36fc3a60 [feature/template-events] Handle user access correctly. 
Pass through $user from template to filter.

Allow $user to be null for standalone usage of the template engine.

PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
45a1219886 [feature/template-events] Always commit suicide for invalid event names. 
Note: suicide happens for syntactically invalid event names,
e.g. event names containing punctuation.

Event names for which there are no events are silently dropped.

PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Oleg Pudeyev
f46f48a2cf [feature/template-events] Chase template/style renames and changes. 
PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
7bd5f7641f [feature/template-events] Fix typo (waring -> warning) 
PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
2add66c0eb [feature/template-events] Add additional space for editors 
Use `' ?'. '>'` rather than `' ?>'` as the latter causes problems
in some editors.

PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
6fc0c889fd [feature/template-events] Remove comment 
Remove comment per Nils in the PR.

PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
132bbede2b [feature/template-events] Handle incorrect template event identifiers 
If the template event identifier is wrongly formatted phpBB will
triggern an `E_USER_NOTICE` if the `DEBUG` constant is set, otherwise
the location is ignored.

PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
f836277638 [feature/template-events] RUNHOOKS -> EVENT 
PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Nathan Guse
04f55ba306 [feature/template-events] Correct indentation 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Michael Cullum
8d58e69ed3 [feature/template-events] Rename RUNHOOKS to EVENT 
Rename the way to add template events

PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
ecdb54fc04 [feature/template-events] PHP does not parse <?php?>, avoid generating it. 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
bdbb382a26 [feature/template-events] Invoke template hooks that are template-specific. 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
a6c7fbc59d [feature/template-events] Pass top-level template name to template filter. 
This will be used to invoke template-specific hooks.

PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
dd7c5183fb [feature/template-events] Add template_compile to template filter params. 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
ea094dd91a [feature/template-events] Rename universal to all (for template fragments). 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
b6f6add9d4 [feature/template-events] Fix property name for extension manager. 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
66232031e4 [feature/template-events] Really basic template hook implementation. 
PHPBB3-9550
 2012-11-17 16:39:56 -05:00
Oleg Pudeyev
09aae1ea30 [feature/template-events] Inject template compile into template filter. 
This is needed for hooks in order for the filter to compile
template files from extensions.

PHPBB3-9550
 2012-11-17 16:39:56 -05:00
Oleg Pudeyev
d6c881d0c6 [feature/template-events] Inject extension manager into template class. 
Template class passes extension manager to template compiler.

Template compiler passes extension manager to template filter.

Template filter will use extension manager to locate hooks
as it is compiling templates.

All extension manager arguments are optional. If an extension
manager is not given, template hooks will not be invoked.

PHPBB3-9550
 2012-11-17 16:39:54 -05:00
Oleg Pudeyev
ed548ae8ff [feature/template-events] Outline for RUNHOOKS template tag. 
Ported to the new develop, hopefully this is still sensible.

PHPBB3-9550
 2012-11-17 16:38:25 -05:00
Igor Wiedler
b5e069f879 Merge remote-tracking branch 'p/ticket/10933' into develop 
* p/ticket/10933:
  [ticket/10933] Prose for get_first_file_location.
  [ticket/10933] Remaining documentation for added functions in resource locator
  [ticket/10933] Update template locator test to use style resource locator.
  [ticket/10933] Dispose of locate function in template class.
  [ticket/10933] Add mutators for template_path to style resource locator.
  [ticket/10933] Delete template_path assignment.
  [ticket/10933] Delete template_path from template class.
  [ticket/10933] Add get_first_template_location.
 2012-11-17 19:49:03 +01:00
Andreas Fischer
847feb07e7 Merge remote-tracking branch 'EXreaction/ticket/11189' into develop 
* EXreaction/ticket/11189:
  [ticket/11189] Replace DEBUG_EXTRA with DEBUG
  [ticket/11189] Always log critical errors when in cron or in image output
 2012-11-10 23:39:00 +01:00
Nathaniel Guse
bd37f7f6c0 [ticket/11189] Replace DEBUG_EXTRA with DEBUG 
PHPBB3-11189
 2012-11-10 10:45:02 -06:00
Nils Adermann
f0cfae1f01 Merge pull request #881 from Fyorl/ticket/10970 
Allow INCLUDE template macros to accept paths of the form {FOO}/a/{BAR}/c
 2012-11-10 07:46:50 -08:00
Fyorl
a05f354fdf [ticket/10970] Added extra documentation to parse_dynamic_path. 
PHPBB3-10970
 2012-11-10 09:36:02 +00:00
Oleg Pudeyev
7fdab9c5d7 [ticket/10933] Prose for get_first_file_location. 
Also rewrite get_first_template_location prose a little to be
less repetitive with get_first_file_location.

PHPBB3-10933
 2012-11-02 19:45:02 -04:00
Oleg Pudeyev
0dd981071b [ticket/10933] Dispose of locate function in template class. 
It had no callers other than the test suite.

PHPBB3-10933
 2012-11-02 19:39:07 -04:00
Oleg Pudeyev
97e53103c3 [ticket/10933] Delete template_path from template class. 
template_path is now only present in style resource locator.

PHPBB3-10933
 2012-11-02 19:37:52 -04:00
Oleg Pudeyev
615d5ef628 [ticket/10933] Add get_first_template_location. 
This localizes template_path to style resource locator.

locate function on template will be removed in a subsequent commit.

PHPBB3-10933
 2012-11-02 19:37:52 -04:00
Oleg Pudeyev
767d09227b [ticket/10933] Dependency inject template context. 
PHPBB3-10933
 2012-11-02 18:51:35 -04:00
Oleg Pudeyev
766353fe5c [ticket/10933] Useful documentation for template locate function 
PHPBB3-10933
 2012-11-02 18:03:52 -04:00
Oleg Pudeyev
0c18f92c0a [ticket/10933] Typo fixes 
PHPBB3-10933
 2012-11-02 18:03:52 -04:00
Oleg Pudeyev
8528d8ff34 [ticket/10933] Initialize template context when template is constructed. 
There is no apparent reason for either initializing or clearing
the context in set_style/set_custom_style.

Initially the initialization there was added in
0501640d5db158a010741e27803191ab469834c4, for reasons that
presently I do not see.

This permits making context property back private.

PHPBB3-10933
 2012-11-02 18:03:52 -04:00
David King
8a91598b14 Merge remote-tracking branch 'nickvergessen/ticket/10876' into develop 2012-09-08 15:58:25 -04:00
Joas Schilling
c20179db72 [ticket/10876] Update regex to a version which still matches our tests 
PHPBB3-10876
 2012-08-21 11:41:27 +02:00
Fyorl
e9bdca7a8b [ticket/10970] Added newline in docblock 
PHPBB3-10970
 2012-08-19 17:12:08 +08:00
Fyorl
02ccf392fa [ticket/10970] Removed unused $vars 
PHPBB3-10970
 2012-08-10 13:42:38 +01:00
Joas Schilling
86433b5d3b [ticket/10876] Revert "add newline after php tag"-regex back to 3.0 version 
The old regex just results in some additional new lines in the output.
So this is only beautifying and considered unworthy in respect to the dying
php servers we observed on windows.

PHPBB3-10876
 2012-08-05 00:42:14 +02:00
Andreas Fischer
ae612de663 [ticket/11043] Allow call_hook() to be called from more than one location. 
Allow the helper function call_hook() of class phpbb_template to be called
from more than once location and thus for more than one hook (although there is
only one) by adding the method name as a parameter.

PHPBB3-11043
 2012-08-03 05:56:49 -05:00
Fyorl
003220dc7c [ticket/10970] Fixed a problem with prepending root paths 
PHPBB3-10970
 2012-07-24 11:55:38 +01:00
Fyorl
47c67b6d02 [ticket/10970] Added missing initialisations and modified the regex 
Non-existent variables now become empty strings.

PHPBB3-10970
 2012-07-24 11:54:46 +01:00
Igor Wiedler
85bcdbad46 [ticket/11012] Normalize $phpEx member vars to $php_ext 
PHPBB3-11012
 2012-07-21 16:19:01 +02:00
Fyorl
d0cb5bb093 [ticket/10970] Added support for forms such as {FOO}bar.{EXT} 
PHPBB3-10970
 2012-07-08 20:41:22 +01:00