1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 20:13:22 +01:00

18986 Commits

Author SHA1 Message Date
Shitiz Garg
570acb7ccc [ticket/12772] Remove config_text parameter from message.form.topic
Broke Email topic since the topic_form class doesn't require this to be passed

PHPBB3-12772
2014-06-26 16:44:40 +05:30
Andreas Fischer
afe9d3c3f3 Merge pull request #2630 from Nicofuma/ticket/12723
[ticket/12723] Add Sniff ensuring PHP files use the correct file header

* Nicofuma/ticket/12723:
  [ticket/12723] Do not mention too many details on documentation.
  [ticket/12723] Do not reference the coding guidelines section.
  [ticket/12757] Add a Code Sniffer ruleset for PHP files of phpBB extensions
  [ticket/12723] Properly describe new Code Sniffer rulsets.
  [ticket/12723] Use core suffix in filename instead of phpbb in the middle.
  [ticket/12723] Add Sniff ensuring PHP files use the correct file header
2014-06-22 11:35:13 +02:00
Tristan Darricau
32a2c95f90 [ticket/12723] Add Sniff ensuring PHP files use the correct file header
PHPBB3-12723
2014-06-22 00:45:34 +02:00
Tristan Darricau
89a7a55190 [ticket/12756] Fix mysqli_fetch_assoc on hhvm
PHPBB3-12756
2014-06-21 16:50:17 +02:00
Joas Schilling
18bf45ab1b Merge pull request #2628 from Dragooon/ticket/12731
[ticket/12731] Add YouTube custom profile field

* Dragooon/ticket/12731:
  [ticket/12731] Add functional test for youtube field
  [ticket/12731] Set field_active to 1 for YouTube field
  [ticket/12731] Add YouTube custom profile field

Conflicts:
	phpBB/install/schemas/schema.json
	phpBB/install/schemas/schema_data.sql
	phpBB/language/en/memberlist.php
	tests/functional/ucp_profile_test.php
2014-06-20 23:42:54 +02:00
Joas Schilling
3c38fcce40 Merge pull request #2621 from Dragooon/ticket/12732
[ticket/12732] Add Skype custom profile field

* Dragooon/ticket/12732:
  [ticket/12732] Update schema.json for Skype
  [ticket/12732] Add functional test for Skype profile field
  [ticket/12732] Values shouldn't be escaped for schema_data.sql
  [ticket/12732] Set field_active to 1 for Skype's field
  [ticket/12732] Add unit tests for ALPHA_PUNCTUATION
  [ticket/12732] Missing comma after validation definition
  [ticket/12732] Improve ALPHA_PUNCTUATION description
  [ticket/12732] Use user info instead of chat as default Skype action
  [ticket/12732] Add Skype custom profile field

Conflicts:
	phpBB/install/schemas/schema.json
	phpBB/install/schemas/schema_data.sql
	phpBB/language/en/memberlist.php
	tests/functional/ucp_profile_test.php
	tests/profilefields/type_string_test.php
2014-06-20 23:39:54 +02:00
Joas Schilling
b9890c6a4c Merge pull request #2612 from Dragooon/ticket/12733
[ticket/12733] Add Twitter custom profile field

* Dragooon/ticket/12733:
  [ticket/12733] Add functional test for twitter profile field
  [ticket/12733] Values needn't be escaped for schema_data.sql
  [ticket/12733] Set field_active to 1 for Twitter
  [ticket/12733] Convert spaces to tabs
  [ticket/12733] Fix spacing for block header in profilefield_twitter.php
  [ticket/12733] Update schema.json
  [ticket/12733] Add Twitter custom profile field

Conflicts:
	phpBB/install/schemas/schema.json
	phpBB/install/schemas/schema_data.sql
	phpBB/language/en/memberlist.php
	tests/functional/ucp_profile_test.php
2014-06-20 23:37:51 +02:00
Shitiz Garg
6b58f40663 [ticket/12732] Update schema.json for Skype
PHPBB3-12732
2014-06-21 01:16:37 +05:30
Shitiz Garg
27d761d08e [ticket/12730] Values needn't be escaped for schema_data.sql
PHPBB3-12730
2014-06-20 21:04:07 +05:30
Shitiz Garg
abc55dcb40 [ticket/12733] Values needn't be escaped for schema_data.sql
PHPBB3-12733
2014-06-20 21:03:04 +05:30
Shitiz Garg
01e05ccc6b [ticket/12732] Values shouldn't be escaped for schema_data.sql
PHPBB3-12732
2014-06-20 21:02:11 +05:30
Shitiz Garg
acbc0ea1f7 [ticket/12731] Set field_active to 1 for YouTube field
PHPBB3-12731
2014-06-20 19:21:57 +05:30
Shitiz Garg
03c5de594e [ticket/12731] Add YouTube custom profile field
PHPBB3-12731
2014-06-20 19:21:57 +05:30
Shitiz Garg
a4db81b379 [ticket/12733] Set field_active to 1 for Twitter
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
deae22b85f [ticket/12733] Convert spaces to tabs
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
04e43e2087 [ticket/12733] Fix spacing for block header in profilefield_twitter.php
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
d7edf31b95 [ticket/12733] Update schema.json
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
fac6ab1fd4 [ticket/12733] Add Twitter custom profile field
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
c61a67503e [ticket/12732] Set field_active to 1 for Skype's field
PHPBB3-12732
2014-06-20 19:15:46 +05:30
Shitiz Garg
c23532e052 [ticket/12729] Set field_active as 1 for Facebook profile field
PHPBB3-12729
2014-06-20 19:09:17 +05:30
Shitiz Garg
5701a4658c [ticket/12729] Move ALPHA_DOTS to above ALPHA_SPACERS
Have easier matches first for better performance

PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
2ba12a17b2 [ticket/12729] Convert spaces to tabs
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
e127a4fcce [ticket/12729] Fix block header spacing for profilefield_facebook.php
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
f310bc00a7 [ticket/12729] Update schema.json
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
ab47798a3e [ticket/12729] Unnecessary whitespace in profilefield_facebook.php
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
c408ac52c3 [ticket/12729] Cleanup schema_data.sql for Facebook field
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
310b8af148 [ticket/12729] Add Facebook custom profile field
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
352f3b7e78 [ticket/12732] Missing comma after validation definition
PHPBB3-12732
2014-06-20 16:37:43 +05:30
Shitiz Garg
9d3f437149 [ticket/12732] Improve ALPHA_PUNCTUATION description
PHPBB3-12732
2014-06-20 16:37:42 +05:30
Shitiz Garg
da4b1d25a1 [ticket/12732] Use user info instead of chat as default Skype action
PHPBB3-12732
2014-06-20 16:37:42 +05:30
Shitiz Garg
28012dc9e1 [ticket/12732] Add Skype custom profile field
PHPBB3-12732
2014-06-20 16:37:42 +05:30
Joas Schilling
b855f5fc6a Merge pull request #2566 from marc1706/ticket/11711
[ticket/11711] Inform user of unsupported characters while posting

* marc1706/ticket/11711:
  [ticket/11711] Improve coding and comments of character check
  [ticket/11711] Reduce size of tests and also test topic titles
  [ticket/11711] Improve checks for unsupported characters and check subject
  [ticket/11711] Inform user of unsupported characters while posting
2014-06-20 10:51:58 +02:00
Joas Schilling
ccb8fd18e2 Merge pull request #2514 from prototech/ticket/12553
[ticket/12553] Right-to-left fixes.

* prototech/ticket/12553:
  [ticket/12553] Fix responsive user profile.
  [ticket/12553] Fix responsive post profile.
  [ticket/12553] Remove dropdown-trigger class from member search input.
  [ticket/12553] Fix the merge topic list.
  [ticket/12553] Fix dropdown position of live search
  [ticket/12553] Fix the responsive topic/forum lists.
  [ticket/12553] Align the text in responsive tables to the right.
  [ticket/12553] Center the responsive CP menus instead of floating right.
  [ticket/12553] Open the notification dropdown to the left.
  [ticket/12553] Fix alignment of contact icon.
  [ticket/12553] Fix incorrect alignment in ACP responsive tables.
  [ticket/12553] Align alert text to the right.
  [ticket/12553] Remove incorrect size for site logo.
  [ticket/12553] Fix links in the last post column that are not clickable.
  [ticket/12553] Align contact icons to the right.
  [ticket/12553] Move Place inline and Delete buttons left of the file name.
2014-06-20 10:37:30 +02:00
Andreas Fischer
5964ca21c2 Merge pull request #2525 from Nicofuma/ticket/12638
[ticket/12638] v30x\local_url_bbcode break the migrations if we don't use the auto updater

* Nicofuma/ticket/12638:
  [ticket/12638] Use require if phpbb_require_updated isn't available
2014-06-17 21:04:47 +02:00
Andreas Fischer
82cf239294 Merge pull request #2610 from brunoais/ticket/12699
[Ticket/12699] Remove magic numbers in the message textarea keydown callback

* brunoais/ticket/12699:
  [ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
  [ticket/12699] Add tab key to keymap
2014-06-17 18:13:12 +02:00
brunoais
e1b72c0b86 [ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
Replaced the magic numbers 9 and 13 in the keydown for the text editor
with constants in the existing keymap for phpBB.

PHPBB3-12699
2014-06-17 17:07:32 +01:00
Dhruv Goel
7ee3e3f73f Merge pull request #2588 from nickvergessen/ticket/12705
Ticket/12705 Fix make_clickable when called with different server_urls
2014-06-17 14:56:55 +05:30
Tristan Darricau
afcca62784 [ticket/12721] Update rules descriptions
PHPBB3-12721
2014-06-16 23:07:28 +02:00
Tristan Darricau
a94581e7ca [ticket/12721] Add Squiz.ControlStructures.ForLoopDeclaration in legacy
PHPBB3-12721
2014-06-16 22:35:44 +02:00
Tristan Darricau
09fc008e62 [ticket/12721] Add Squiz.ControlStructures.ElseIfDeclaration in legacy
PHPBB3-12721
2014-06-16 22:35:41 +02:00
Tristan Darricau
06bf864c41 [ticket/12721] Add Generic.Functions.OpeningFunctionBraceBsdAllman
PHPBB3-12721
2014-06-16 22:35:39 +02:00
Tristan Darricau
34a4ba36cd [ticket/12721] Add Squiz.Arrays.ArrayBracketSpacing in the legacy ruleset
PHPBB3-12721
2014-06-16 22:35:12 +02:00
Andreas Fischer
4d6afb2638 Merge pull request #2604 from Nicofuma/ticket/12722
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset

* Nicofuma/ticket/12722:
  [ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
2014-06-16 22:24:59 +02:00
Tristan Darricau
ca3cdadd08 [ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
PHPBB3-12722
2014-06-16 19:05:09 +02:00
Andreas Fischer
9531691537 Merge pull request #2607 from Noxwizard/ticket/12643
Ticket/12643 Fixes deletion of columns that have the target column as a prefix

* Noxwizard/ticket/12643:
  [ticket/12643] Properly handle changing columns on tables with constraints
  [ticket/12643] Tests dropping similarly named columns
  [ticket/12643] Ensure that similarly named columns are not removed
2014-06-16 15:14:10 +02:00
Patrick Webster
754e36e378 [ticket/12643] Properly handle changing columns on tables with constraints
PHPBB3-12643
2014-06-15 19:07:32 -05:00
Andreas Fischer
663c375f5c Merge pull request #2605 from Nicofuma/ticket/12724
[ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset

* Nicofuma/ticket/12724:
  [ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset
2014-06-16 01:37:21 +02:00
Tristan Darricau
5a320adc75 [ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset
PHPBB3-12724
2014-06-16 01:26:59 +02:00
Andreas Fischer
f27be59cf1 Merge pull request #2600 from Nicofuma/ticket/12715
[ticket/12715] Fix mistakes in the doc blocks

* Nicofuma/ticket/12715: (30 commits)
  [ticket/12715] Add missing new line in the notification manager
  [ticket/12715] Cleanup comments in \phpbb\symfony_request
  [ticket/12715] Cleanup comments in \phpbb\permissions
  [ticket/12715] Cleanup comments in \phpbb\path_helper
  [ticket/12715] Cleanup comments in \phpbb\pagination
  [ticket/12715] Cleanup comments in \phpbb\datetime
  [ticket/12715] Cleanup comments in \phpbb\content_visibility
  [ticket/12715] Cleanup comments in \phpbb\tree\*
  [ticket/12715] Cleanup comments in \phpbb\template\*
  [ticket/12715] Cleanup comments in \phpbb\plupload\*
  [ticket/12715] Cleanup comments in \phpbb\profilefields\*
  [ticket/12715] Cleanup comments in \phpbb\passwords\*
  [ticket/12715] Cleanup comments in \phpbb\notification\*
  [ticket/12715] Cleanup comments in \phpbb\mimetype\*
  [ticket/12715] Cleanup comments in \phpbb\message\*
  [ticket/12715] Cleanup comments in \phpbb\log\*
  [ticket/12715] Cleanup comments in \phpbb\lock\*
  [ticket/12715] Cleanup comments in \phpbb\groupposition\*
  [ticket/12715] Cleanup comments in \phpbb\feed\*
  [ticket/12715] Cleanup comments in \phpbb\extension\*
  ...
2014-06-16 01:12:03 +02:00
Tristan Darricau
f4ef1ab6bd [ticket/12715] Add missing new line in the notification manager
PHPBB3-12715
2014-06-16 01:01:10 +02:00