* develop-ascraeus:
[ticket/12718] Use a separate variable for sql query
[ticket/12718] Fix spacing and type casting
[ticket/12718] Fix docblocks
[ticket/12718] Add tests to check user_posts on post deletion
[ticket/12718] Update docblock
[ticket/12718] Use remove_topic_from_statistic() for delete_topic
[ticket/12718] Use remove_topic_from_statistic() for delete_topic
* dhruvgoel92/ticket/12718:
[ticket/12718] Use a separate variable for sql query
[ticket/12718] Fix spacing and type casting
[ticket/12718] Fix docblocks
[ticket/12718] Add tests to check user_posts on post deletion
[ticket/12718] Update docblock
[ticket/12718] Use remove_topic_from_statistic() for delete_topic
* develop-ascraeus:
[ticket/12710] Fix missing closing bracket
[ticket/12710] Prefix column so it does not start with a number
[ticket/12710] Pass the original column data to the create function
[ticket/12710] Fix foreach generation
[ticket/12710] Compare to uppercase version
[ticket/12710] Do not try to match the uniqueness in the query
[ticket/12710] Remove table_name from index_name before deleting and recreating them
[ticket/12710] Can not use upper in oracles where claus
[ticket/12710] Correctly select index name and compare to column name
[ticket/12710] Fix "ORA-00972: identifier is too long [972]" on oracle
[ticket/12710] Fix problems with creating unique indexes on oracle
[ticket/12710] Correctly fetch unique and normal indexes only in MSSQL
[ticket/12710] Fix changing the column type on oracle
[ticket/12710] Prepare get_existing_indexes() for other DBMS
* github-nickvergessen/ticket/12710:
[ticket/12710] Fix missing closing bracket
[ticket/12710] Prefix column so it does not start with a number
[ticket/12710] Pass the original column data to the create function
[ticket/12710] Fix foreach generation
[ticket/12710] Compare to uppercase version
[ticket/12710] Do not try to match the uniqueness in the query
[ticket/12710] Remove table_name from index_name before deleting and recreating them
[ticket/12710] Can not use upper in oracles where claus
[ticket/12710] Correctly select index name and compare to column name
[ticket/12710] Fix "ORA-00972: identifier is too long [972]" on oracle
[ticket/12710] Fix problems with creating unique indexes on oracle
[ticket/12710] Correctly fetch unique and normal indexes only in MSSQL
[ticket/12710] Fix changing the column type on oracle
[ticket/12710] Prepare get_existing_indexes() for other DBMS
* develop-ascraeus:
[ticket/12841] Make config position default to after
[ticket/12841] Update comments in tests making after default
[ticket/12841] prefix function name with phpbb_
[ticket/12841] Add a tests for the new function
[ticket/12841] Fix white space issues reported by sniffer
[ticket/12841] Allow extensions to position new config vars
[ticket/12841] Allow extensions to position new config vars
* VSEphpbb/ticket/12841:
[ticket/12841] Make config position default to after
[ticket/12841] Update comments in tests making after default
[ticket/12841] prefix function name with phpbb_
[ticket/12841] Add a tests for the new function
[ticket/12841] Fix white space issues reported by sniffer
[ticket/12841] Allow extensions to position new config vars
* develop-ascraeus:
[ticket/12738] Update constructor docblock
[ticket/12738] Add $config to constructor in notification test
[ticket/12738] Fix tests with new config object injection
[ticket/12738] Inject config object into content_visibility class
[ticket/11528] Move related code from functions_posting to function
[ticket/12738] Move related code from functions_posting to function
* dhruvgoel92/ticket/12738:
[ticket/12738] Update constructor docblock
[ticket/12738] Add $config to constructor in notification test
[ticket/12738] Fix tests with new config object injection
[ticket/12738] Inject config object into content_visibility class
[ticket/11528] Move related code from functions_posting to function
[ticket/12847] Allow the extensions to say if they can be enabled
* Nicofuma/ticket/12847:
[ticket/12847] Allow the extensions to say if they can be enabled
* develop-ascraeus:
[ticket/11148] Remove unneeded variable mimetype and use type octet-stream
[ticket/11148] Change expected output with disallowed content in test
[ticket/11148] Always use the output of the mimetype guesser in get_mimetype
[ticket/11148] Get rid of extra line in mimetype guesser setter doc block
[ticket/11148] Add missing parts to docblock of get_mimetype() method
[ticket/11148] Default to application/octet-stream if no mimetype given
[ticket/11148] Use mimetype guesser for uploaded avatars
[ticket/11148] Pass mimetype guesser to upload_attachment() function
[ticket/11148] Add mimetype guesser to filespec and fileupload class
* github-marc1706/ticket/11148:
[ticket/11148] Remove unneeded variable mimetype and use type octet-stream
[ticket/11148] Change expected output with disallowed content in test
[ticket/11148] Always use the output of the mimetype guesser in get_mimetype
[ticket/11148] Get rid of extra line in mimetype guesser setter doc block
[ticket/11148] Add missing parts to docblock of get_mimetype() method
[ticket/11148] Default to application/octet-stream if no mimetype given
[ticket/11148] Use mimetype guesser for uploaded avatars
[ticket/11148] Pass mimetype guesser to upload_attachment() function
[ticket/11148] Add mimetype guesser to filespec and fileupload class
* develop-ascraeus:
[ticket/11480] Header file
[ticket/11480] Fix unit tests
[ticket/11480] Move the test into get_folder()
[ticket/11480] Fix the double spaces in phpbb_functional_test_case
[ticket/11480] Fix typos
[ticket/11480] Add functionnal test
[ticket/11480] PM : "Unknown folder" returned when inbox folder is full
* ticket/11480:
[ticket/11480] Move the test into get_folder()
[ticket/11480] Fix the double spaces in phpbb_functional_test_case
[ticket/11480] Fix typos
[ticket/11480] Add functionnal test
[ticket/11480] PM : "Unknown folder" returned when inbox folder is full
Conflicts:
tests/test_framework/phpbb_functional_test_case.php
* develop-ascraeus:
[ticket/12870] Add doc block
[ticket/12870] Create the migrations table with a method in the migrator
[ticket/12870] Add $config['version'] in phpbb_extension_manager_test
[ticket/12870] Create the migrations table in db:migrate
[ticket/12870] phpbbcli.php db:migrate can not update from 3.0.12 to 3.1
* Nicofuma/ticket/12870:
[ticket/12870] Add doc block
[ticket/12870] Create the migrations table with a method in the migrator
[ticket/12870] Add $config['version'] in phpbb_extension_manager_test
[ticket/12870] Create the migrations table in db:migrate
* develop-ascraeus:
[ticket/12793] Tests (added and changed)
[ticket/12793] Changing get_profile_contact_value to get_profile_value_raw
[ticket/12793] String '0' does not display for string profile fields
[ticket/12793] String '0' does not display for string profile fields
* lucifer4o/ticket/12793:
[ticket/12793] Tests (added and changed)
[ticket/12793] Changing get_profile_contact_value to get_profile_value_raw
[ticket/12793] String '0' does not display for string profile fields
# By Joas Schilling
# Via Dhruv Goel (1) and Joas Schilling (1)
* develop-ascraeus:
[ticket/12448] Fix null columns for MS SQL
[ticket/12448] Fix null columns for postgres
[ticket/12448] Allow null as default value for columns
* develop-ascraeus:
[ticket/12818] Use assertGreaterThanOrEqual in the tests
[ticket/12818] Don't use the id for i=
[ticket/12818] Add tests
[ticket/12818] Fix the conditions in the call to $log->delete() in mcp_logs
[ticket/12818] Deleting a log entry in MCP produces a General error
* Nicofuma/ticket/12818:
[ticket/12818] Use assertGreaterThanOrEqual in the tests
[ticket/12818] Don't use the id for i=
[ticket/12818] Add tests
[ticket/12818] Fix the conditions in the call to $log->delete() in mcp_logs
* develop-ascraeus: (34 commits)
[ticket/12775] Set dbal.conn.driver as synthetic during installation
[ticket/12775] Add the definition of dbal.conn in fixtures/config/services.yml
[ticket/12775] Inject the connection when created in the container
[ticket/12775] Extract the vars later in install/install_update.php
[ticket/12775] Rename config_php_handler to config_php_file container_builder
[ticket/12775] Set defined_vars as a property of config_php_file
[ticket/12775] Fix doc blocks in the container builder
[ticket/12775] Remove useless includes of config.php
[ticket/12775] Move phpbb_convert_30_dbms_to_31 into the config file class
[ticket/12775] Fix comments
[ticket/12775] Update doc blocks
[ticket/12775] Fix container_builder
[ticket/12775] Rename config_php to config_php_file
[ticket/12775] Renamed to \phpbb\di\container_builder
[ticket/12775] Remove the last include of functions_container
[ticket/12775] Fix unit tests
[ticket/12775] Add tests for \phpbb\config_php
[ticket/12775] Add tests for the container factory
[ticket/12775] Use a field instead of a local var in load_config_var()
[ticket/12775] Update container and config in install/
...
[ticket/12775] Replace functions_container with a container_builder class.
* Nicofuma/ticket/12775: (34 commits)
[ticket/12775] Set dbal.conn.driver as synthetic during installation
[ticket/12775] Add the definition of dbal.conn in fixtures/config/services.yml
[ticket/12775] Inject the connection when created in the container
[ticket/12775] Extract the vars later in install/install_update.php
[ticket/12775] Rename config_php_handler to config_php_file container_builder
[ticket/12775] Set defined_vars as a property of config_php_file
[ticket/12775] Fix doc blocks in the container builder
[ticket/12775] Remove useless includes of config.php
[ticket/12775] Move phpbb_convert_30_dbms_to_31 into the config file class
[ticket/12775] Fix comments
[ticket/12775] Update doc blocks
[ticket/12775] Fix container_builder
[ticket/12775] Rename config_php to config_php_file
[ticket/12775] Renamed to \phpbb\di\container_builder
[ticket/12775] Remove the last include of functions_container
[ticket/12775] Fix unit tests
[ticket/12775] Add tests for \phpbb\config_php
[ticket/12775] Add tests for the container factory
[ticket/12775] Use a field instead of a local var in load_config_var()
[ticket/12775] Update container and config in install/
...