mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-01-17 22:28:46 +01:00
Code Issues Releases Wiki Activity
10,935 Commits 17 Branches 190 Tags
Commit Graph

37 Commits

Author SHA1 Message Date
Andreas Fischer
f894da0d25 [ticket/10633] Stop leaking filename of attachments when thumbnail is requested 
While filenames are chosen at random and there is no correlation between the
original filename and the new filesystem filename, there is a correlation
between filesystem filename and filesytem filename of thumbnails.

Adjust error message to no longer include the physical filename and make it
consistent with the error message that is shown when there is no attachment at
all.

This information was mostly useless for regular users (i.e. non-admins) anyway.

PHPBB3-10633
 2012-02-09 15:17:42 +01:00
Yuriy Rusko
f8eb154714 [ticket/10218] Moving global deregistration, etc. to startup.php 
Because startup.php deletes all variables, the constants in
database_update are used to preserve settings at the top.

PHPBB3-10218
 2011-06-14 06:11:35 -04:00
Andreas Fischer
5a4a1e3c25 [ticket/10126] Use binary "and not" instead of binary "xor" in error_reporting. 
Make what we want to achieve clear by using "and not" instead of "xor".

PHPBB3-10126
 2011-05-11 03:56:15 +02:00
Oleg Pudeyev
786078d423 [ticket/10041] Use send_status_line more in download/file.php 
PHPBB3-10041
 2011-02-23 20:16:16 -05:00
Andreas Fischer
23d2798b6d [ticket/10038] Use request_var() in the avatar code path of download/file.php 
There is no reason not to use request_var() here because it is available anyway
since 3afd2c6948e777fde2f43f00bff1659f2691f4d8.

This change especially prevents submitting an array which might then throw an
error in one of the string functions substr() or strpos() later on.

PHPBB3-10038
 2011-02-12 19:22:51 +01:00
Andreas Fischer
bef108a5cc [ticket/9609] Change header() calls setting HTTP status to send_status_line(). 
PHPBB3-9609
 2010-09-11 22:01:31 +02:00
Andreas Fischer
3afd2c6948 [ticket/9793] Make sure send_status_line() is defined when in avatar mode. 
When download/file.php is in avatar mode set_modified_headers() can be called,
which then calls send_status_line() which is not available because
includes/functions.php is not included in avatar mode.

We also load includes/functions.php in the bootstrap now to solve this problem.

Regression from c1a4cb1d01dc19650219566b60671abc767af662.

PHPBB3-9793
PHPBB3-7782
 2010-08-27 15:36:26 +02:00
Andreas Fischer
881c74688b [ticket/9694] Call error_reporting() in download/file.php when in avatar mode. 
PHPBB3-9694
 2010-07-01 23:30:48 +02:00
Andreas Fischer
32882fd798 [ticket/9694] Make sure string offset 0 exists to avoid E_NOTICE message. 
PHPBB3-9694
 2010-07-01 23:29:25 +02:00
Oleg Pudeyev
c1a4cb1d01 [ticket/7782] Send status line using refactored download/file.php logic. 
PHPBB3-7782
 2010-05-16 18:24:26 -04:00
Henry Sudhof
10bc773979 #54245 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10282 89ea8834-ac86-4346-8a33-228a782c2dd0
 2009-11-21 09:14:07 +00:00
Meik Sievertsen
2958890439 Apply locale-independent basename() to attachment filenames. New function added: utf8_basename(). (Bug #43335 - Patch by ocean=Yohsuke) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9905 89ea8834-ac86-4346-8a33-228a782c2dd0
 2009-08-01 12:28:50 +00:00
Meik Sievertsen
556b177e9c #26145 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9460 89ea8834-ac86-4346-8a33-228a782c2dd0
 2009-04-17 15:18:03 +00:00
Henry Sudhof
7479592c81 Some changes to the SAPI detection. The weird fact that it doesn't work without remains. 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9448 89ea8834-ac86-4346-8a33-228a782c2dd0
 2009-04-14 13:59:12 +00:00
Meik Sievertsen
d4ac2d4209 Flash files do not display anymore after update to flash player 10 (Bug #41315) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9384 89ea8834-ac86-4346-8a33-228a782c2dd0
 2009-03-17 14:42:13 +00:00
Meik Sievertsen
3b918a234e Fix download count increments for image attachments without corresponding thumbnails. (Bug #42505) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9373 89ea8834-ac86-4346-8a33-228a782c2dd0
 2009-03-16 15:59:53 +00:00
Henry Sudhof
354f9edd4e can't they decide on one single thing... 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9341 89ea8834-ac86-4346-8a33-228a782c2dd0
 2009-02-25 15:09:04 +00:00
Henry Sudhof
cd6e5a85e7 #38995 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9203 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-12-17 13:43:08 +00:00
Henry Sudhof
761897cb1c Getting ready for IE8 which finally improves security a bit. Let's allow our users to benefit from that 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8792 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-08-28 13:10:05 +00:00
Meik Sievertsen
7e28be5968 close db connection before delivering file. Also make sure connection can't be closed twice. 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8772 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-08-21 14:19:42 +00:00
Henry Sudhof
bf59a749c3 Let's try to keep the lid on the jar 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8745 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-08-13 12:30:40 +00:00
Henry Sudhof
efe9d1955a enable stupid php.ini fallback for readfile (#30325 - fix by bellzebu) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8724 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-07-29 15:17:27 +00:00
Henry Sudhof
86dddd43b6 forgot a few things 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8708 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-07-29 12:36:07 +00:00
Henry Sudhof
7997796789 Mylek is right - we should do this. Fixes some aspects of file.php, needs testing. 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8707 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-07-29 11:49:56 +00:00
Nils Adermann
fd57f020f7 removed executable props [Bug #6464] 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8598 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-06-04 15:37:06 +00:00
Meik Sievertsen
71d725ae91 add PHPBB_INSTALLED check to file.php too 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8514 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-04-21 10:54:41 +00:00
Meik Sievertsen
d182a88b68 Forbidden should have an uppercase F 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8459 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-03-23 14:39:38 +00:00
Meik Sievertsen
9a236a55d3 #s23535 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8454 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-03-21 10:47:48 +00:00
Meik Sievertsen
c7821700dd #19955 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8348 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-01-29 15:49:15 +00:00
Henry Sudhof
0745a023b8 erm, yes. 
git-svn-id: file:///svn/phpbb/trunk@8282 89ea8834-ac86-4346-8a33-228a782c2dd0
 2007-12-20 10:56:03 +00:00
Henry Sudhof
ab9465a90e Hopefully fixes avatar caching for CGI installs. 
git-svn-id: file:///svn/phpbb/trunk@8281 89ea8834-ac86-4346-8a33-228a782c2dd0
 2007-12-19 17:23:14 +00:00
Henry Sudhof
559f614db7 hrm - let's try this. 
git-svn-id: file:///svn/phpbb/trunk@8242 89ea8834-ac86-4346-8a33-228a782c2dd0
 2007-11-17 22:35:33 +00:00
Henry Sudhof
053730e477 Nothing we can do about IE 6, but this should reduce the bandwidth need significantly. 
git-svn-id: file:///svn/phpbb/trunk@8238 89ea8834-ac86-4346-8a33-228a782c2dd0
 2007-11-16 14:21:05 +00:00
Henry Sudhof
2adef2c457 #14924 
git-svn-id: file:///svn/phpbb/trunk@8215 89ea8834-ac86-4346-8a33-228a782c2dd0
 2007-10-27 12:36:57 +00:00
Meik Sievertsen
83abd98a3d fix download location for img wrap 
git-svn-id: file:///svn/phpbb/trunk@8180 89ea8834-ac86-4346-8a33-228a782c2dd0
 2007-10-14 13:12:08 +00:00
Meik Sievertsen
27fc215914 ups, seems i really forgot to change this. :) 
git-svn-id: file:///svn/phpbb/trunk@8136 89ea8834-ac86-4346-8a33-228a782c2dd0
 2007-10-04 15:09:42 +00:00
Meik Sievertsen
87e2e62c34 #i8 
git-svn-id: file:///svn/phpbb/trunk@8119 89ea8834-ac86-4346-8a33-228a782c2dd0
 2007-10-02 18:29:05 +00:00