Joas Schilling
714092ab4e
[ticket/11495] Add owns_lock() method to lock classes
...
PHPBB3-11495
2013-04-30 15:48:29 +02:00
Joas Schilling
863d0c7687
[ticket/11495] Fix some more comments and the package tag
...
PHPBB3-11495
2013-04-30 14:36:26 +02:00
Joas Schilling
67f2edae17
[ticket/11495] Use descendants and ancestors instead of parents/children
...
PHPBB3-11495
2013-04-30 13:58:03 +02:00
Joas Schilling
4810c61fd7
[ticket/11495] Remove get_parent_data from interface and rename it
...
The method is implementation specific and has no use, apart from cache, that is
not covered by get_path_data().
PHPBB3-11495
2013-04-30 10:37:59 +02:00
Joas Schilling
8a4260703f
[ticket/11495] Fix some docs and replace branch with other terms
...
PHPBB3-11495
2013-04-30 10:32:01 +02:00
Joas Schilling
baff4287e5
[ticket/11495] Fix comments and package docs
...
PHPBB3-11495
2013-04-25 22:39:24 +02:00
Joas Schilling
ce07b27765
[ticket/11495] Fix failing unit tests
...
PHPBB3-11495
2013-04-25 17:27:33 +02:00
Joas Schilling
d4b7708d4b
[ticket/11495] Remove tests for add/remove we make them protected later
...
PHPBB3-11495
2013-04-25 17:19:21 +02:00
Joas Schilling
499dd3a833
[ticket/11495] Move tests to tree/ directory
...
PHPBB3-11495
2013-04-25 17:13:21 +02:00
Joas Schilling
b334a2ce0f
[ticket/11495] Move classes to tree/ as they all implement a tree
...
PHPBB3-11495
2013-04-25 17:04:37 +02:00
Joas Schilling
94dee77647
[ticket/11495] Replace fixtures content with manual calls
...
Should be easier to maintain
PHPBB3-11495
2013-04-25 16:50:11 +02:00
Joas Schilling
804f139be0
[ticket/11495] Use default exceptions
...
PHPBB3-11495
2013-04-25 16:17:58 +02:00
Joas Schilling
fe97915fc9
[ticket/11495] Split get_branch_data into multiple methods
...
PHPBB3-11495
2013-04-25 14:05:41 +02:00
Joas Schilling
ab7054445f
[ticket/11495] Rename set_parent to change_parent()
...
PHPBB3-11495
2013-04-25 13:48:19 +02:00
Joas Schilling
4bff28a0ee
[ticket/11495] Rename fix function to regenerate_left_right_ids()
...
This method regenerates the left/right ids for the nested set based on the
parent/child relations. This function executes three queries per item, so
it should only be called, when the set has one of the following problems:
- The set has a duplicated value inside the left/right id chain
- The set has a missing value inside the left/right id chain
- The set has items that do not have a left/right is set
When regenerating the items, the items are sorted by parent id and their
current left id, so the current child/parent relationships are kept and
running the function on a working set will not change any orders.
PHPBB3-11495
2013-04-25 13:40:25 +02:00
Joas Schilling
87dc3b1e55
[ticket/11495] Use item ids instead of requiring all data
...
The data is grabbed again in most cases anyway, so it just makes the system
easier to use.
PHPBB3-11495
2013-04-19 21:07:42 +02:00
Joas Schilling
3d54a81ed9
[ticket/11495] Use item_id only as parameter for delete() and remove()
...
The data is acquired again anyway
PHPBB3-11495
2013-04-19 16:19:01 +02:00
Joas Schilling
d24ff2329f
[ticket/11495] Use item_id only as parameter for get_branch_data()
...
PHPBB3-11495
2013-04-19 16:18:03 +02:00
Joas Schilling
d11fed65da
[ticket/11495] Remove item class from unit tests
...
PHPBB3-11495
2013-04-18 00:33:48 +02:00
Joas Schilling
dcee7961e8
[ticket/11495] Add unit tests for the implemented functions
...
PHPBB3-11495
2013-04-16 23:43:38 +02:00
Andreas Fischer
a0d10cd7fc
Merge remote-tracking branch 'nickvergessen/ticket/11491' into develop
...
* nickvergessen/ticket/11491:
[ticket/11491] Copy files back only if we saved them previously
[ticket/11491] Only copy files from phpBB/ext/ the directory exists
[ticket/11491] Correctly remove the store/temp_ext/ directory after use
[ticket/11491] Fix path to the ext/ folder
[ticket/11491] Add extension_acp_test.php to functional group
[ticket/11491] Fix class name of functional test
[ticket/11491] Move file to correct directory
2013-04-15 14:56:13 -04:00
Andreas Fischer
fbe115b434
Merge branch 'develop-olympus' into develop
...
* develop-olympus:
[ticket/11493] add checks for Notice and Warning
[ticket/11493] add check for phpBB Debug in functional tests
2013-04-15 14:27:52 -04:00
Dhruv
14071e6085
[ticket/11493] add checks for Notice and Warning
...
PHPBB3-11493
2013-04-15 22:02:21 +05:30
Dhruv
82a630cd64
[ticket/11493] add check for phpBB Debug in functional tests
...
PHPBB3-11493
2013-04-15 20:41:05 +05:30
Joas Schilling
6bcc220df3
[ticket/11494] Filter crawler in first place
...
PHPBB3-11494
2013-04-15 03:37:03 +02:00
Joas Schilling
cbfe866eba
[ticket/11494] Use functions instead of repeating
...
PHPBB3-11494
2013-04-13 18:03:02 +02:00
Joas Schilling
13ca1f5598
[ticket/11491] Copy files back only if we saved them previously
...
PHPBB3-11491
2013-04-12 02:18:38 +02:00
Joas Schilling
3436e3f102
[ticket/11491] Only copy files from phpBB/ext/ the directory exists
...
PHPBB3-11491
2013-04-12 02:03:58 +02:00
Joas Schilling
0b64db275b
[ticket/11491] Correctly remove the store/temp_ext/ directory after use
...
PHPBB3-11491
2013-04-12 01:40:45 +02:00
Joas Schilling
56bcf7497e
[ticket/11491] Fix path to the ext/ folder
...
PHPBB3-11491
2013-04-12 01:10:09 +02:00
Joas Schilling
08e7bd6166
[ticket/11491] Add extension_acp_test.php to functional group
...
PHPBB3-11491
2013-04-12 01:09:09 +02:00
Joas Schilling
4c99229be8
[ticket/11491] Fix class name of functional test
...
PHPBB3-11491
2013-04-12 01:08:40 +02:00
Joas Schilling
b2b8b62fad
[ticket/11491] Move file to correct directory
...
PHPBB3-11491
2013-04-12 01:08:09 +02:00
Joas Schilling
5c24474c2a
[ticket/11494] Fix memberlist leaders functional tests
...
The scope of the crawler should be reduced to the specific table
PHPBB3-11494
2013-04-11 22:11:52 +02:00
Joas Schilling
4d4cf25edd
[ticket/11492] Fix the test once more
...
PHPBB3-11492
2013-04-11 16:29:15 +02:00
Joas Schilling
7f527e8012
[ticket/11492] Fix issues with log object
...
PHPBB3-11492
2013-04-11 16:05:04 +02:00
Joas Schilling
f920c69ad5
[ticket/11492] Split into mutliple tests
...
PHPBB3-11492
2013-04-11 15:44:54 +02:00
Joas Schilling
e5503e20d8
[ticket/11492] Do not add the user again
...
PHPBB3-11492
2013-04-11 15:28:55 +02:00
Joas Schilling
59ad90b25c
[ticket/11492] Add tests for removing/adding users
...
PHPBB3-11492
2013-04-11 15:20:14 +02:00
Joas Schilling
60713c8a20
[ticket/11492] Add functional test for empty teampage
...
PHPBB3-11492
2013-04-11 15:00:22 +02:00
Nils Adermann
3985bdbc1b
Merge pull request #1199 from imkingdavid/ticket/11334
...
[ticket/11334] Properly generate controller URL with helper url() method
2013-04-03 06:44:15 -07:00
Nils Adermann
78dc1c84c8
Merge pull request #1316 from nickvergessen/ticket/11405
...
Ticket/11405 Users that are subscribed to a forum, should receive notifications for new replies
2013-03-31 15:02:48 -07:00
Andreas Fischer
e3a6935de6
[ticket/11469] Add more table status assertions.
...
PHPBB3-11469
2013-03-28 00:28:51 +01:00
Andreas Fischer
e022a7e8f6
[ticket/11469] Remove comments. Method names should be good enough now.
...
PHPBB3-11469
2013-03-28 00:28:51 +01:00
Andreas Fischer
a04fe625a8
[ticket/11469] Do not repeat markTestSkipped() message.
...
PHPBB3-11469
2013-03-28 00:28:51 +01:00
Andreas Fischer
6f946e2188
[ticket/11469] Refactor get_three_rows() into get_rows($n).
...
PHPBB3-11469
2013-03-28 00:28:51 +01:00
Andreas Fischer
eacd0f3e7d
[ticket/11469] Fix spacing in getDataSet().
...
PHPBB3-11469
2013-03-28 00:28:51 +01:00
Andreas Fischer
c909d9602b
[ticket/11469] Do not repeat assert_config_count(2). Also move to setUp().
...
PHPBB3-11469
2013-03-28 00:28:50 +01:00
Andreas Fischer
b48c4d9549
[ticket/11469] Use setUp() to setup DB and a buffer with size 2.
...
PHPBB3-11469
2013-03-28 00:28:50 +01:00
Andreas Fischer
b88eb3c8e0
[ticket/11469] Do not repeat row generation.
...
PHPBB3-11469
2013-03-28 00:28:50 +01:00