1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-25 12:33:29 +01:00

13131 Commits

Author SHA1 Message Date
Andreas Fischer
73a75fc3d3 [ticket/8713] Revert changes to ucp_profile, ucp_register and acp_users.
Currently only auth_db is supported there and the password needs to be trimmed
for compatibility because user_password stores

  phpbb_hash(htmlspecialchars(trim($password)))

Setting passwords for other auth modules is currently not supported.

Once setting/changing passwords is supported by auth plugins, the
untrimmed_variable() should be used here and the result should be passed
to the auth plugin.

PHPBB3-8713
2012-09-09 21:10:29 +02:00
Andreas Fischer
1e05fd4c62 [ticket/8713] Trim password in auth_db to keep compatibility.
PHPBB3-8713
2012-09-08 15:01:29 +02:00
Andreas Fischer
cc0c378caf [ticket/8713] Call htmlspecialchars_decode() on transfer (e.g. ftp) passwords.
PHPBB3-8713
2012-09-08 14:42:38 +02:00
Andreas Fischer
f2607fc9e8 [ticket/8713] Rename untrimed_variable() to untrimmed_variable().
PHPBB3-8713
2012-09-08 14:15:56 +02:00
Andreas Fischer
b62c37c579 [ticket/8713] DRY: variable() and untrimed_variable() into a protected method.
PHPBB3-8713
2012-09-08 14:09:12 +02:00
Andreas Fischer
c3e0d1b6d1 [ticket/8713] Fix type_cast_helper.php doc blocks: Add punctuation etc.
PHPBB3-8713
2012-09-08 14:07:42 +02:00
Andreas Fischer
798033075b [ticket/8713] Always trim array keys.
PHPBB3-8713
2012-09-08 14:07:06 +02:00
Nathaniel Guse
b3cd5a649b [ticket/8713] Do not trim login inputs
Create a function to request variables which are not trimmed.

All requests for passwords (except forum passwords) now use the
untrimmed request function.

PHPBB3-8713
2012-09-03 13:32:33 -05:00
Unknown Bliss
81f7f28cc3 [ticket/10631] Removing un-needed TODOs that are no longer needed.
PHPBB3-10631
2012-09-01 21:30:35 +01:00
Unknown Bliss
79da1ea592 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/10631
Conflicts:
	phpBB/common.php
	phpBB/download/file.php
2012-09-01 21:15:39 +01:00
Nils Adermann
43190ebeca Merge pull request #962 from imkingdavid/feature/add_events
Feature/add events
2012-09-01 12:44:23 -07:00
Nils Adermann
c539c2b0f9 Merge remote-tracking branch 'github-igorw/feature/dic' into develop
* github-igorw/feature/dic: (35 commits)
  [feature/dic] Spaces to tabs, add useless docblocks
  [feature/dic] Remove unneeded newline
  [feature/dic] Add a doc block for the prune_forum cron task forum_data
  [feature/dic] Update composer.lock to symfony/* RC1
  [feature/dic] Fix re-ordering of services
  [feature/dic] Fix parse errors
  [feature/dic] Add docblock for cron_manager::wrap_task()
  [feature/dic] Make cron task attributes protected, one per line
  [feature/dic] Coding style: Braces
  [feature/dic] Re-order services alphabetically
  [feature/dic] Remove duplicate event-dispatcher dependency
  [feature/dic] Adjust installer script to work with partially configured container
  [feature/dic] Generate full cache driver class name on fresh install
  [feature/dic] Adjust cache driver class name for BC
  [feature/dic] Rename {phpEx => php_ext} for consistency
  [feature/dic] Add trailing newline to htaccess
  [feature/dic] Require symfony/* 2.1.*, tabs instead of spaces, --dev lock file
  [feature/dic] Load services from extensions
  [feature/dic] Introduce DI processors instead of abusing compiler passes
  [feature/dic] Add dbal_ class prefix to dbal.driver.class
  ...
2012-09-01 19:21:24 +02:00
Igor Wiedler
282a80077d [feature/dic] Spaces to tabs, add useless docblocks
Fully documents the constructors of the processors and the cron tasks.

PHPBB3-10739
2012-09-01 19:17:01 +02:00
Igor Wiedler
7ed7b19a1f [feature/dic] Remove unneeded newline
PHPBB3-10739
2012-09-01 19:12:57 +02:00
Nils Adermann
66b60ddba8 Merge remote-tracking branch 'github-igorw/ticket/11082' into develop
* github-igorw/ticket/11082:
  [ticket/11082] Remove executable permission from redis driver file
2012-09-01 18:02:51 +02:00
Igor Wiedler
8741bcdaf5 [ticket/11083] Mark memory cache driver as abstract
PHPBB3-11083
2012-09-01 17:51:27 +02:00
Igor Wiedler
ed052290a7 [ticket/11082] Remove executable permission from redis driver file
PHPBB3-11082
2012-09-01 17:40:19 +02:00
Michael C.
0c35ee2769 [ticket/10631] Fix a spelling typo
PHPBB3-10631
2012-09-01 17:32:59 +02:00
Nils Adermann
4fde4abe55 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [task/functional] Fixed DEBUG_TEST related issues
  [task/functional] Allow tests to bypass certain restrictions with DEBUG_TEST
  [task/functional] Added posting tests (reply and new topic)
2012-09-01 17:06:59 +02:00
Nils Adermann
3bd19077dc Merge remote-tracking branch 'github-imkingdavid/task/functional' into develop-olympus
* github-imkingdavid/task/functional:
  [task/functional] Fixed DEBUG_TEST related issues
  [task/functional] Allow tests to bypass certain restrictions with DEBUG_TEST
  [task/functional] Added posting tests (reply and new topic)
2012-09-01 17:06:41 +02:00
David King
4dd1bbc587 [task/functional] Fixed DEBUG_TEST related issues
PHPBB3-10758
2012-09-01 10:53:01 -04:00
David King
7dfe26dd78 [task/functional] Allow tests to bypass certain restrictions with DEBUG_TEST
PHPBB3-10758
2012-09-01 10:37:44 -04:00
Nils Adermann
d866624ea7 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10873] Change language for notice about undelivered, deleted PM.
2012-09-01 16:11:57 +02:00
Nils Adermann
0ba2bfffe2 Merge remote-tracking branch 'github-imkingdavid/ticket/10873' into develop-olympus
* github-imkingdavid/ticket/10873:
  [ticket/10873] Change language for notice about undelivered, deleted PM.
2012-09-01 16:11:42 +02:00
Unknown Bliss
f05a175e39 [ticket/10631] Fixing a few extension admin issues
PHPBB3-10631
2012-09-01 15:05:59 +01:00
Unknown Bliss
323bbf9b52 [ticket/10631] Adjust prefixes to be easier to understand
PHPBB3-10631
2012-09-01 15:05:57 +01:00
Nathan Guse
7b643fe8a5 [ticket/10631] Make failure to meet ext enable requirements clearer
Turn the blocks red on the details page if requirement is not met.

Also changing a how the errors come up when trying to enable/disable
an extension when they cannot be.

PHPBB3-10631
2012-09-01 15:05:56 +01:00
Nathan Guse
dce04b2d03 [ticket/10631] Various front-end fixes (extensions manager)
Add Back button from details

Add cancel button from actions

Correct language strings

PHPBB3-10631
2012-09-01 15:05:54 +01:00
Nathan Guse
36465c9a20 [ticket/10631] Functional acp_extensions test, cleanup
PHPBB3-10631
2012-09-01 15:05:49 +01:00
Nathan Guse
500879520c [ticket/10631] Metadata manager tests
PHPBB3-10631
2012-09-01 15:05:47 +01:00
Nathan Guse
747c16240f [ticket/10631] get_extension_metadata_manager -> create_extension_metadata_manager
PHPBB3-10631
2012-09-01 15:05:40 +01:00
Nathan Guse
2a7e129291 [ticket/10631] Simplify exceptions
PHPBB-10631
2012-09-01 15:05:36 +01:00
Nathan Guse
89f4cf6a8c [ticket/10631] Use exceptions for errors. Build action list dynamically.
PHPBB3-10631
2012-09-01 15:05:34 +01:00
Nathan Guse
106c105113 [ticket/10631] Fix some issues as noted in github comments, significantly simplified validation
PHPBB3-10631
2012-09-01 15:05:32 +01:00
Nathan Guse
2273ae2b34 [ticket/10631] Remove references to delete extension
PHPBB3-10631
2012-09-01 15:05:30 +01:00
Nils Adermann
790e64433d Merge pull request #921 from imkingdavid/ticket/10444
[ticket/10444] Do not default to the previous post edit reason.
2012-09-01 07:05:29 -07:00
Nathan Guse
9c0cd2693f [ticket/10631] Make the enable/disable/purge notices more visable.
PHPBB3-10631
2012-09-01 15:05:28 +01:00
Nathan Guse
8df9963fcc [ticket/10631] Additional validation
PHPBB3-10631
2012-09-01 15:05:26 +01:00
Nathan Guse
4314284de1 [ticket/10631] Remove code duplication
PHPBB3-10631
2012-09-01 15:05:24 +01:00
Nathan Guse
8bbab088dd [ticket/10631] Validation for extensions
PHPBB3-10631
2012-09-01 15:05:23 +01:00
Nathan Guse
74492b3cdd [ticket/10631] Use display name if available
PHPBB3-10631
2012-09-01 15:05:20 +01:00
Nathan Guse
28ca2d6a5f [ticket/10631] Stagger the enable/disable/purge for extensions
PHPBB3-10631
2012-09-01 15:05:18 +01:00
Nathan Guse
bf6e91b5f3 [ticket/10631] Fixing some more issues
PHPBB3-10631
2012-09-01 15:05:16 +01:00
Nathan Guse
6b12f71b94 [ticket/10631] Fix list_available_exts
PHPBB3-10631
2012-09-01 15:05:14 +01:00
Nathan Guse
3ba59c6362 [ticket/10631] Various tidbits and cleanup on the acp extensions manager
PHPBB3-10631
2012-09-01 15:05:12 +01:00
Michael Cullum
c45243a91e [ticket/10631] Fix so it installs the module in the correct place
PHPBB3-10631
2012-09-01 15:05:10 +01:00
Michael Cullum
18cd1262b2 [ticket/10631] Fixing up the template
PHPBB3-10631
2012-09-01 15:05:08 +01:00
Michael Cullum
0c18b16e28 [ticket/10631] Adding docblocks
PHPBB3-10631
2012-09-01 15:05:06 +01:00
Michael Cullum
dd4f07f9bb [ticket/10631] Template shouldn't be required
PHPBB3-10631
2012-09-01 15:05:04 +01:00
Michael Cullum
3e6761b026 [ticket/10631] Fixing and finishing the extension metadata class.
PHPBB3-10631
2012-09-01 15:05:03 +01:00