1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-05 15:16:16 +02:00

61 Commits

Author SHA1 Message Date
Marc Alexander
48283d7c62 [ticket/14532] Do not escape column default in mssql
The column default shouldn't be escaped for mssql. This is a regression
from 743d816631292a2081af4c5f7fc2fad2aff17c58. Prior to that commit, the
default value for the column was not escaped. Escaping it will cause SQL
errors while altering columns.

PHPBB3-14532
2016-03-31 16:07:05 +02:00
javiexin
56f47c1344 [ticket/13908] "After" clause in migration not working
In a migration file, if you try to add a column to a table and specify
the order, by specifying an "after" clause, it is not used at all, even
for databases that support it (like mysql).
This fixes the issue, for mysql databases. Typo fixed.

PHPBB3-13908
2015-06-02 09:00:05 +02:00
javiexin
86945bdf84 [ticket/13908] "After" clause in migration not working
In a migration file, if you try to add a column to a table and specify
the order, by specifying an "after" clause, it is not used at all, even
for databases that support it (like mysql).
This fixes the issue, for mysql databases.

PHPBB3-13908
2015-06-01 19:50:32 +02:00
Marc Alexander
816465bfe9 [ticket/13282] Use strpos() instead of preg_match()
PHPBB3-13282
2015-01-22 10:11:08 +01:00
Marc Alexander
1367fc234f [ticket/13282] Use 0 as default for integer type columns in postgresql
PHPBB3-13282
2015-01-22 00:06:48 +01:00
rxu
2f92bc38e6 [ticket/13406] Add a space between the index name and columns list
Currently there's no space between the index name and columns list
when generating ADD INDEX sql query for MySQL DBMSes. This may cause errors
on earlier MySQL versions like 3.23.

PHPBB3-13406
2014-11-30 16:52:36 +07:00
Patrick Webster
c3aca59cfb [ticket/13268] Properly append ternary result in get_existing_indexes()
PHPBB3-13268
2014-11-01 19:12:28 +01:00
Joas Schilling
bc24c78e06 [ticket/13117] Correctly define auto increment columns as "NOT NULL" on mysql
Unintended change from 95ab4b3e931521ce3c56068478311f0c04f713cc

PHPBB3-13117
2014-09-29 20:48:47 +02:00
Joas Schilling
f87831aee5 [ticket/12710] Fix missing closing bracket
PHPBB3-12710
2014-08-09 15:04:49 +02:00
Joas Schilling
0806c74084 [ticket/12710] Prefix column so it does not start with a number
PHPBB3-12710
2014-08-09 14:42:31 +02:00
Joas Schilling
ef9360d285 [ticket/12710] Pass the original column data to the create function
PHPBB3-12710
2014-08-09 14:42:28 +02:00
Joas Schilling
37a1874782 [ticket/12710] Fix foreach generation
PHPBB3-12710
2014-08-09 14:41:25 +02:00
Joas Schilling
c8e7db60ba [ticket/12710] Compare to uppercase version
PHPBB3-12710
2014-08-09 13:34:22 +02:00
Joas Schilling
f03a003bea [ticket/12710] Do not try to match the uniqueness in the query
PHPBB3-12710
2014-08-09 13:14:08 +02:00
Joas Schilling
7d44995f16 [ticket/12710] Remove table_name from index_name before deleting and recreating them
PHPBB3-12710
2014-08-09 12:53:15 +02:00
Joas Schilling
078c68da63 [ticket/12710] Can not use upper in oracles where claus
PHPBB3-12710
2014-08-09 12:46:59 +02:00
Joas Schilling
12eb993d23 [ticket/12710] Correctly select index name and compare to column name
PHPBB3-12710
2014-08-09 08:54:40 +02:00
Joas Schilling
cdcfd1fe1e [ticket/12710] Fix problems with creating unique indexes on oracle
PHPBB3-12710
2014-08-09 08:28:44 +02:00
Joas Schilling
96fc29eecc [ticket/12710] Correctly fetch unique and normal indexes only in MSSQL
PHPBB3-12710
2014-08-09 08:27:10 +02:00
Joas Schilling
b39305b9f6 [ticket/12710] Fix changing the column type on oracle
PHPBB3-12710
2014-08-07 19:45:34 +02:00
Joas Schilling
339bf90ec2 [ticket/12710] Prepare get_existing_indexes() for other DBMS
PHPBB3-12710
2014-08-07 18:43:48 +02:00
Joas Schilling
9b36b5283c Merge pull request #2761 from Nicofuma/ticket/12873
[ticket/12873] Test the correct identifier in \phpbb\db\tools

* Nicofuma/ticket/12873:
  [ticket/12873] Add migration to rename the index
  [ticket/12873] Don not touch the existing migrations
  [ticket/12873] Test the good identifier in \phpbb\db\tools
2014-08-07 16:49:37 +02:00
Dhruv Goel
1c8357a1cb Merge pull request #2651 from nickvergessen/ticket/12448
[ticket/12448] Allow null as default value for columns
2014-07-22 00:08:07 +05:30
Tristan Darricau
919aeb3879 [ticket/12873] Test the good identifier in \phpbb\db\tools
We need to rename the index key because with the default prefix (phpbb_)
this key has a length of 31. And because we don't accept the keys longer
than 30 characters we should ensure that by default no key is longer than
30 characters.

PHPBB3-12873
2014-07-20 23:15:34 +02:00
Tristan Darricau
ff6e026a40 [ticket/12446] Unnecessary db connect inphpbb_bootstrap_enabled_exts
PHPBB3-12446
2014-06-26 21:09:19 +02:00
Joas Schilling
4917ebe93a [ticket/12448] Fix null columns for MS SQL
PHPBB3-12448
2014-06-25 18:39:10 +02:00
Joas Schilling
b2044884ff [ticket/12448] Fix null columns for postgres
PHPBB3-12448
2014-06-25 18:37:46 +02:00
Joas Schilling
95ab4b3e93 [ticket/12448] Allow null as default value for columns
PHPBB3-12448
2014-06-25 13:40:32 +02:00
Joas Schilling
04164affe6 [ticket/12747] Drop support for Firebird
PHPBB3-12747
2014-06-20 12:35:42 +02:00
Patrick Webster
754e36e378 [ticket/12643] Properly handle changing columns on tables with constraints
PHPBB3-12643
2014-06-15 19:07:32 -05:00
BorisBerdichevski
2dc389c936 [ticket/12643] Ensure that similarly named columns are not removed
PHPBB3-12643
2014-06-15 14:15:42 -05:00
Yuriy Rusko
a759704b39 [ticket/12594] Remove @package tags and update file headers
PHPBB3-12594
2014-05-27 20:51:13 +02:00
Joas Schilling
ae3586869a [feature/sqlite3] Remove unneeded ORDER BY type from sqlite_master queries
PHPBB3-9728
2014-05-02 15:45:23 +02:00
Joas Schilling
fd37f63614 [feature/sqlite3] Correctly recreate indexes when recreating a table
PHPBB3-9728
2014-05-02 15:45:22 +02:00
Joas Schilling
b5267d97f4 [feature/sqlite3] Fix sql_index_drop() for sqlite3
PHPBB3-9728
2014-05-02 15:45:22 +02:00
Joas Schilling
07042e484e [feature/sqlite3] Remove trailing comma from column list
PHPBB3-9728
2014-05-02 15:45:21 +02:00
Patrick Webster
b39b0369aa [feature/sqlite3] Add support for SQLite 3
Minimum version requirement is 3.6.15 as that's what ships with PHP 5.3.0
when support for SQLite 3 was added.

PHPBB3-9728
2014-05-02 15:45:20 +02:00
Joas Schilling
d5ea4906ca [ticket/12012] Move property to the top
PHPBB3-12012
2014-04-24 22:57:35 +02:00
Joas Schilling
bbc2e6c7b2 [ticket/12012] Move MS SQL server comparison into a method
PHPBB3-12012
2014-04-24 14:53:33 +02:00
Joas Schilling
0a953ddb15 [ticket/12012] Remove duplicated code (only the $sql are different)
PHPBB3-12012
2014-04-20 12:54:19 +02:00
Joas Schilling
7dc163f2b7 [ticket/12012] Drop and recreate indexes when removing columns
PHPBB3-12012
2014-04-17 11:35:09 +02:00
Joas Schilling
190b4282df [ticket/12012] Return SQL statements for index drop/create
Otherwise we recreate the index before changing the column

PHPBB3-12012
2014-04-17 11:29:44 +02:00
Joas Schilling
e2784d01ce [ticket/12012] Fix tools::mssql_get_existing_indexes() for SQL Server 2000
PHPBB3-12012
2014-04-17 11:29:44 +02:00
Joas Schilling
9036cdaaa2 [ticket/12012] Drop and recreate indexes when changing a column on MSSQL
PHPBB3-12012
2014-04-17 11:29:43 +02:00
Joas Schilling
29ba06968d [ticket/12012] Fix query layout
PHPBB3-12012
2014-04-17 11:29:42 +02:00
Joas Schilling
743d816631 [ticket/12012] Correctly drop default value constraints on MSSQL
We need to drop the default constraints of a column,
before being able to change their type or deleting them.

PHPBB3-12012
2014-04-17 11:29:42 +02:00
Andreas Fischer
41db97ad3a Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12397] Fix sql_unique_index_exists doc block
2014-04-15 23:59:56 +02:00
Joas Schilling
11a9104b8a [ticket/12282] Use interface for type hinting
PHPBB3-12282
2014-04-01 19:17:41 +02:00
Oliver Schramm
55c1b49bed [ticket/12330] Fix create index in db tools on mssql
PHPBB3-12330
2014-03-30 15:42:04 +02:00
Joas Schilling
70a2110223 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/9725] Code sniffer fixes
  [ticket/9725] Do not use deprecated views to remove default constraints
  [ticket/9725] Move primary key creation to the correct location
  [ticket/9725] Remove trailing spaces from MSSQL schema
  [ticket/9725] Create MSSQL primary keys if none exist
  [ticket/9725] Remove explicit filegroup designations
  [ticket/9725] Fetch Azure db stats from proper table
  [ticket/9725] Add dummy indexes for Azure
  [ticket/9725] Create an Azure SQL compatible Schema

Conflicts:
	phpBB/install/schemas/mssql_schema.sql
2014-03-29 10:50:18 +01:00