1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-07 16:15:22 +02:00

28 Commits

Author SHA1 Message Date
rxu
83f9838217
Merge branch 'ticket/17232' into ticket/17232-master 2023-12-20 15:58:15 +07:00
rxu
6a8140e82b
[ticket/17232] Improve SQL error messages handling
PHP 7 changes how most errors are reported by PHP. Instead of reporting errors
through the traditional error reporting mechanism used by PHP 5, most errors
are now reported by throwing Error exceptions.
Use it to display meaningful SQL error messages instead of PHP fatal errors
for SQL errors.

PHPBB3-17232
2023-12-20 15:07:14 +07:00
rxu
3e37770b61
Merge branch 'ticket/17142' into ticket/17142-master 2023-06-08 10:20:24 +07:00
rxu
7adee3c50d
[ticket/17142] Fix DBMS+cache related PHP warnings while installing
PHPBB3-17142
2023-06-08 00:59:32 +07:00
Marc Alexander
80e55b2ec8
Merge branch '3.3.x' 2023-04-11 22:22:26 +02:00
Marc Alexander
b5c316c9c3
[ticket/8071] Make nextid alias of sql_last_inserted_id and add deprecation
PHPBB3-8071
2023-01-31 17:17:42 +01:00
Marc Alexander
948023078b
[ticket/16955] Clean up code in db classes
PHPBB3-16955
2022-12-28 08:37:20 +01:00
lionel-rowe
9fb98201f2 [ticket/8071] Add sql_last_inserted_id alias for sql_nextid
Fixes [DBAL function sql_nextid - name is
misleading](https://tracker.phpbb.com/browse/PHPBB3-8071).

Per the tracker issue:
> This function gets the ID of the last inserted row, not the ID of the next row
to be inserted (which is difficult due to different autoincrement steps and also
lends itself nicely to race conditions).

@iwisdom replied that the naming is consistent with how PHP itself names this
functionality, but the link they posted doesn't support that (I guess this is
referring to a much older version of PHP? The comment is from 2009).

PHPBB3-8071
2022-04-26 15:03:42 +01:00
Tristan Darricau
ede9a6815a [ticket/16897] Ignores sqlite3 warnings when an explain query plan query fails
PHPBB3-16897
2021-10-28 21:52:03 +02:00
rxu
0bc9d87891
[ticket/16538] Add identifiers quoting
If reserved word is used as identifier, it must be quoted.
If alias is used elsewhere in SQL statement, it must be quoted.

PHPBB3-16535
PHPBB3-16538
2020-08-14 04:51:11 +07:00
Jakub Senko
139eb17bb7
[ticket/12624] Add debug.load_time parameter
PHPBB3-12624
2019-05-09 18:40:15 +02:00
Jakub Senko
b4d4336ef4
[ticket/12627] Add debug.sql_explain parameter
PHPBB3-12627
2019-05-09 18:29:22 +02:00
Marc Alexander
df53d40922 [ticket/14044] Automatically trigger rollback on insert in transaction
This will cause the sqlite3 driver to automatically rollback transactions
if an insert fails during a transaction. Other dbms trigger a rollback
inside the sql_error() function with a rollback command. However,
this manual rollback command might fail on sqlite3 due to ongoing queries.

With this change, sqlite3 itself will abort any ongoing queries and
initiate the rollback automatically. Since manually triggered rollbacks
will fail after the rollback was started automatically, we catch
exceptions output by the exec() command during rollback and any exception
that might be thrown by fetchArray() due to aborted queries.

PHPBB3-14044
2015-10-23 20:47:56 +02:00
Marc Alexander
e0d06ee83e [ticket/14044] Fix Sqlite error in tests
PHPBB3-14044
2015-10-23 11:46:03 +02:00
Tristan Darricau
23205ca0cc Merge branch '3.1.x'
* 3.1.x:
  [ticket/13423] Set busyTimeout on connect to prevent db locking
2015-09-09 11:01:03 +02:00
Marc Alexander
ea594d00f7 [ticket/13423] Set busyTimeout on connect to prevent db locking
PHPBB3-13423
2015-09-07 12:23:49 +02:00
Joas Schilling
489aba31c7 Merge branch 'develop-ascraeus' into develop
* develop-ascraeus:
  [ticket/12671] Possibility to use NOT LIKE expression
  [ticket/12671] Possibility to use NOT LIKE expression
  [ticket/12671] Possibility to use NOT LIKE expression
  [ticket/12671] Possibility to use NOT LIKE expression
  [ticket/12671] Possibility to use NOT LIKE expression
2014-08-10 13:35:37 +02:00
Geolim4
db0815f680 [ticket/12671] Possibility to use NOT LIKE expression
PHPBB3-12671
2014-08-09 19:11:21 +02:00
Geolim4
635cde218c [ticket/12671] Possibility to use NOT LIKE expression
PHPBB3-12671
2014-08-09 15:04:39 +02:00
Geolim4
01943adbf7 [ticket/12671] Possibility to use NOT LIKE expression
PHPBB3-12671
2014-08-08 18:32:17 +02:00
Joas Schilling
58d1dcc7f2 Merge pull request #2637 from Nicofuma/ticket/12387
[ticket/12387] Cleanup *_free_result call and remove @ on that call

* Nicofuma/ticket/12387:
  [ticket/12387] Fix a call to sql_freeresult in full_text_native
  [ticket/12387] Fix \phpbb\db\driver\mysqli::sql_freeresult
  [ticket/12387] Use the hash as query_id for caching
  [ticket/12387] Remove unnecessary checks
  [ticket/12387] mssql_query return true if a select query returns 0 row
  [ticket/12387] Cleanup *_free_result call and remove @ on that call
2014-08-07 12:09:01 +02:00
Tristan Darricau
42fde81b21 Merge pull request #2690 from Noxwizard/ticket/12802
[ticket/12802] Properly handle connection failures in SQLite3

* Noxwizard/ticket/12802:
  [ticket/12802] Properly handle connection failures in SQLite3
2014-07-07 21:56:35 +02:00
Patrick Webster
3ca708edad [ticket/12802] Properly handle connection failures in SQLite3
PHPBB3-12802
2014-07-03 13:05:54 -05:00
Tristan Darricau
2276c1c0f2 [ticket/12387] Cleanup *_free_result call and remove @ on that call
PHPBB3-12387
2014-06-22 18:16:21 +02:00
rxu
f850d5fa90 [ticket/12704] Improve the load time information in the footer when enabled
PR #2570 has added new constant to display load time information without
debug mode is being on (https://tracker.phpbb.com/browse/PHPBB3-12687).
This patch expands the total load time info with SQL/PHP load times,
while hiding the additional info with <abbr> element.

PHPBB3-12704
2014-06-20 20:57:32 +08:00
Yuriy Rusko
a759704b39 [ticket/12594] Remove @package tags and update file headers
PHPBB3-12594
2014-05-27 20:51:13 +02:00
Patrick Webster
8c2b80e3d2 [feature/sqlite3] Update docblocks and function visibility
Added missing docblock annotations and added visibility identifiers.

PHPBB3-9728
2014-05-02 15:45:21 +02:00
Patrick Webster
b39b0369aa [feature/sqlite3] Add support for SQLite 3
Minimum version requirement is 3.6.15 as that's what ships with PHP 5.3.0
when support for SQLite 3 was added.

PHPBB3-9728
2014-05-02 15:45:20 +02:00