Oleg Pudeyev
fe87d441ee
[ticket/11162] Review comments fixed.
...
PHPBB3-11162
2012-12-05 10:44:36 -05:00
Oleg Pudeyev
16966f52d3
[ticket/11162] Reformat.
...
PHPBB3-11162
2012-12-05 10:41:08 -05:00
Oleg Pudeyev
94ebc57078
[ticket/11162] Newlines to LF.
...
PHPBB3-11162
2012-12-05 10:40:42 -05:00
Oleg Pudeyev
1e50116c54
[ticket/10602] Avoid a race condition.
...
PHPBB3-10602
2012-12-05 00:57:24 -05:00
Oleg Pudeyev
03f819862f
[ticket/10602] Use last_queue_run for its intended purpose.
...
We keep the last queue run time around, therefore for determining
whether enough time has passed since the last run we can simply
use this config variable.
When there is no queue file we consider a queue run successful.
Previously queue.php ("cache file") modification time would be used
for determining whether enough time has passed since last queue run.
The problem was that modification time would be updated whenever
anything was added to the queue, creating a situation where if
queue is processed less frequently than it is added to that email
would not be sent.
PHPBB3-10602
2012-12-05 00:41:47 -05:00
Oleg Pudeyev
1a411c5658
[ticket/11162] Use correct functions.
...
PHPBB3-11162
2012-12-05 00:11:14 -05:00
Oleg Pudeyev
6872104aa9
[ticket/11162] Account for notify_status.
...
PHPBB3-11162
2012-12-05 00:07:01 -05:00
Oleg Pudeyev
abca64b1df
[ticket/11162] Add includes.
...
PHPBB3-11162
2012-12-04 23:37:14 -05:00
Oleg Pudeyev
0f96b1aad3
[ticket/11162] Move to a separate file to avoid blowing out functions.php.
...
PHPBB3-11162
2012-12-04 23:35:34 -05:00
Oleg Pudeyev
5120f36a25
[ticket/10205] Reduce nesting in mysql drivers.
...
PHPBB3-10205
2012-12-04 21:33:13 -05:00
Oleg Pudeyev
597dea1e04
[ticket/10205] Rewrite _sql_error implementations to have a single return.
...
PHPBB3-10205
2012-12-04 21:32:02 -05:00
Oleg Pudeyev
89c9c9d4b0
[ticket/10205] Cosmetic changes.
...
PHPBB3-10205
2012-12-04 21:22:33 -05:00
Oleg Pudeyev
dc521692f3
[ticket/10205] Check for function existence in mssql connect method.
...
PHPBB3-10205
2012-12-04 16:14:39 -05:00
Oleg Pudeyev
de2fe1a308
[ticket/10205] Convert mssqlnative driver to the same logic.
...
PHPBB3-10205
2012-12-04 16:12:31 -05:00
Oleg Pudeyev
40db60e45f
[ticket/10205] Fix a parse error in oracle driver.
...
PHPBB3-10205
2012-12-04 16:07:02 -05:00
Oleg Pudeyev
9f549e8249
[ticket/10205] Fix remaining db drivers.
...
PHPBB3-10205
2012-12-04 04:50:41 -05:00
Oleg Pudeyev
1a7e2211c3
[ticket/10205] Avoid calling mysqli functions when mysqli is missing.
...
PHPBB3-10205
2012-12-04 04:41:46 -05:00
Oleg Pudeyev
025a95ea90
[ticket/10205] Account for potentially missing extensions in dbal.
...
PHPBB3-10205
2012-12-04 04:40:47 -05:00
Oleg Pudeyev
6f7e39996c
[ticket/11238] Set goutte version to 0.1.0.
...
PHPBB3-11238
2012-12-02 23:44:49 -05:00
Oleg Pudeyev
2fc43e6ed7
[ticket/11162] No whitespace changes in olympus.
...
PHPBB3-11162
2012-12-01 23:11:14 -05:00
Oleg Pudeyev
05053dacd3
[ticket/11162] Fix inaccurately copy pasted comment.
...
PHPBB3-11162
2012-12-01 23:09:32 -05:00
Oleg Pudeyev
69225bd0a6
[ticket/11162] Use phpbb_update_rows_avoiding_duplicates in mcp.
...
PHPBB3-11162
2012-12-01 23:09:31 -05:00
Oleg Pudeyev
c2c105df9f
[ticket/11162] Clarify that only the two tables actually work.
...
PHPBB3-11162
2012-12-01 23:09:31 -05:00
Oleg Pudeyev
2e947334e5
[ticket/11162] Uncomment transactions.
...
PHPBB3-11162
2012-12-01 23:09:31 -05:00
Oleg Pudeyev
d0338531cb
[ticket/11162] An implementation that actually works.
...
PHPBB3-11162
2012-12-01 23:09:29 -05:00
Oleg Pudeyev
ae14ac7ba9
Merge PR #893 branch 'nickvergessen/ticket/10184' into develop-olympus
...
* nickvergessen/ticket/10184:
[ticket/10184] Query bots table to get the user_ids of the bots
[ticket/10184] Disable receiving pms for bots by default
2012-12-01 04:55:00 -05:00
Joas Schilling
ad2d560f3f
[ticket/10184] Query bots table to get the user_ids of the bots
...
PHPBB3-10184
2012-12-01 10:54:26 +01:00
Joas Schilling
314462d835
[ticket/10184] Disable receiving pms for bots by default
...
PHPBB3-10184
2012-12-01 10:54:16 +01:00
Oleg Pudeyev
65253a3023
[ticket/11227] @return void -> @return null in develop-olympus.
...
PHPBB3-11227
2012-11-29 15:37:12 -05:00
Oleg Pudeyev
af5d8b502e
Merge PR #1074 branch 'bantu/ticket/11192' into develop-olympus
...
* bantu/ticket/11192:
[ticket/11192] Merge dataProvider arrays because the test is the same now.
[ticket/11192] Update $value parameter description to support other types.
[ticket/11192] Mark negative byte numbers as unsupported.
[ticket/11192] Test strings not converted to int/float before.
[ticket/11192] Also test strings, e.g. sums returned by the database.
[ticket/11192] Also test powers of 10 / 1000.
[ticket/11192] Add tests.
[ticket/11192] Add Tebibyte to get_formatted_filesize().
2012-11-16 10:25:06 -05:00
Andreas Fischer
efd6f1df63
[ticket/11192] Update $value parameter description to support other types.
...
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Andreas Fischer
7cbd440e7a
[ticket/11192] Mark negative byte numbers as unsupported.
...
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Marc Alexander
170967c48a
[ticket/10879] Remove arrow icon from attachment link in editor
...
If you upload a file with a long filename the filename will partially
cover the arrow icon background image. Remove the icon as it's not needed
anyways.
PHPBB3-10879
2012-11-13 20:26:49 +01:00
Andreas Fischer
c699b88bc5
[ticket/11192] Add Tebibyte to get_formatted_filesize().
...
PHPBB3-11192
2012-11-11 14:35:31 +01:00
Oleg Pudeyev
3ebabc8da2
Merge PR #1052 branch 'p/ticket/10865' into develop-olympus
...
* p/ticket/10865:
[ticket/10865] Use code tags for install/database_update.php.
[ticket/10865] Should have been a slash.
[ticket/10865] Add .css, .js, and .htaccess to the list of ASCII mode files
[ticket/10865] Phrase change for visiting with browser
[ticket/10865] Grammar corrections for the entire document
[ticket/10865] Typo and phrasing change
[ticket/10865] Updates and additions to /docs/INSTALL.html
2012-11-09 20:14:52 -05:00
Oleg Pudeyev
7c4318c033
[ticket/10865] Use code tags for install/database_update.php.
...
PHPBB3-10865
2012-11-09 20:13:06 -05:00
Oleg Pudeyev
6e6cc28b76
[ticket/10865] Should have been a slash.
...
PHPBB3-10865
2012-11-09 20:10:43 -05:00
Nils Adermann
0209431e4f
Merge remote-tracking branch 'github-igorw/ticket/11181-olympus' into develop-olympus
...
* github-igorw/ticket/11181-olympus:
[ticket/11181] Bump PHP requirement to 5.3.3 (from 5.3.2) [develop-olympus]
2012-11-09 23:46:51 +01:00
Igor Wiedler
923137cf31
[ticket/11181] Bump PHP requirement to 5.3.3 (from 5.3.2) [develop-olympus]
...
PHPBB3-11181
2012-11-09 23:22:02 +01:00
Oleg Pudeyev
a16b9d17da
Merge PR #1044 branch 'bantu/ticket/11178' into develop-olympus
...
* bantu/ticket/11178:
[ticket/11178] Do not set error_reporting to E_ALL in database_updater.php
2012-11-09 09:57:33 -05:00
Andreas Fischer
ed74c9c487
[ticket/11178] Do not set error_reporting to E_ALL in database_updater.php
...
Take whatever startup.php sets instead.
This especially takes care of E_STRICT messages that are generated because of
PHP4 compatibility.
PHPBB3-11178
2012-11-09 14:30:44 +01:00
Andreas Fischer
60ea1c10ef
[ticket/10897] Combine bot updates and bot delete.
...
PHPBB3-10897
2012-11-09 13:40:48 +01:00
Andreas Fischer
54700f5ba2
[ticket/10897] Use same code/query for deleting.
...
PHPBB3-10897
2012-11-09 12:53:33 +01:00
Andreas Fischer
520ffdf368
[ticket/10897] Make sure the user we're fetching is a bot.
...
PHPBB3-10897
2012-11-09 12:47:50 +01:00
Andreas Fischer
c054757f3c
[ticket/10897] Do not handle IP address. There is no need.
...
PHPBB3-10897
2012-11-09 12:46:21 +01:00
Andreas Fischer
63c64694bc
[ticket/10897] Update by user_id instead of bot_name.
...
PHPBB3-10897
2012-11-09 12:41:59 +01:00
Andreas Fischer
935bc33268
[ticket/10897] Move bot delete data to the relevant foreach loop.
...
PHPBB3-10897
2012-11-09 12:19:58 +01:00
Andreas Fischer
de6d741d96
[ticket/10897] Add comment about what's going on.
...
PHPBB3-10897
2012-11-09 12:19:18 +01:00
Andreas Fischer
b2183c9b70
[ticket/10897] Remove unnecessary string casting.
...
PHPBB3-10897
2012-11-09 12:16:38 +01:00
Andreas Fischer
07e7c475d5
[ticket/10897] Add space after foreach.
...
PHPBB3-10897
2012-11-09 12:16:38 +01:00