mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-30 19:24:13 +02:00
Code Issues Releases Wiki Activity
17,001 Commits 18 Branches 192 Tags
Commit Graph

86 Commits

Author SHA1 Message Date
Vjacheslav Trushkin
3e64c1b5d7 [ticket/11010] Fixes for number input in acp 
PHPBB3-11010
 2013-05-20 18:42:11 +02:00
Nathan Guse
14f1340903 [ticket/11335] (avatars) Make php_ext 'php' not '.php' 
PHPBB3-11335
 2013-04-24 17:45:46 -05:00
Marc Alexander
bb58462724 [ticket/11404] Use a default data row if $row is empty in clean_row() 
A statically defined $default_row will be used inside the
phpbb_avatar_manager::clean_row() method if the $row passed to it is
empty.

PHPBB3-11404
 2013-03-07 13:03:27 +01:00
Marc Alexander
5963905825 [ticket/11404] Return empty array of avatar data if $row is empty 
While creating a group in the acp, the group data ($group_row) is empty.
Due to that array_combine in phpbb_avatar_manager::clean_row() will cause
PHP Warnings. In addition to that the required indexes 'avatar',
'avatar_width', 'avatar_height', and 'avatar_type' won't be defined. This
patch will solve that issue.

PHPBB3-11404
 2013-03-06 11:32:23 +01:00
Marc Alexander
3cc4746ad3 [feature/avatars] Use "Main" as category for avatars in root of gallery 
Before this change the whole avatar gallery path would show as category.
Additionally, the avatars that were selected like that had an incorrect
path and didn't show up correctly.
With this patch it'll display "Main" as category and properly work.

PHPBBB3-10018
 2013-02-19 12:45:08 +01:00
Marc Alexander
a9e0aea4b1 [feature/avatars] Remove trailing whitespace from avatar code 
PHPBB3-10018
 2013-02-19 12:30:14 +01:00
Marc Alexander
2302cd7a42 [feature/avatars] Pass phpbb_user to prepare and process form functions 
The phpbb_user object might be used for language variables and other
things.

PHPBB3-10018
 2013-02-19 12:24:21 +01:00
Marc Alexander
f09e6865f7 [feature/avatars] Document the use of the allowed extensions array 
PHPBB3-10018
 2013-02-13 01:07:02 +01:00
Marc Alexander
5a4da46f9b [feature/avatars] Use array for allowed extensions and implode if needed 
PHPBB3-10018
 2013-02-07 00:08:53 +01:00
Marc Alexander
f322f4eac9 [feature/avatars] Correct license, copyright and package info 
PHPBB3-10018
 2013-02-03 23:02:35 +01:00
Marc Alexander
9c3538eb0e [feature/avatars] Move list of supported formats to avatar driver class 
Using the regex and turning it into an array if necessary seemed like the
cleanest approach to achieve this.

PHPBB3-10018
 2013-01-25 01:24:15 +01:00
Marc Alexander
7402add107 [feature/avatars] Add missing @var to docblocks in avatar manager 
PHPBB3-10018
 2013-01-09 15:50:15 +01:00
Marc Alexander
cb08bf3c0c [feature/avatars] Strictly check if avatar list is empty and cache result 
PHPBB3-10018
 2013-01-08 21:46:43 +01:00
Marc Alexander
9e001153d6 [feature/avatars] Pass phpbb_user object to prepare_form_acp() 
The phpbb_user object might be used for language variables. Pass it as a
function argument to prepare_form_acp() instead of using globals.

PHPBB3-10018
 2013-01-08 15:42:30 +01:00
Marc Alexander
8778c9c945 [feature/avatars] Pass phpbb_user object to get_custom_html() 
Pass the phpbb_user object to function get_custom_html(). This object is
used in that method. Also fixed incorrect arguments to get_custom_html()
in phpbb_get_avatar().

PHPBB3-10018
 2013-01-08 15:34:20 +01:00
Marc Alexander
023d7a972d [feature/avatars] Remove $request property and pass as argument if needed 
Remove the $request property from the phpbb_avatar_driver class and rather
pass it as function argument if it's needed in a function. Currently this
is only the case for the class methods prepare_form() and process_form().

PHPBB3-10018
 2013-01-07 23:02:07 +01:00
Marc Alexander
41710c745d [feature/avatars] Add function for localizing errors 
PHPBB3-10018
 2013-01-06 21:09:07 +01:00
Marc Alexander
111e02395c [feature/avatars] Add missing docblocks to avatar manager 
PHPBB3-10018
 2013-01-05 20:17:53 +01:00
Marc Alexander
8f8527a416 [feature/avatars] Improve handling of incorrect input for avatars 
The upload avatar driver will now inform the user if insufficient data has
been entered for both remote and local avatar uploads.
The local avatar driver (gallery avatar) will also inform the user if he
didn't select a category and/or file before submitting.

PHPBB3-10018
 2013-01-04 17:32:04 +01:00
Marc Alexander
8e756ad890 [feature/avatars] Let the server handle http or https for gravatars 
PHPBB3-10018
 2012-12-27 21:40:35 +01:00
Marc Alexander
6f41228752 [feature/avatars] Add missing explanation to docblock of get_all_drivers() 
PHPBB3-10018
 2012-12-27 20:46:07 +01:00
Marc Alexander
c865f98dcf [feature/avatars] Some more miscellaneous changes 
PHPBB3-10018
 2012-12-27 20:42:05 +01:00
Marc Alexander
e6aaef6066 [feature/avatars] Use callback method in avatar manager's clean row 
PHPBB3-10018
 2012-12-17 12:56:04 +01:00
Marc Alexander
2f47c99432 [feature/avatars] Add more consistency to codebase 
PHPBB3-10018
 2012-12-11 21:02:37 +01:00
Marc Alexander
fb139a8820 [feature/avatars] Fix behavior of avatar manager and variables 
The $force_all variable was only partially removed and the behavior was
not consistent in all files.

PHPBB3-10018
 2012-12-04 15:12:04 +01:00
Marc Alexander
8aaa3e055f [feature/avatars] Use seperate function for retrieving the config name 
PHPBB3-10018
 2012-12-04 15:11:14 +01:00
Marc Alexander
fc4069f81d [feature/avatars] Use seperate function for retrieving all drivers 
PHPBB3-10018
 2012-12-04 00:59:37 +01:00
Marc Alexander
215ac6a0da [feature/avatars] Removed unneeded dependencies 
PHPBB3-10018
 2012-12-01 21:28:44 +01:00
Marc Alexander
d439f47710 [feature/avatars] Fix docblocks and minor cosmetic issues 
PHPBB3-10018
 2012-12-01 00:27:52 +01:00
Marc Alexander
081440f6c4 [feature/avatars] Create setting for enabling avatar in manager 
PHPBB3-10018
 2012-11-30 23:11:44 +01:00
Marc Alexander
33b98dc5ba [feature/avatars] Fix variable names 
PHPBB3-10018
 2012-11-30 16:46:11 +01:00
Marc Alexander
d5cbedaaa2 [feature/avatars] Let avatar manager handle $ignore_config 
The avatar manager already handles if avatars are enabled. It should also
handle ignoring the config settings.

PHPBB3-10018
 2012-11-30 15:12:34 +01:00
Marc Alexander
f4ad60e2cf [feature/avatars] Get list of enabled drivers from avatar manager 
This shouldn't be done in the avatar drivers. We need to force the
display all avatar drivers in the ACP or it won't be possible to enable
avatars after they have been disabled.

PHPBB3-10018
 2012-11-30 01:07:10 +01:00
Marc Alexander
81a1a21185 [feature/avatars] Properly implement custom HTML in the interface 
Previously the driver class added a variable that defined wether an avatar
driver would return custom HTML. The existence of this variable was
implied in the interface. It's also not needed which is why it has been
removed.

PHPBB3-10018
 2012-11-29 23:08:29 +01:00
Marc Alexander
cb1d98ab7f [feature/avatars] Check for existing functions rather than using _once 
PHPBB3-10018
 2012-11-26 23:06:38 +01:00
Marc Alexander
f851d763f9 [feature/avatars] Even more fixes to docblocks 
PHPBB3-10018
 2012-11-25 21:14:05 +01:00
Marc Alexander
6522190ff1 [feature/avatars] Docblock fixes and small change for php_ext 
PHPBB3-10018
 2012-11-25 20:50:31 +01:00
Marc Alexander
06639729ea [feature/avatars] Add static methods for handling driver names 
PHPBB3-10018
 2012-11-25 16:05:57 +01:00
Marc Alexander
ce5e2f1677 [feature/avatars] Miscellaneous fixes 
PHPBB3-10018
 2012-11-25 01:18:27 +01:00
Marc Alexander
ce44e3908e [feature/avatars] Remove unnecessary abbreviations 
PHPBB3-10018
 2012-11-25 00:54:34 +01:00
Marc Alexander
8a01bc1718 [feature/avatars] Use RecursiveDirectoryIterator for gallery avatar 
RecursiveDirectoryIterator is now used for populating the avatar list
array of the gallery avatar.

PHPBB3-10018
 2012-11-21 21:42:42 +01:00
Marc Alexander
24ac039336 [feature/avatars] Get rid of array_keys() in gallery avatar 
PHPBB3-10018
 2012-11-21 20:01:50 +01:00
Marc Alexander
01b313ea26 [feature/avatars] Use isset() instead of in_array() 
PHPBB3-10018
 2012-11-21 19:20:39 +01:00
Marc Alexander
8c782122c1 [feature/avatars] Use in_array() and fix tabbing 
PHPBB3-10018
 2012-11-21 17:24:02 +01:00
Marc Alexander
726d1a16d7 [feature/avatars] Move avatar specific settings to drivers 
PHPBB3-10018
 2012-11-21 17:15:35 +01:00
Marc Alexander
9b61204a17 [feature/avatars] Check if gravatar is within min/max width/height 
PHPBB3-10018
 2012-11-21 16:27:20 +01:00
Marc Alexander
b7b14f9a05 [feature/avatars] Use constant for URL and fix usage of getimagesize 
We now use a constant for the gravatar URL. Additionally the usage of
getimagesize() was reduced. It should only be run if the user didn't
specify both the width and height of the avatar.

PHPBB3-10018
 2012-11-21 16:20:14 +01:00
Marc Alexander
858c59279c [feature/avatars] Use protected instead of private 
PHPBB3-10018
 2012-11-19 23:50:34 +01:00
Marc Alexander
8d0c667dce [feature/avatars] Fix the docs and small naming fixes 
PHPBB3-10018
 2012-11-19 00:30:18 +01:00
Marc Alexander
bea6e845d3 [feature/avatars] Use https for gravatar 
PHPBB3-10018
 2012-11-19 00:27:22 +01:00