1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 20:13:22 +01:00

454 Commits

Author SHA1 Message Date
Joas Schilling
d3f9a51709 [ticket/12016] Use a service provider for event listeners
This allows them to use dependency injection

PHPBB3-12016
2013-11-13 17:34:06 +01:00
Joas Schilling
0a7db81426 [ticket/11997] Fix redirects from inside controllers
The redirect url currently uses the web root path. However as we prepend the
full board url later, we need to remove the relative web root path and prepend
the normal root path again. Otherwise redirects from inside routes will not
work as intended.

PHPBB3-11997
2013-11-13 11:30:13 +01:00
Marc Alexander
e380eed78e [ticket/11912] Remove obsolete variable $mimetype from content_guesser
PHPBB3-11912
2013-11-12 00:35:52 +01:00
Nils Adermann
592c8b7566 Merge pull request #1849 from bantu/ticket/11998
[ticket/11998] Introduction of the phpBB Console
2013-11-11 15:02:03 -08:00
Marc Alexander
9d4893b047 [ticket/11912] Remove IN_PHPBB checks from mimetype guesser files
PHPBB3-11912
2013-11-11 21:29:11 +01:00
Marc Alexander
81caa35955 [ticket/11912] Remove obsolete $file_info from plupload
PHPBB3-11912
2013-11-11 21:24:44 +01:00
Marc Alexander
bef6a5a640 [ticket/11912] Introduce guesser priority to mimetype guessers
The mimetype guesser priority can now be set through the service definition.
Mimetypes will be guessed from the guesser with the highest priority to
the one with the lowest priority. Standard priority types have been added
to the service definition file. Any integer value can be used though.
Standard mimetype guessers that do not have the methods get_priority
and set_priority implemented, like the standard MimeTypeGuessers of symfony,
will have the default priority with the value of 0. Lower priority guessers
have values lower than 0 while high priority ones can be added with values
higher than 0.

PHPBB3-11912
2013-11-11 21:18:23 +01:00
Marc Alexander
b1719db47d [ticket/11912] Add extension_guesser for guessing mimetype by extension
The content_guesser now only guesses the mimetype with the function
mime_content_type() while the guessing by extension is done using the
extension_guesser.

PHPBB3-11912
2013-11-11 20:15:28 +01:00
Joas Schilling
cfb0a41030 Merge remote-tracking branch 'EXreaction/ticket/11943' into develop
* EXreaction/ticket/11943:
  [ticket/11943] New line at EOF for define_error.html
  [ticket/11943] Forgot template file for test
  [ticket/11943] Throw an exception if DEFINE is setup improperly
  [ticket/11943] Split fix_inline_variable_tokens into 3 steps
  [ticket/11943] Require stricter DEFINE statements for templates
  [ticket/11943] Do not quote the value when it is exactly true, false, or null
  [ticket/11943] Add test for DEFINE $VAR = false
2013-11-11 18:23:37 +01:00
Joas Schilling
aa84f7de04 [ticket/11525] Prefix id parameter with 'g' again when its a group avatar
PHPBB3-11525
2013-11-10 23:20:48 +01:00
Joas Schilling
47f2caff6b [ticket/11525] Fix doc blocks
PHPBB3-11525
2013-11-10 22:20:15 +01:00
Nathan Guse
2e5117a71e [ticket/11943] Throw an exception if DEFINE is setup improperly
PHPBB3-11943
2013-11-09 11:14:55 -06:00
Joas Schilling
31e60f0c8d [ticket/11949] Do not prepend leading backslash to cache class name
The container seems to prepend the leading \ itself, so we get an
InvalidArgumentException with message '"'\\phpbb\\cache\\driver\\file'" is
not a valid class name for the "cache.driver" service.'

PHPBB3-11949
2013-11-09 17:06:38 +01:00
Joas Schilling
7344024b10 Merge remote-tracking branch 'dhruv/ticket/12007' into develop
* dhruv/ticket/12007:
  [ticket/12007] Default last_result to 0 instead of false
2013-11-09 15:53:29 +01:00
Nathan Guse
6370970f13 [ticket/11943] Split fix_inline_variable_tokens into 3 steps
DEFINE shouldn't add/remove surrounding quotes, but must have the inline
variable tokens fixed

PHPBB3-11943
2013-11-08 22:30:58 -06:00
Nathan Guse
da332aa0a5 [ticket/11943] Require stricter DEFINE statements for templates
PHPBB3-11943
2013-11-08 19:55:16 -06:00
Lukasz
a353673e7c [ticket/12005] Remove PM popup module from DB
PHPBB3-12005
2013-11-08 21:57:12 +01:00
Lukasz
65fbf87ce7 [ticket/12005] Remove PM popup
PHPBB3-12005
2013-11-08 21:57:08 +01:00
Dhruv
1173adfe87 [ticket/12007] Default last_result to 0 instead of false
PostgreSQL does not map null/false to 0 and thus this variable causes
an error.

PHPBB3-12007
2013-11-08 23:34:49 +05:30
Joas Schilling
6f33954757 [ticket/11922] Drop all keys before trying to delete columns to avoid issues
On MSSQL columns that have an index can not be dropped.

PHPBB3-11922
2013-11-08 17:45:48 +01:00
Andreas Fischer
00294e3dae [ticket/11998] Turn develop/extensions.php into console commands.
PHPBB3-11998
2013-11-05 21:40:42 +01:00
Andreas Fischer
73ea5daf97 [ticket/11998] Add phpBB abstraction for application and command.
PHPBB3-11998
2013-11-05 19:42:34 +01:00
Nathan Guse
cc54e6a9e5 Merge pull request #1819 from marc1706/ticket/11534
[ticket/11534] Check remote avatar content type if possible
2013-11-04 10:22:28 -08:00
Nathan Guse
b49d3a1851 [ticket/11943] Do not quote the value when it is exactly true, false, or null
Quoting these can change the meaning of the value (e.g. 'false' == true)

PHPBB3-11943
2013-11-04 12:21:12 -06:00
Andreas Fischer
743a0560c3 [ticket/11998] Add console command for recalculating email hash.
PHPBB3-11998
2013-11-03 13:02:48 +01:00
Cesar G
66c08de4cb [ticket/11746] The IN_PHPBB check is not necessary.
PHPBB3-11746
2013-11-02 13:50:09 -07:00
Nathan Guse
0a3bb18e93 Merge pull request #1812 from prototech/ticket/11746
[ticket/11746] Add "admin activation required" notification.
2013-11-02 11:55:16 -07:00
Joas Schilling
414a4d587e [ticket/11995] Fix Revert of config.remove
PHPBB3-11995
2013-11-02 18:13:11 +01:00
Andreas Fischer
ae7ef3e09d [task/code-sniffer] Remove class result_mssqlnative.
PHPBB3-11980
2013-10-31 00:48:03 +01:00
Andreas Fischer
ef1f991837 [task/code-sniffer] Replace spaces with tabs.
PHPBB3-11980
2013-10-30 13:37:29 +01:00
Andreas Fischer
7aa8f6461f [task/code-sniffer] Remove the IN_PHPBB check side-effect from class files.
PHPBB3-11980
2013-10-30 13:05:28 +01:00
Andreas Fischer
02e9f6e284 [task/code-sniffer] Fix argument list spacing.
PHPBB3-11980
2013-10-29 23:38:05 +01:00
Marc Alexander
7f58a4572e [ticket/11981] Fix code sniffer complaints
PHPBB3-11981
2013-10-28 23:05:46 +01:00
Marc Alexander
b2f638b793 [ticket/11857] Use passed service collection instead of container in manager
The service collection that was already passed to the avatar manager should
be used in the avatar manager method get_driver() instead of the container
itself.

PHPBB3-11857
2013-10-27 15:08:58 +01:00
Marc Alexander
9b0b5481fe [ticket/11534] Check remote avatar content type if possible
This should make sure that error pages like 404 or 503 pages are not treated
as remote avatar images.

PHPBB3-11534
2013-10-24 23:43:40 +02:00
Marc Alexander
9d4d212e0f [ticket/11525] Only remove group or user prefix from given avatar data
Until now, the user data had both user_id and group_id keys in the avatar
data. As both group_ and user_ prefixes were removed the group_id was
collapsed onto the user_id and therefore all users in the same group had
the same prefix for their uploaded avatars. This patch will make sure
that the correct id is used depending on whether it's a group's or user's
avatar data.

PHPBB3-11525
2013-10-24 13:55:23 +02:00
Marc Alexander
d25ab02ef3 [ticket/11912] Introduce guesser_interface
This will contain proper documentation of the required methods if anyone
would implement a newer guesser.

PHPBB3-11912
2013-10-24 12:07:26 +02:00
Marc Alexander
bc7ff47537 [ticket/11912] Supply filename to content_guesser for guessing on windows
The filename of the files sent to the guesser by plupload do not contain
the file extension. Therefore, it's impossible to guess the mimetype if
only the content_guesser is available and the function mime_content_type()
doesn't exist. By supplying the filename we can circumvent this issue.

PHPBB3-11912
2013-10-24 12:05:00 +02:00
Marc Alexander
24099583a3 [ticket/11912] Remove typo in content_guesser
PHPBB3-11912
2013-10-24 12:03:46 +02:00
Marc Alexander
973682cb2d [ŧicket/11912] Get rid of obsolete variables in content_guesser
PHPBB3-11912
2013-10-24 12:03:28 +02:00
Cesar G
d607f1c927 [ticket/11746] Add "admin activation required" notification.
PHPBB3-11746
2013-10-24 02:37:20 -07:00
Marc Alexander
4af6270d0f [ticket/11912] Improve extension map in content_guesser
PHPBB3-11912
2013-10-24 11:28:49 +02:00
Marc Alexander
63945f3687 [ticket/11912] Add content_guesser
The content_guesser will try to use the function mime_content_type()
if it's available. If that is not the case, the content_guesser will try to
guess the mimetype using the file extension of the supplied file.
Since this guesser will be registered after the other guessers, it will
be only used if the other guessers are not available.

PHPBB3-11912
2013-10-23 23:18:22 +02:00
Marc Alexander
36d314e032 [ticket/11912] Add phpbb mimetype guesser
Mimetype guesser will be used as front-end file for mimetype guessing.

PHPBB3-11912
2013-10-23 18:34:35 +02:00
Marc Alexander
789d493595 [ticket/11912] Integrate mimetype guesser with plupload
PHPBB3-11912
2013-10-23 18:34:06 +02:00
Nils Adermann
a7e41b23fd Merge pull request #1801 from nickvergessen/ticket/11948
Ticket/11948 Extensions should be allowed to have more then 1 routing file
2013-10-22 00:29:20 -07:00
Joas Schilling
51561ed538 [ticket/11948] Allow resource importing for routing
PHPBB3-11948
2013-10-21 21:52:48 +02:00
Marc Alexander
a80d5c93e3 [ticket/11930] Update docblock of avatar driver constructor
PHPBB3-11930
2013-10-21 11:02:59 +02:00
Marc Alexander
acbb1ed3ee [ticket/11930] Modify order of properties to fit constructor method
PHPBB3-11930
2013-10-21 10:47:40 +02:00
Marc Alexander
d7bf50bc80 [ticket/11930] Move path_helper in front of optional cache argument
Optional method arguments should be after any mandatory ones.

PHPBB3-11930
2013-10-21 10:20:12 +02:00