1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-25 04:23:38 +01:00

2011 Commits

Author SHA1 Message Date
Joas Schilling
632d6e9621 [ticket/12023] Add test for failing .css copy
PHPBB3-12023
2013-11-19 00:23:23 +01:00
Marc Alexander
7f10312bf2 [ticket/11896] Correctly document return of null in docblocks
Also got rid of previous incorrect comment in docblocks.

PHPBB3-11896
2013-11-14 15:17:25 +01:00
Marc Alexander
308329b547 [ticket/11896] Minor code improvements in phpbb_functional_test_case
Use assertContainsLang() and get rid of unnecessary logic in create_post()
and create_topic(). The docblocks were also slightly improved.

PHPBB3-11896
2013-11-14 15:09:49 +01:00
Cesar G
287c2550b8 [ticket/12008] Update the run time value for the prune notifications cron task
PHPBB3-12008
2013-11-14 01:05:58 -08:00
David King
8fd1f90e5f Merge pull request #1872 from nickvergessen/ticket/12017
Ticket/12017 Extension tests are broken on current develop
2013-11-13 16:34:32 -08:00
Joas Schilling
1e73e0c954 [ticket/12017] Fix phpbb requirement in composer.json
PHPBB3-12017
2013-11-14 00:15:23 +01:00
Joas Schilling
4e2bb6ef53 [ticket/12017] Copy config/ dir so events work
PHPBB3-12017
2013-11-14 00:14:53 +01:00
Joas Schilling
009a1303f5 [ticket/12017] Remove IN_PHPBB defined check
PHPBB3-12017
2013-11-14 00:14:04 +01:00
Nils Adermann
52845b22f2 Merge pull request #1815 from marc1706/ticket/11525
[ticket/11525] Only remove group or user prefix from given avatar data
2013-11-13 09:52:21 -08:00
Marc Alexander
13a4ceedb1 [ticket/11525] Use foreach instead of array_walk in method clean_row()
This approach is cleaner and probably even faster the previous ways that
included using array_walk() or array_map() and other helper functions
and methods.

PHPBB3-11525
2013-11-13 18:27:40 +01:00
Nils Adermann
e48b2c07eb Merge pull request #1871 from nickvergessen/ticket/12016
Ticket/12016 Event listeners should be services
2013-11-13 08:45:48 -08:00
Joas Schilling
fbf5911ac5 [ticket/12016] Update functional tests to use service for event listeners
PHPBB3-12016
2013-11-13 17:38:58 +01:00
Joas Schilling
a0fca0acc2 [ticket/11997] Add functional test for redirects in controller
PHPBB3-11997
2013-11-13 16:30:20 +01:00
Marc Alexander
d43542a434 [ticket/11997] Use $phpbb_filesystem->clean_path() for proper redirect paths
PHPBB3-11997
2013-11-12 00:46:43 +01:00
Marc Alexander
95b22819a7 [ticket/11912] Use inverted $overload for setting function_exists in tests
PHPBB3-11912
2013-11-11 21:59:47 +01:00
Marc Alexander
bef6a5a640 [ticket/11912] Introduce guesser priority to mimetype guessers
The mimetype guesser priority can now be set through the service definition.
Mimetypes will be guessed from the guesser with the highest priority to
the one with the lowest priority. Standard priority types have been added
to the service definition file. Any integer value can be used though.
Standard mimetype guessers that do not have the methods get_priority
and set_priority implemented, like the standard MimeTypeGuessers of symfony,
will have the default priority with the value of 0. Lower priority guessers
have values lower than 0 while high priority ones can be added with values
higher than 0.

PHPBB3-11912
2013-11-11 21:18:23 +01:00
Marc Alexander
b1719db47d [ticket/11912] Add extension_guesser for guessing mimetype by extension
The content_guesser now only guesses the mimetype with the function
mime_content_type() while the guessing by extension is done using the
extension_guesser.

PHPBB3-11912
2013-11-11 20:15:28 +01:00
Nathan Guse
d69f35d450 Merge pull request #1853 from nickvergessen/ticket/11927
[ticket/11927] Correctly add new files on update
2013-11-11 09:40:50 -08:00
Joas Schilling
cfb0a41030 Merge remote-tracking branch 'EXreaction/ticket/11943' into develop
* EXreaction/ticket/11943:
  [ticket/11943] New line at EOF for define_error.html
  [ticket/11943] Forgot template file for test
  [ticket/11943] Throw an exception if DEFINE is setup improperly
  [ticket/11943] Split fix_inline_variable_tokens into 3 steps
  [ticket/11943] Require stricter DEFINE statements for templates
  [ticket/11943] Do not quote the value when it is exactly true, false, or null
  [ticket/11943] Add test for DEFINE $VAR = false
2013-11-11 18:23:37 +01:00
Nathan Guse
47e364ae68 [ticket/11943] New line at EOF for define_error.html
PHPBB3-11943
2013-11-11 10:59:17 -06:00
Joas Schilling
a74c560eca [ticket/11525] Fix expected value of group avatar test
PHPBB3-11525
2013-11-11 00:02:12 +01:00
Joas Schilling
32ba402c34 [ticket/11525] Compare correct array to expected value
PHPBB3-11525
2013-11-11 00:01:31 +01:00
Marc Alexander
95c2b12bf7 [ticket/11896] Add functional tests for marking all notifications read
PHPBB3-11896
2013-11-09 20:35:37 +01:00
Marc Alexander
29d3b08d50 [ticket/11896] Add ability to define expected message after posting
This change will add the ability to define the expected message after a
topic or post has been submitted with the methods create_post() and
create_topic(). If the expected message is not 'POST_STORED', we will not
try to get the topic and post id.

PHPBB3-11896
2013-11-09 20:33:01 +01:00
Nathan Guse
64ed46e682 [ticket/11943] Forgot template file for test
PHPBB3-11943
2013-11-09 11:39:35 -06:00
Nathan Guse
2e5117a71e [ticket/11943] Throw an exception if DEFINE is setup improperly
PHPBB3-11943
2013-11-09 11:14:55 -06:00
Marc Alexander
60dda5577d [ticket/11997] Correctly redirect to front controllers
We currently do a lot of checks in order to prevent users from getting to
a 404 page. However, this logic relies on checking if a file or folder exists.
Due to the front controllers and the URL rewriting in 3.1, it is no longer
possible to rely on existing files for redirecting. This patch will take
care of properly redirecting users to front controller files. An incorrect
link will cause users to get a 404 error though.

PHPBB3-11997
2013-11-08 23:12:42 +01:00
Joas Schilling
7a8a440895 [ticket/12002] Change functional test to use link hash
PHPBB3-12002
2013-11-08 14:08:55 +01:00
Joas Schilling
bf7eab423e [ticket/11994] Fix functional tests
PHPBB3-11994
2013-11-08 01:20:04 +01:00
Joas Schilling
d17bf9aa27 [ticket/11994] "Delete data" is only available for disabled extensions
PHPBB3-11994
2013-11-08 01:20:03 +01:00
Joas Schilling
12a6e2c603 [ticket/11994] Filter crawler for better search comparisons
PHPBB3-11994
2013-11-08 01:20:02 +01:00
Joas Schilling
40fcc906a2 [ticket/11994] Fix tests after uninstall rename
PHPBB3-11994
2013-11-08 01:20:00 +01:00
Joas Schilling
476464374a [ticket/11994] Update functional tests with display name
PHPBB3-11994
2013-11-08 01:19:58 +01:00
Joas Schilling
e60588a259 [ticket/11994] Replace spaces with tabs
PHPBB3-11994
2013-11-08 01:19:56 +01:00
Joas Schilling
f98ddb23e8 [ticket/11994] Fix functional extension tests
PHPBB3-11994
2013-11-08 01:19:55 +01:00
Joas Schilling
95348c8f6d [ticket/11927] Prefix function with phpbb_
PHPBB3-11927
2013-11-07 13:49:55 +01:00
Joas Schilling
7aa4d8fce2 [ticket/11927] Correctly add new files on update
Currently we ignore language and style files when the directory where they
go to do not exist. However in 3.1 we introduce some new sub directories:
* language/en/email/short/
* styles/prosilver/theme/en/
So we need to change our check to look whether the language or style exist,
rather then the parent directory.

PHPBB3-11927
2013-11-07 13:12:58 +01:00
Nathan Guse
cc54e6a9e5 Merge pull request #1819 from marc1706/ticket/11534
[ticket/11534] Check remote avatar content type if possible
2013-11-04 10:22:28 -08:00
Nathan Guse
c609f25bae [ticket/11943] Add test for DEFINE $VAR = false
PHPBB3-11943
2013-11-04 12:15:02 -06:00
Joas Schilling
e8a3028ea6 [ticket/11995] Remove exceptions and split reverse into different tests
PHPBB3-11995
2013-11-02 19:26:45 +01:00
Joas Schilling
a175b091b9 [ticket/11995] Add unit test for reverting config.remove
PHPBB3-11995
2013-11-02 18:12:50 +01:00
Marc Alexander
b2f638b793 [ticket/11857] Use passed service collection instead of container in manager
The service collection that was already passed to the avatar manager should
be used in the avatar manager method get_driver() instead of the container
itself.

PHPBB3-11857
2013-10-27 15:08:58 +01:00
Marc Alexander
a4d50d52b6 [feature/passwords] Use correct default type in manager_test
PHPBB3-11610
2013-10-27 14:29:36 +01:00
Marc Alexander
5193b3279c [feature/passwords] Pass list of default types to passwords manager
This list is in the order of how the driver types would be used. If a driver
is not supported we will try the subsequent one.

PHPBB3-11610
2013-10-27 14:18:02 +01:00
Marc Alexander
760f148a2b [feature/passwords] Fix tests on PHP < 5.3.3 again
PHPBB3-11610
2013-10-27 13:22:53 +01:00
Marc Alexander
bb836b65e3 [feature/passwords] Integrate convert_flag with db auth provider
PHPBB3-11610
2013-10-25 15:21:09 +02:00
Marc Alexander
9b0b5481fe [ticket/11534] Check remote avatar content type if possible
This should make sure that error pages like 404 or 503 pages are not treated
as remote avatar images.

PHPBB3-11534
2013-10-24 23:43:40 +02:00
Marc Alexander
1f624e1367 [ticket/11842] Replace outdated occurences of user and group avatar_type
user_avatar_type und group_avatar_type are now a string and should therefore
be treated accordingly.

PHPBB3-11842
2013-10-24 21:41:41 +02:00
Marc Alexander
9d4d212e0f [ticket/11525] Only remove group or user prefix from given avatar data
Until now, the user data had both user_id and group_id keys in the avatar
data. As both group_ and user_ prefixes were removed the group_id was
collapsed onto the user_id and therefore all users in the same group had
the same prefix for their uploaded avatars. This patch will make sure
that the correct id is used depending on whether it's a group's or user's
avatar data.

PHPBB3-11525
2013-10-24 13:55:23 +02:00
Marc Alexander
bc7ff47537 [ticket/11912] Supply filename to content_guesser for guessing on windows
The filename of the files sent to the guesser by plupload do not contain
the file extension. Therefore, it's impossible to guess the mimetype if
only the content_guesser is available and the function mime_content_type()
doesn't exist. By supplying the filename we can circumvent this issue.

PHPBB3-11912
2013-10-24 12:05:00 +02:00